* RE: please help backporting some patches to stable release 19.11.14
[not found] <20221111114814.1553136-1-christian.ehrhardt@canonical.com>
@ 2022-11-14 9:57 ` Nicolau, Radu
2022-11-17 8:17 ` 答复: " Mao,Yingming
2022-11-16 10:45 ` Morten Brørup
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Nicolau, Radu @ 2022-11-14 9:57 UTC (permalink / raw)
To: dpdk stable
Cc: Konstantin Ananyev, Konstantin Ananyev, Kumara Parameshwaran,
Lijun Ou, Lior Margalit, Long Li, Long Wu, Mah, Yock Gen,
Mao YingMing, Matan Azrad, Matan Azrad, mattias.ronnblom,
Maxime Coquelin, Min Hu (Connor),
Morten Brørup, Rao, Nikhil, Niklas Soderlund,
Nithin Dabilpuram, Matz, Olivier, Ori Kam, De Lara Guarch, Pablo,
Stillwell Jr, Paul M, Pavan Nikhilesh, Peng Zhang, Yang, Qiming,
Zhang, Qi Z, Raja Zidane, Remy Horton, Rolf Neugebauer,
Shahaf Shuler, Shally Verma, Shijith Thotton, Shiqi Liu, Su,
Simei, Somnath Kotur, Suanming Mou, Sunila Sahu, Taripin, Samuel,
Umesh Kartha, Usman Tanveer, Viacheslav Ovsiienko, Medvedkin,
Vladimir, Wei Hu (Xavier),
Ling, WeiX, Ma, WenwuX, Lu, Wenzhuo, Zhou, YidingX, Yisen Zhuang,
Yongseok Koh, Wang, YuanX
c05f2e9688 Radu Nicolau examples/ipsec-secgw: fix Tx checksum offload flag
Does not need to be backported and does not apply to 19.11
Regards,
Radu
-----Original Message-----
From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
Sent: Friday, November 11, 2022 11:48 AM
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>; Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Kumara Parameshwaran <kumaraparamesh92@gmail.com>; Lijun Ou <oulijun@huawei.com>; Lior Margalit <lmargalit@nvidia.com>; Long Li <longli@microsoft.com>; Long Wu <long.wu@corigine.com>; Mah, Yock Gen <yock.gen.mah@intel.com>; Mao YingMing <maoyingming@baidu.com>; Matan Azrad <matan@mellanox.com>; Matan Azrad <matan@nvidia.com>; mattias.ronnblom <mattias.ronnblom@ericsson.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Min Hu (Connor) <humin29@huawei.com>; Morten Brørup <mb@smartsharesystems.com>; Rao, Nikhil <nikhil.rao@intel.com>; Niklas Soderlund <niklas.soderlund@corigine.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Matz, Olivier <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Peng Zhang <peng.zhang@corigine.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>; Raja Zidane <rzidane@nvidia.com>; Remy Horton <remy.horton@intel.com>; Rolf Neugebauer <rolf.neugebauer@netronome.com>; Shahaf Shuler <shahafs@mellanox.com>; Shally Verma <shally.verma@caviumnetworks.com>; Shijith Thotton <sthotton@marvell.com>; Shiqi Liu <835703180@qq.com>; Su, Simei <simei.su@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Suanming Mou <suanmingm@mellanox.com>; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Taripin, Samuel <samuel.taripin@intel.com>; Umesh Kartha <umesh.kartha@caviumnetworks.com>; Usman Tanveer <usman.tanveer@emumba.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>; Ling, WeiX <weix.ling@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhou, YidingX <yidingx.zhou@intel.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Yongseok Koh <yskoh@mellanox.com>; Wang, YuanX <yuanx.wang@intel.com>
Subject: please help backporting some patches to stable release 19.11.14
Hi commit authors (and maintainers),
Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I didn't apply following commits from DPDK main to 19.11 stable branch, as conflicts or build errors occur.
Can authors check your patches in the following list and either:
- Backport your patches to the 19.11 branch, or
- Indicate that the patch should not be backported
Please do either of the above by 11/18/22.
You can find the a temporary work-in-progress branch of the coming 19.11.14 release at:
https://github.com/cpaelzer/dpdk-stable-queue
It is recommended to backport on top of that to minimize further conflicts or misunderstandings.
Some notes on stable backports:
A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion:
[ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
For example:
https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example:
[PATCH 19.11] foo/bar: fix baz
With git format-patch, this can be achieved by appending the parameter:
--subject-prefix='PATCH 19.11'
Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
FYI, branch 19.11 is located at tree:
https://git.dpdk.org/dpdk-stable
Thanks.
Christian Ehrhardt <christian.ehrhardt@canonical.com>
P.S. I had to split the mail again to obey rules of mail providers
---
09b5b2880d Benjamin Le Berre net/bnxt: fix error code during MTU change
830f7e7907 Changpeng Liu vhost: add non-blocking API for posting interrupt
bc6eeb29c6 Chengwen Feng net/hns3: fix VF mailbox message handling
12590fc503 Chengwen Feng net/hns3: optimize SVE Tx performance
e0ec62d6e9 Chengwen Feng net/hns3: revert fix mailbox communication with HW
1a7374c956 Dmitry Kozlyuk eal: fix side effect in some pointer arithmetic macros
329280c53e Erik Gabriel Carrillo service: fix early move to inactive status
8f4ff7de39 Ganapati Kundapura eventdev/crypto: fix multi-process
c05a540902 Huisong Li net/hns3: delete unused markup
b38bd88beb Huisong Li net/hns3: fix clearing hardware MAC statistics
a35799625e Huisong Li net/hns3: fix lock protection of RSS flow rule
904ee370e8 Huisong Li net/hns3: fix packet type for GENEVE
1042ed401f Huisong Li net/hns3: fix restore filter function input
705a508003 Huisong Li net/hns3: fix RSS filter restore
43d8adf389 Huisong Li net/hns3: fix RSS flow rule restore
0d81da2559 Huisong Li net/hns3: fix RSS rule restore
860ed8516a Huisong Li net/hns3: move flow direction rule recovery
df810d1b6e Ivan Malov net/bonding: fix flow flush order on close
9f71a297da Jiawei Wang net/mlx5: fix modify action with tunnel decapsulation
bfa87e21bd Jiawei Wang net/mlx5: fix tunnel header with IPIP offload
b8a55871d5 Jun Qiu gro: trim tail padding bytes
aaa44cb125 Kalesh AP net/bnxt: remove unnecessary check
19ee91c6bd Kevin Liu net/iavf: check illegal packet sizes
72f51b097a Kumara Parameshwaran gro: check payload length after trim
bc5d8fdb70 Long Li net/mlx5: fix Verbs FD leak in secondary process
bb340f56fc Long Wu net/nfp: fix memory leak in Rx
4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
60b254e392 Matan Azrad net/mlx5: fix Rx queue recovery mechanism
70cb0278a4 Mattias Rönnblom event/dsw: fix flow migration
459531c958 Morten Brørup mempool: fix cache flushing algorithm
a2833ecc5e Morten Brørup mempool: fix get objects from mempool with cache
4edcee19fc Nithin Dabilpuram examples/ipsec-secgw: use Tx checksum offload conditionally
a0a17e2a3e Olivier Matz cryptodev: fix unduly newlines in logs
d5262b521d Olivier Matz mem: fix API doc about allocation on secondary processes
927cb43fe9 Pavan Nikhilesh examples/l3fwd: fix port group mask with AltiVec
dbad6f64f9 Peng Zhang net/nfp: fix internal buffer size and MTU check
b0472e210f Qi Zhang net/ice/base: fix input set of GTPoGRE
c05f2e9688 Radu Nicolau examples/ipsec-secgw: fix Tx checksum offload flag
130bb7da53 Raja Zidane net/mlx5: fix Tx check for hardware descriptor length
d914c01036 Shiqi Liu node: check Rx element allocation
f66323717e Usman Tanveer net/bonding: fix mode 4 with dedicated queues
d15bfd2930 Viacheslav Ovsiienko net/mlx5: fix inline length exceeding descriptor limit
40abb903fe Wenwu Ma examples/vhost: fix use after free
cb5c1b91f7 Yiding Zhou net/iavf: add thread for event callbacks
^ permalink raw reply [flat|nested] 9+ messages in thread* 答复: please help backporting some patches to stable release 19.11.14
2022-11-14 9:57 ` please help backporting some patches to stable release 19.11.14 Nicolau, Radu
@ 2022-11-17 8:17 ` Mao,Yingming
2022-11-17 8:19 ` Christian Ehrhardt
0 siblings, 1 reply; 9+ messages in thread
From: Mao,Yingming @ 2022-11-17 8:17 UTC (permalink / raw)
To: dpdk stable, christian.ehrhardt, Somnath Kotur, Ajit Khaparde
Cc: Konstantin Ananyev, Konstantin Ananyev, Kumara Parameshwaran,
Lijun Ou, Lior Margalit, Long Li, Long Wu, Mah, Yock Gen,
Matan Azrad, Matan Azrad, mattias.ronnblom, Maxime Coquelin,
Min Hu (Connor),
Morten Brørup, Rao, Nikhil, Niklas Soderlund,
Nithin Dabilpuram, Matz, Olivier, Ori Kam, De Lara Guarch, Pablo,
Stillwell Jr, Paul M, Pavan Nikhilesh, Peng Zhang, Yang, Qiming,
Zhang, Qi Z, Raja Zidane, Remy Horton, Rolf Neugebauer,
Shahaf Shuler, Shally Verma, Shijith Thotton, Shiqi Liu, Su,
Simei, Somnath Kotur, Suanming Mou, Sunila Sahu, Taripin, Samuel,
Umesh Kartha, Usman Tanveer, Viacheslav Ovsiienko, Medvedkin,
Vladimir, Wei Hu (Xavier),
Ling, WeiX, Ma, WenwuX, Lu, Wenzhuo, Zhou, YidingX, Yisen Zhuang,
Yongseok Koh, Wang, YuanX
Hi all,
4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
Does not need to be backported and does not apply to 19.11
Regards,
Mao YingMing
-----Original Message-----
From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
Sent: Friday, November 11, 2022 11:48 AM
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>; Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Kumara Parameshwaran <kumaraparamesh92@gmail.com>; Lijun Ou <oulijun@huawei.com>; Lior Margalit <lmargalit@nvidia.com>; Long Li <longli@microsoft.com>; Long Wu <long.wu@corigine.com>; Mah, Yock Gen <yock.gen.mah@intel.com>; Mao YingMing <maoyingming@baidu.com>; Matan Azrad <matan@mellanox.com>; Matan Azrad <matan@nvidia.com>; mattias.ronnblom <mattias.ronnblom@ericsson.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Min Hu (Connor) <humin29@huawei.com>; Morten Brørup <mb@smartsharesystems.com>; Rao, Nikhil <nikhil.rao@intel.com>; Niklas Soderlund <niklas.soderlund@corigine.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Matz, Olivier <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Peng Zhang <peng.zhang@corigine.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>; Raja Zidane <rzidane@nvidia.com>; Remy Horton <remy.horton@intel.com>; Rolf Neugebauer <rolf.neugebauer@netronome.com>; Shahaf Shuler <shahafs@mellanox.com>; Shally Verma <shally.verma@caviumnetworks.com>; Shijith Thotton <sthotton@marvell.com>; Shiqi Liu <835703180@qq.com>; Su, Simei <simei.su@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Suanming Mou <suanmingm@mellanox.com>; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Taripin, Samuel <samuel.taripin@intel.com>; Umesh Kartha <umesh.kartha@caviumnetworks.com>; Usman Tanveer <usman.tanveer@emumba.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>; Ling, WeiX <weix.ling@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhou, YidingX <yidingx.zhou@intel.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Yongseok Koh <yskoh@mellanox.com>; Wang, YuanX <yuanx.wang@intel.com>
Subject: please help backporting some patches to stable release 19.11.14
Hi commit authors (and maintainers),
Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I didn't apply following commits from DPDK main to 19.11 stable branch, as conflicts or build errors occur.
Can authors check your patches in the following list and either:
- Backport your patches to the 19.11 branch, or
- Indicate that the patch should not be backported
Please do either of the above by 11/18/22.
You can find the a temporary work-in-progress branch of the coming 19.11.14 release at:
https://github.com/cpaelzer/dpdk-stable-queue
It is recommended to backport on top of that to minimize further conflicts or misunderstandings.
Some notes on stable backports:
A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion:
[ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
For example:
https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example:
[PATCH 19.11] foo/bar: fix baz
With git format-patch, this can be achieved by appending the parameter:
--subject-prefix='PATCH 19.11'
Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
FYI, branch 19.11 is located at tree:
https://git.dpdk.org/dpdk-stable
Thanks.
Christian Ehrhardt <christian.ehrhardt@canonical.com>
P.S. I had to split the mail again to obey rules of mail providers
---
09b5b2880d Benjamin Le Berre net/bnxt: fix error code during MTU change
830f7e7907 Changpeng Liu vhost: add non-blocking API for posting interrupt
bc6eeb29c6 Chengwen Feng net/hns3: fix VF mailbox message handling
12590fc503 Chengwen Feng net/hns3: optimize SVE Tx performance
e0ec62d6e9 Chengwen Feng net/hns3: revert fix mailbox communication with HW
1a7374c956 Dmitry Kozlyuk eal: fix side effect in some pointer arithmetic macros
329280c53e Erik Gabriel Carrillo service: fix early move to inactive status
8f4ff7de39 Ganapati Kundapura eventdev/crypto: fix multi-process
c05a540902 Huisong Li net/hns3: delete unused markup
b38bd88beb Huisong Li net/hns3: fix clearing hardware MAC statistics
a35799625e Huisong Li net/hns3: fix lock protection of RSS flow rule
904ee370e8 Huisong Li net/hns3: fix packet type for GENEVE
1042ed401f Huisong Li net/hns3: fix restore filter function input
705a508003 Huisong Li net/hns3: fix RSS filter restore
43d8adf389 Huisong Li net/hns3: fix RSS flow rule restore
0d81da2559 Huisong Li net/hns3: fix RSS rule restore
860ed8516a Huisong Li net/hns3: move flow direction rule recovery
df810d1b6e Ivan Malov net/bonding: fix flow flush order on close
9f71a297da Jiawei Wang net/mlx5: fix modify action with tunnel decapsulation
bfa87e21bd Jiawei Wang net/mlx5: fix tunnel header with IPIP offload
b8a55871d5 Jun Qiu gro: trim tail padding bytes
aaa44cb125 Kalesh AP net/bnxt: remove unnecessary check
19ee91c6bd Kevin Liu net/iavf: check illegal packet sizes
72f51b097a Kumara Parameshwaran gro: check payload length after trim
bc5d8fdb70 Long Li net/mlx5: fix Verbs FD leak in secondary process
bb340f56fc Long Wu net/nfp: fix memory leak in Rx
4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
60b254e392 Matan Azrad net/mlx5: fix Rx queue recovery mechanism
70cb0278a4 Mattias Rönnblom event/dsw: fix flow migration
459531c958 Morten Brørup mempool: fix cache flushing algorithm
a2833ecc5e Morten Brørup mempool: fix get objects from mempool with cache
4edcee19fc Nithin Dabilpuram examples/ipsec-secgw: use Tx checksum offload conditionally
a0a17e2a3e Olivier Matz cryptodev: fix unduly newlines in logs
d5262b521d Olivier Matz mem: fix API doc about allocation on secondary processes
927cb43fe9 Pavan Nikhilesh examples/l3fwd: fix port group mask with AltiVec
dbad6f64f9 Peng Zhang net/nfp: fix internal buffer size and MTU check
b0472e210f Qi Zhang net/ice/base: fix input set of GTPoGRE
c05f2e9688 Radu Nicolau examples/ipsec-secgw: fix Tx checksum offload flag
130bb7da53 Raja Zidane net/mlx5: fix Tx check for hardware descriptor length
d914c01036 Shiqi Liu node: check Rx element allocation
f66323717e Usman Tanveer net/bonding: fix mode 4 with dedicated queues
d15bfd2930 Viacheslav Ovsiienko net/mlx5: fix inline length exceeding descriptor limit
40abb903fe Wenwu Ma examples/vhost: fix use after free
cb5c1b91f7 Yiding Zhou net/iavf: add thread for event callbacks
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: please help backporting some patches to stable release 19.11.14
2022-11-17 8:17 ` 答复: " Mao,Yingming
@ 2022-11-17 8:19 ` Christian Ehrhardt
0 siblings, 0 replies; 9+ messages in thread
From: Christian Ehrhardt @ 2022-11-17 8:19 UTC (permalink / raw)
To: Mao,Yingming
Cc: dpdk stable, Somnath Kotur, Ajit Khaparde, Konstantin Ananyev,
Konstantin Ananyev, Kumara Parameshwaran, Lijun Ou,
Lior Margalit, Long Li, Long Wu, Mah, Yock Gen, Matan Azrad,
Matan Azrad, mattias.ronnblom, Maxime Coquelin, Min Hu (Connor),
Morten Brørup, Rao, Nikhil, Niklas Soderlund,
Nithin Dabilpuram, Matz, Olivier, Ori Kam, De Lara Guarch, Pablo,
Stillwell Jr, Paul M, Pavan Nikhilesh, Peng Zhang, Yang, Qiming,
Zhang, Qi Z, Raja Zidane, Remy Horton, Rolf Neugebauer,
Shahaf Shuler, Shally Verma, Shijith Thotton, Shiqi Liu, Su,
Simei, Suanming Mou, Sunila Sahu, Taripin, Samuel, Umesh Kartha,
Usman Tanveer, Viacheslav Ovsiienko, Medvedkin, Vladimir,
Wei Hu (Xavier),
Ling, WeiX, Ma, WenwuX, Lu, Wenzhuo, Zhou, YidingX, Yisen Zhuang,
Yongseok Koh, Wang, YuanX
On Thu, Nov 17, 2022 at 9:18 AM Mao,Yingming <maoyingming@baidu.com> wrote:
>
> Hi all,
>
> 4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
> Does not need to be backported and does not apply to 19.11
Ok, thanks!
> Regards,
> Mao YingMing
>
> -----Original Message-----
> From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> Sent: Friday, November 11, 2022 11:48 AM
> Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>; Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Kumara Parameshwaran <kumaraparamesh92@gmail.com>; Lijun Ou <oulijun@huawei.com>; Lior Margalit <lmargalit@nvidia.com>; Long Li <longli@microsoft.com>; Long Wu <long.wu@corigine.com>; Mah, Yock Gen <yock.gen.mah@intel.com>; Mao YingMing <maoyingming@baidu.com>; Matan Azrad <matan@mellanox.com>; Matan Azrad <matan@nvidia.com>; mattias.ronnblom <mattias.ronnblom@ericsson.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Min Hu (Connor) <humin29@huawei.com>; Morten Brørup <mb@smartsharesystems.com>; Rao, Nikhil <nikhil.rao@intel.com>; Niklas Soderlund <niklas.soderlund@corigine.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Matz, Olivier <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Peng Zhang <peng.zhang@corigine.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>; Raja Zidane <rzidane@nvidia.com>; Remy Horton <remy.horton@intel.com>; Rolf Neugebauer <rolf.neugebauer@netronome.com>; Shahaf Shuler <shahafs@mellanox.com>; Shally Verma <shally.verma@caviumnetworks.com>; Shijith Thotton <sthotton@marvell.com>; Shiqi Liu <835703180@qq.com>; Su, Simei <simei.su@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Suanming Mou <suanmingm@mellanox.com>; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Taripin, Samuel <samuel.taripin@intel.com>; Umesh Kartha <umesh.kartha@caviumnetworks.com>; Usman Tanveer <usman.tanveer@emumba.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>; Ling, WeiX <weix.ling@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhou, YidingX <yidingx.zhou@intel.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Yongseok Koh <yskoh@mellanox.com>; Wang, YuanX <yuanx.wang@intel.com>
> Subject: please help backporting some patches to stable release 19.11.14
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I didn't apply following commits from DPDK main to 19.11 stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
> - Backport your patches to the 19.11 branch, or
> - Indicate that the patch should not be backported
>
> Please do either of the above by 11/18/22.
>
> You can find the a temporary work-in-progress branch of the coming 19.11.14 release at:
> https://github.com/cpaelzer/dpdk-stable-queue
> It is recommended to backport on top of that to minimize further conflicts or misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion:
> [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
> https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example:
> [PATCH 19.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
> --subject-prefix='PATCH 19.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 19.11 is located at tree:
> https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> P.S. I had to split the mail again to obey rules of mail providers
>
> ---
> 09b5b2880d Benjamin Le Berre net/bnxt: fix error code during MTU change
> 830f7e7907 Changpeng Liu vhost: add non-blocking API for posting interrupt
> bc6eeb29c6 Chengwen Feng net/hns3: fix VF mailbox message handling
> 12590fc503 Chengwen Feng net/hns3: optimize SVE Tx performance
> e0ec62d6e9 Chengwen Feng net/hns3: revert fix mailbox communication with HW
> 1a7374c956 Dmitry Kozlyuk eal: fix side effect in some pointer arithmetic macros
> 329280c53e Erik Gabriel Carrillo service: fix early move to inactive status
> 8f4ff7de39 Ganapati Kundapura eventdev/crypto: fix multi-process
> c05a540902 Huisong Li net/hns3: delete unused markup
> b38bd88beb Huisong Li net/hns3: fix clearing hardware MAC statistics
> a35799625e Huisong Li net/hns3: fix lock protection of RSS flow rule
> 904ee370e8 Huisong Li net/hns3: fix packet type for GENEVE
> 1042ed401f Huisong Li net/hns3: fix restore filter function input
> 705a508003 Huisong Li net/hns3: fix RSS filter restore
> 43d8adf389 Huisong Li net/hns3: fix RSS flow rule restore
> 0d81da2559 Huisong Li net/hns3: fix RSS rule restore
> 860ed8516a Huisong Li net/hns3: move flow direction rule recovery
> df810d1b6e Ivan Malov net/bonding: fix flow flush order on close
> 9f71a297da Jiawei Wang net/mlx5: fix modify action with tunnel decapsulation
> bfa87e21bd Jiawei Wang net/mlx5: fix tunnel header with IPIP offload
> b8a55871d5 Jun Qiu gro: trim tail padding bytes
> aaa44cb125 Kalesh AP net/bnxt: remove unnecessary check
> 19ee91c6bd Kevin Liu net/iavf: check illegal packet sizes
> 72f51b097a Kumara Parameshwaran gro: check payload length after trim
> bc5d8fdb70 Long Li net/mlx5: fix Verbs FD leak in secondary process
> bb340f56fc Long Wu net/nfp: fix memory leak in Rx
> 4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
> 4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
> 60b254e392 Matan Azrad net/mlx5: fix Rx queue recovery mechanism
> 70cb0278a4 Mattias Rönnblom event/dsw: fix flow migration
> 459531c958 Morten Brørup mempool: fix cache flushing algorithm
> a2833ecc5e Morten Brørup mempool: fix get objects from mempool with cache
> 4edcee19fc Nithin Dabilpuram examples/ipsec-secgw: use Tx checksum offload conditionally
> a0a17e2a3e Olivier Matz cryptodev: fix unduly newlines in logs
> d5262b521d Olivier Matz mem: fix API doc about allocation on secondary processes
> 927cb43fe9 Pavan Nikhilesh examples/l3fwd: fix port group mask with AltiVec
> dbad6f64f9 Peng Zhang net/nfp: fix internal buffer size and MTU check
> b0472e210f Qi Zhang net/ice/base: fix input set of GTPoGRE
> c05f2e9688 Radu Nicolau examples/ipsec-secgw: fix Tx checksum offload flag
> 130bb7da53 Raja Zidane net/mlx5: fix Tx check for hardware descriptor length
> d914c01036 Shiqi Liu node: check Rx element allocation
> f66323717e Usman Tanveer net/bonding: fix mode 4 with dedicated queues
> d15bfd2930 Viacheslav Ovsiienko net/mlx5: fix inline length exceeding descriptor limit
> 40abb903fe Wenwu Ma examples/vhost: fix use after free
> cb5c1b91f7 Yiding Zhou net/iavf: add thread for event callbacks
--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: please help backporting some patches to stable release 19.11.14
[not found] <20221111114814.1553136-1-christian.ehrhardt@canonical.com>
2022-11-14 9:57 ` please help backporting some patches to stable release 19.11.14 Nicolau, Radu
@ 2022-11-16 10:45 ` Morten Brørup
2022-11-17 6:27 ` Christian Ehrhardt
2022-11-16 23:23 ` Mah, Yock Gen
2022-11-17 14:33 ` Niklas Soderlund
3 siblings, 1 reply; 9+ messages in thread
From: Morten Brørup @ 2022-11-16 10:45 UTC (permalink / raw)
To: dpdk stable
Cc: Konstantin Ananyev, Konstantin Ananyev, Kumara Parameshwaran,
Lijun Ou, Lior Margalit, Long Li, Long Wu, Mah Yock Gen,
Mao YingMing, Matan Azrad, Matan Azrad, Mattias Rönnblom,
Maxime Coquelin, Min Hu (Connor),
Nikhil Rao, Niklas Soderlund, Nithin Dabilpuram, Olivier Matz,
Ori Kam, Pablo de Lara, Paul M Stillwell Jr, Pavan Nikhilesh,
Peng Zhang, Qiming Yang, Qi Zhang, Radu Nicolau, Raja Zidane,
Remy Horton, Rolf Neugebauer, Shahaf Shuler, Shally Verma,
Shijith Thotton, Shiqi Liu, Simei Su, Somnath Kotur,
Suanming Mou, Sunila Sahu, Taripin Samuel, Umesh Kartha,
Usman Tanveer, Viacheslav Ovsiienko, Vladimir Medvedkin,
Wei Hu (Xavier),
Wei Ling, Wenwu Ma, Wenzhuo Lu, Yiding Zhou, Yisen Zhuang,
Yongseok Koh, Yuan Wang
> From: christian.ehrhardt@canonical.com
> Sent: Friday, 11 November 2022 12.48
[...]
> 459531c958 Morten Brørup mempool: fix cache flushing algorithm
> a2833ecc5e Morten Brørup mempool: fix get objects from mempool with
> cache
These two patches fixes some performance issues for certain use cases. The affected use cases work without the patches, but don't get the improved performance.
However, these patches change the inner workings of the mempool cache.
And since some PMDs bypass the mempool API and interact directly with the mempool caches, there is a risk that applications do the same.
Although these patches are relevant for the performance of the affected use cases, I fear that backporting them would introduce an unwanted risk of breaking PMDs and/or applications (generally, not just for the affected use cases).
For the common good, I prefer not backporting them. Anyone feel free to speak up if you disagree.
We have a policy of not backporting performance improvements, and fixing a lack of performance could be interpreted as falling under this policy.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: please help backporting some patches to stable release 19.11.14
2022-11-16 10:45 ` Morten Brørup
@ 2022-11-17 6:27 ` Christian Ehrhardt
2022-11-17 7:25 ` Christian Ehrhardt
0 siblings, 1 reply; 9+ messages in thread
From: Christian Ehrhardt @ 2022-11-17 6:27 UTC (permalink / raw)
To: Morten Brørup
Cc: dpdk stable, Konstantin Ananyev, Konstantin Ananyev,
Kumara Parameshwaran, Lijun Ou, Lior Margalit, Long Li, Long Wu,
Mah Yock Gen, Mao YingMing, Matan Azrad, Matan Azrad,
Mattias Rönnblom, Maxime Coquelin, Min Hu (Connor),
Nikhil Rao, Niklas Soderlund, Nithin Dabilpuram, Olivier Matz,
Ori Kam, Pablo de Lara, Paul M Stillwell Jr, Pavan Nikhilesh,
Peng Zhang, Qiming Yang, Qi Zhang, Radu Nicolau, Raja Zidane,
Remy Horton, Rolf Neugebauer, Shahaf Shuler, Shally Verma,
Shijith Thotton, Shiqi Liu, Simei Su, Somnath Kotur,
Suanming Mou, Sunila Sahu, Taripin Samuel, Umesh Kartha,
Usman Tanveer, Viacheslav Ovsiienko, Vladimir Medvedkin,
Wei Hu (Xavier),
Wei Ling, Wenwu Ma, Wenzhuo Lu, Yiding Zhou, Yisen Zhuang,
Yongseok Koh, Yuan Wang
On Wed, Nov 16, 2022 at 11:45 AM Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > From: christian.ehrhardt@canonical.com
> > Sent: Friday, 11 November 2022 12.48
>
> [...]
>
> > 459531c958 Morten Brørup mempool: fix cache flushing algorithm
> > a2833ecc5e Morten Brørup mempool: fix get objects from mempool with
> > cache
>
> These two patches fixes some performance issues for certain use cases. The affected use cases work without the patches, but don't get the improved performance.
>
> However, these patches change the inner workings of the mempool cache.
>
> And since some PMDs bypass the mempool API and interact directly with the mempool caches, there is a risk that applications do the same.
>
> Although these patches are relevant for the performance of the affected use cases, I fear that backporting them would introduce an unwanted risk of breaking PMDs and/or applications (generally, not just for the affected use cases).
Thanks for your thoughts, I completely agree.
Let us now backport them and keep -stable stable.
> For the common good, I prefer not backporting them. Anyone feel free to speak up if you disagree.
>
> We have a policy of not backporting performance improvements, and fixing a lack of performance could be interpreted as falling under this policy.
>
--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: please help backporting some patches to stable release 19.11.14
2022-11-17 6:27 ` Christian Ehrhardt
@ 2022-11-17 7:25 ` Christian Ehrhardt
0 siblings, 0 replies; 9+ messages in thread
From: Christian Ehrhardt @ 2022-11-17 7:25 UTC (permalink / raw)
To: Morten Brørup
Cc: dpdk stable, Konstantin Ananyev, Konstantin Ananyev,
Kumara Parameshwaran, Lijun Ou, Lior Margalit, Long Li, Long Wu,
Mah Yock Gen, Mao YingMing, Matan Azrad, Matan Azrad,
Mattias Rönnblom, Maxime Coquelin, Min Hu (Connor),
Nikhil Rao, Niklas Soderlund, Nithin Dabilpuram, Olivier Matz,
Ori Kam, Pablo de Lara, Paul M Stillwell Jr, Pavan Nikhilesh,
Peng Zhang, Qiming Yang, Qi Zhang, Radu Nicolau, Raja Zidane,
Remy Horton, Rolf Neugebauer, Shahaf Shuler, Shally Verma,
Shijith Thotton, Shiqi Liu, Simei Su, Somnath Kotur,
Suanming Mou, Sunila Sahu, Taripin Samuel, Umesh Kartha,
Usman Tanveer, Viacheslav Ovsiienko, Vladimir Medvedkin,
Wei Hu (Xavier),
Wei Ling, Wenwu Ma, Wenzhuo Lu, Yiding Zhou, Yisen Zhuang,
Yongseok Koh, Yuan Wang
On Thu, Nov 17, 2022 at 7:27 AM Christian Ehrhardt
<christian.ehrhardt@canonical.com> wrote:
>
> On Wed, Nov 16, 2022 at 11:45 AM Morten Brørup <mb@smartsharesystems.com> wrote:
> >
> > > From: christian.ehrhardt@canonical.com
> > > Sent: Friday, 11 November 2022 12.48
> >
> > [...]
> >
> > > 459531c958 Morten Brørup mempool: fix cache flushing algorithm
> > > a2833ecc5e Morten Brørup mempool: fix get objects from mempool with
> > > cache
> >
> > These two patches fixes some performance issues for certain use cases. The affected use cases work without the patches, but don't get the improved performance.
> >
> > However, these patches change the inner workings of the mempool cache.
> >
> > And since some PMDs bypass the mempool API and interact directly with the mempool caches, there is a risk that applications do the same.
> >
> > Although these patches are relevant for the performance of the affected use cases, I fear that backporting them would introduce an unwanted risk of breaking PMDs and/or applications (generally, not just for the affected use cases).
>
> Thanks for your thoughts, I completely agree.
> Let us now backport them and keep -stable stable.
Arrr, thanks Morten for making me aware!
Some typos do not matter, others completely break what you wanted to say ...
Let us NOT backport them is what I meant to say :-)
> > For the common good, I prefer not backporting them. Anyone feel free to speak up if you disagree.
> >
> > We have a policy of not backporting performance improvements, and fixing a lack of performance could be interpreted as falling under this policy.
> >
>
>
> --
> Christian Ehrhardt
> Senior Staff Engineer, Ubuntu Server
> Canonical Ltd
--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: please help backporting some patches to stable release 19.11.14
[not found] <20221111114814.1553136-1-christian.ehrhardt@canonical.com>
2022-11-14 9:57 ` please help backporting some patches to stable release 19.11.14 Nicolau, Radu
2022-11-16 10:45 ` Morten Brørup
@ 2022-11-16 23:23 ` Mah, Yock Gen
2022-11-17 8:49 ` Christian Ehrhardt
2022-11-17 14:33 ` Niklas Soderlund
3 siblings, 1 reply; 9+ messages in thread
From: Mah, Yock Gen @ 2022-11-16 23:23 UTC (permalink / raw)
To: dpdk stable
Cc: Konstantin Ananyev, Konstantin Ananyev, Kumara Parameshwaran,
Lijun Ou, Lior Margalit, Long Li, Long Wu, Mao YingMing,
Matan Azrad, Matan Azrad, mattias.ronnblom, Maxime Coquelin,
Min Hu (Connor),
Morten Brørup, Rao, Nikhil, Niklas Soderlund,
Nithin Dabilpuram, Matz, Olivier, Ori Kam, De Lara Guarch, Pablo,
Stillwell Jr, Paul M, Pavan Nikhilesh, Peng Zhang, Yang, Qiming,
Zhang, Qi Z, Nicolau, Radu, Raja Zidane, Remy Horton,
Rolf Neugebauer, Shahaf Shuler, Shally Verma, Shijith Thotton,
Shiqi Liu, Su, Simei, Somnath Kotur, Suanming Mou, Sunila Sahu,
Taripin, Samuel, Umesh Kartha, Usman Tanveer,
Viacheslav Ovsiienko, Medvedkin, Vladimir, Wei Hu (Xavier),
Ling, WeiX, Ma, WenwuX, Lu, Wenzhuo, Zhou, YidingX, Yisen Zhuang,
Yongseok Koh, Wang, YuanX
> 4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
My suggestion is do not backport this patch to 19.11.14 as we never validate the patch on 19.11, it will create unnecessary risk. And, we do not have necessary hardware (i225-IT) with us now for next few weeks to validate it.
-----Original Message-----
From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
Sent: Friday, 11 November, 2022 7:48 PM
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>; Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Kumara Parameshwaran <kumaraparamesh92@gmail.com>; Lijun Ou <oulijun@huawei.com>; Lior Margalit <lmargalit@nvidia.com>; Long Li <longli@microsoft.com>; Long Wu <long.wu@corigine.com>; Mah, Yock Gen <yock.gen.mah@intel.com>; Mao YingMing <maoyingming@baidu.com>; Matan Azrad <matan@mellanox.com>; Matan Azrad <matan@nvidia.com>; mattias.ronnblom <mattias.ronnblom@ericsson.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Min Hu (Connor) <humin29@huawei.com>; Morten Brørup <mb@smartsharesystems.com>; Rao, Nikhil <nikhil.rao@intel.com>; Niklas Soderlund <niklas.soderlund@corigine.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Matz, Olivier <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Peng Zhang <peng.zhang@corigine.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>; Raja Zidane <rzidane@nvidia.com>; Remy Horton <remy.horton@intel.com>; Rolf Neugebauer <rolf.neugebauer@netronome.com>; Shahaf Shuler <shahafs@mellanox.com>; Shally Verma <shally.verma@caviumnetworks.com>; Shijith Thotton <sthotton@marvell.com>; Shiqi Liu <835703180@qq.com>; Su, Simei <simei.su@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Suanming Mou <suanmingm@mellanox.com>; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Taripin, Samuel <samuel.taripin@intel.com>; Umesh Kartha <umesh.kartha@caviumnetworks.com>; Usman Tanveer <usman.tanveer@emumba.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>; Ling, WeiX <weix.ling@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhou, YidingX <yidingx.zhou@intel.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Yongseok Koh <yskoh@mellanox.com>; Wang, YuanX <yuanx.wang@intel.com>
Subject: please help backporting some patches to stable release 19.11.14
Hi commit authors (and maintainers),
Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I didn't apply following commits from DPDK main to 19.11 stable branch, as conflicts or build errors occur.
Can authors check your patches in the following list and either:
- Backport your patches to the 19.11 branch, or
- Indicate that the patch should not be backported
Please do either of the above by 11/18/22.
You can find the a temporary work-in-progress branch of the coming 19.11.14 release at:
https://github.com/cpaelzer/dpdk-stable-queue
It is recommended to backport on top of that to minimize further conflicts or misunderstandings.
Some notes on stable backports:
A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion:
[ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
For example:
https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example:
[PATCH 19.11] foo/bar: fix baz
With git format-patch, this can be achieved by appending the parameter:
--subject-prefix='PATCH 19.11'
Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
FYI, branch 19.11 is located at tree:
https://git.dpdk.org/dpdk-stable
Thanks.
Christian Ehrhardt <christian.ehrhardt@canonical.com>
P.S. I had to split the mail again to obey rules of mail providers
---
09b5b2880d Benjamin Le Berre net/bnxt: fix error code during MTU change
830f7e7907 Changpeng Liu vhost: add non-blocking API for posting interrupt
bc6eeb29c6 Chengwen Feng net/hns3: fix VF mailbox message handling
12590fc503 Chengwen Feng net/hns3: optimize SVE Tx performance
e0ec62d6e9 Chengwen Feng net/hns3: revert fix mailbox communication with HW
1a7374c956 Dmitry Kozlyuk eal: fix side effect in some pointer arithmetic macros
329280c53e Erik Gabriel Carrillo service: fix early move to inactive status
8f4ff7de39 Ganapati Kundapura eventdev/crypto: fix multi-process
c05a540902 Huisong Li net/hns3: delete unused markup
b38bd88beb Huisong Li net/hns3: fix clearing hardware MAC statistics
a35799625e Huisong Li net/hns3: fix lock protection of RSS flow rule
904ee370e8 Huisong Li net/hns3: fix packet type for GENEVE
1042ed401f Huisong Li net/hns3: fix restore filter function input
705a508003 Huisong Li net/hns3: fix RSS filter restore
43d8adf389 Huisong Li net/hns3: fix RSS flow rule restore
0d81da2559 Huisong Li net/hns3: fix RSS rule restore
860ed8516a Huisong Li net/hns3: move flow direction rule recovery
df810d1b6e Ivan Malov net/bonding: fix flow flush order on close
9f71a297da Jiawei Wang net/mlx5: fix modify action with tunnel decapsulation
bfa87e21bd Jiawei Wang net/mlx5: fix tunnel header with IPIP offload
b8a55871d5 Jun Qiu gro: trim tail padding bytes
aaa44cb125 Kalesh AP net/bnxt: remove unnecessary check
19ee91c6bd Kevin Liu net/iavf: check illegal packet sizes
72f51b097a Kumara Parameshwaran gro: check payload length after trim
bc5d8fdb70 Long Li net/mlx5: fix Verbs FD leak in secondary process
bb340f56fc Long Wu net/nfp: fix memory leak in Rx
4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
60b254e392 Matan Azrad net/mlx5: fix Rx queue recovery mechanism
70cb0278a4 Mattias Rönnblom event/dsw: fix flow migration
459531c958 Morten Brørup mempool: fix cache flushing algorithm
a2833ecc5e Morten Brørup mempool: fix get objects from mempool with cache
4edcee19fc Nithin Dabilpuram examples/ipsec-secgw: use Tx checksum offload conditionally
a0a17e2a3e Olivier Matz cryptodev: fix unduly newlines in logs
d5262b521d Olivier Matz mem: fix API doc about allocation on secondary processes
927cb43fe9 Pavan Nikhilesh examples/l3fwd: fix port group mask with AltiVec
dbad6f64f9 Peng Zhang net/nfp: fix internal buffer size and MTU check
b0472e210f Qi Zhang net/ice/base: fix input set of GTPoGRE
c05f2e9688 Radu Nicolau examples/ipsec-secgw: fix Tx checksum offload flag
130bb7da53 Raja Zidane net/mlx5: fix Tx check for hardware descriptor length
d914c01036 Shiqi Liu node: check Rx element allocation
f66323717e Usman Tanveer net/bonding: fix mode 4 with dedicated queues
d15bfd2930 Viacheslav Ovsiienko net/mlx5: fix inline length exceeding descriptor limit
40abb903fe Wenwu Ma examples/vhost: fix use after free
cb5c1b91f7 Yiding Zhou net/iavf: add thread for event callbacks
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: please help backporting some patches to stable release 19.11.14
2022-11-16 23:23 ` Mah, Yock Gen
@ 2022-11-17 8:49 ` Christian Ehrhardt
0 siblings, 0 replies; 9+ messages in thread
From: Christian Ehrhardt @ 2022-11-17 8:49 UTC (permalink / raw)
To: Mah, Yock Gen
Cc: dpdk stable, Konstantin Ananyev, Konstantin Ananyev,
Kumara Parameshwaran, Lijun Ou, Lior Margalit, Long Li, Long Wu,
Mao YingMing, Matan Azrad, Matan Azrad, mattias.ronnblom,
Maxime Coquelin, Min Hu (Connor),
Morten Brørup, Rao, Nikhil, Niklas Soderlund,
Nithin Dabilpuram, Matz, Olivier, Ori Kam, De Lara Guarch, Pablo,
Stillwell Jr, Paul M, Pavan Nikhilesh, Peng Zhang, Yang, Qiming,
Zhang, Qi Z, Nicolau, Radu, Raja Zidane, Remy Horton,
Rolf Neugebauer, Shahaf Shuler, Shally Verma, Shijith Thotton,
Shiqi Liu, Su, Simei, Somnath Kotur, Suanming Mou, Sunila Sahu,
Taripin, Samuel, Umesh Kartha, Usman Tanveer,
Viacheslav Ovsiienko, Medvedkin, Vladimir, Wei Hu (Xavier),
Ling, WeiX, Ma, WenwuX, Lu, Wenzhuo, Zhou, YidingX, Yisen Zhuang,
Yongseok Koh, Wang, YuanX
On Thu, Nov 17, 2022 at 9:37 AM Mah, Yock Gen <yock.gen.mah@intel.com> wrote:
>
> > 4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
> My suggestion is do not backport this patch to 19.11.14 as we never validate the patch on 19.11, it will create unnecessary risk. And, we do not have necessary hardware (i225-IT) with us now for next few weeks to validate it.
Ok, thanks for your feedback!
> -----Original Message-----
> From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> Sent: Friday, 11 November, 2022 7:48 PM
> Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>; Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Kumara Parameshwaran <kumaraparamesh92@gmail.com>; Lijun Ou <oulijun@huawei.com>; Lior Margalit <lmargalit@nvidia.com>; Long Li <longli@microsoft.com>; Long Wu <long.wu@corigine.com>; Mah, Yock Gen <yock.gen.mah@intel.com>; Mao YingMing <maoyingming@baidu.com>; Matan Azrad <matan@mellanox.com>; Matan Azrad <matan@nvidia.com>; mattias.ronnblom <mattias.ronnblom@ericsson.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Min Hu (Connor) <humin29@huawei.com>; Morten Brørup <mb@smartsharesystems.com>; Rao, Nikhil <nikhil.rao@intel.com>; Niklas Soderlund <niklas.soderlund@corigine.com>; Nithin Dabilpuram <ndabilpuram@marvell.com>; Matz, Olivier <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>; Peng Zhang <peng.zhang@corigine.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Nicolau, Radu <radu.nicolau@intel.com>; Raja Zidane <rzidane@nvidia.com>; Remy Horton <remy.horton@intel.com>; Rolf Neugebauer <rolf.neugebauer@netronome.com>; Shahaf Shuler <shahafs@mellanox.com>; Shally Verma <shally.verma@caviumnetworks.com>; Shijith Thotton <sthotton@marvell.com>; Shiqi Liu <835703180@qq.com>; Su, Simei <simei.su@intel.com>; Somnath Kotur <somnath.kotur@broadcom.com>; Suanming Mou <suanmingm@mellanox.com>; Sunila Sahu <sunila.sahu@caviumnetworks.com>; Taripin, Samuel <samuel.taripin@intel.com>; Umesh Kartha <umesh.kartha@caviumnetworks.com>; Usman Tanveer <usman.tanveer@emumba.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>; Ling, WeiX <weix.ling@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhou, YidingX <yidingx.zhou@intel.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Yongseok Koh <yskoh@mellanox.com>; Wang, YuanX <yuanx.wang@intel.com>
> Subject: please help backporting some patches to stable release 19.11.14
>
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I didn't apply following commits from DPDK main to 19.11 stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
> - Backport your patches to the 19.11 branch, or
> - Indicate that the patch should not be backported
>
> Please do either of the above by 11/18/22.
>
> You can find the a temporary work-in-progress branch of the coming 19.11.14 release at:
> https://github.com/cpaelzer/dpdk-stable-queue
> It is recommended to backport on top of that to minimize further conflicts or misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit in it's commit message in the following fashion:
> [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
> https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the subject line, as we have multiple branches, for example:
> [PATCH 19.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
> --subject-prefix='PATCH 19.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 19.11 is located at tree:
> https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> P.S. I had to split the mail again to obey rules of mail providers
>
> ---
> 09b5b2880d Benjamin Le Berre net/bnxt: fix error code during MTU change
> 830f7e7907 Changpeng Liu vhost: add non-blocking API for posting interrupt
> bc6eeb29c6 Chengwen Feng net/hns3: fix VF mailbox message handling
> 12590fc503 Chengwen Feng net/hns3: optimize SVE Tx performance
> e0ec62d6e9 Chengwen Feng net/hns3: revert fix mailbox communication with HW
> 1a7374c956 Dmitry Kozlyuk eal: fix side effect in some pointer arithmetic macros
> 329280c53e Erik Gabriel Carrillo service: fix early move to inactive status
> 8f4ff7de39 Ganapati Kundapura eventdev/crypto: fix multi-process
> c05a540902 Huisong Li net/hns3: delete unused markup
> b38bd88beb Huisong Li net/hns3: fix clearing hardware MAC statistics
> a35799625e Huisong Li net/hns3: fix lock protection of RSS flow rule
> 904ee370e8 Huisong Li net/hns3: fix packet type for GENEVE
> 1042ed401f Huisong Li net/hns3: fix restore filter function input
> 705a508003 Huisong Li net/hns3: fix RSS filter restore
> 43d8adf389 Huisong Li net/hns3: fix RSS flow rule restore
> 0d81da2559 Huisong Li net/hns3: fix RSS rule restore
> 860ed8516a Huisong Li net/hns3: move flow direction rule recovery
> df810d1b6e Ivan Malov net/bonding: fix flow flush order on close
> 9f71a297da Jiawei Wang net/mlx5: fix modify action with tunnel decapsulation
> bfa87e21bd Jiawei Wang net/mlx5: fix tunnel header with IPIP offload
> b8a55871d5 Jun Qiu gro: trim tail padding bytes
> aaa44cb125 Kalesh AP net/bnxt: remove unnecessary check
> 19ee91c6bd Kevin Liu net/iavf: check illegal packet sizes
> 72f51b097a Kumara Parameshwaran gro: check payload length after trim
> bc5d8fdb70 Long Li net/mlx5: fix Verbs FD leak in secondary process
> bb340f56fc Long Wu net/nfp: fix memory leak in Rx
> 4841015ffb Mah Yock Gen net/igc: remove unnecessary PHY ID checks
> 4bfb499829 Mao YingMing net/bnxt: fix null pointer dereference in LED config
> 60b254e392 Matan Azrad net/mlx5: fix Rx queue recovery mechanism
> 70cb0278a4 Mattias Rönnblom event/dsw: fix flow migration
> 459531c958 Morten Brørup mempool: fix cache flushing algorithm
> a2833ecc5e Morten Brørup mempool: fix get objects from mempool with cache
> 4edcee19fc Nithin Dabilpuram examples/ipsec-secgw: use Tx checksum offload conditionally
> a0a17e2a3e Olivier Matz cryptodev: fix unduly newlines in logs
> d5262b521d Olivier Matz mem: fix API doc about allocation on secondary processes
> 927cb43fe9 Pavan Nikhilesh examples/l3fwd: fix port group mask with AltiVec
> dbad6f64f9 Peng Zhang net/nfp: fix internal buffer size and MTU check
> b0472e210f Qi Zhang net/ice/base: fix input set of GTPoGRE
> c05f2e9688 Radu Nicolau examples/ipsec-secgw: fix Tx checksum offload flag
> 130bb7da53 Raja Zidane net/mlx5: fix Tx check for hardware descriptor length
> d914c01036 Shiqi Liu node: check Rx element allocation
> f66323717e Usman Tanveer net/bonding: fix mode 4 with dedicated queues
> d15bfd2930 Viacheslav Ovsiienko net/mlx5: fix inline length exceeding descriptor limit
> 40abb903fe Wenwu Ma examples/vhost: fix use after free
> cb5c1b91f7 Yiding Zhou net/iavf: add thread for event callbacks
--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: please help backporting some patches to stable release 19.11.14
[not found] <20221111114814.1553136-1-christian.ehrhardt@canonical.com>
` (2 preceding siblings ...)
2022-11-16 23:23 ` Mah, Yock Gen
@ 2022-11-17 14:33 ` Niklas Soderlund
3 siblings, 0 replies; 9+ messages in thread
From: Niklas Soderlund @ 2022-11-17 14:33 UTC (permalink / raw)
To: Christian Ehrhardt, dpdk stable
Hi Christian,
Thanks for your packporting efforts.
On 2022-11-11 12:48:14 +0100, christian.ehrhardt@canonical.com wrote:
> bb340f56fc Long Wu net/nfp: fix memory leak in Rx
http://mails.dpdk.org/archives/stable/2022-November/041301.html
> dbad6f64f9 Peng Zhang net/nfp: fix internal buffer size and MTU check
http://mails.dpdk.org/archives/stable/2022-November/041300.html
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 9+ messages in thread