From: Yongseok Koh <yskoh@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] patch 'kni: fix build on Linux 4.19' has been queued to LTS release 17.11.5
Date: Fri, 4 Jan 2019 20:33:01 +0000 [thread overview]
Message-ID: <7BC9510C-41EA-41D2-BD91-D1725F758329@mellanox.com> (raw)
In-Reply-To: <737FCC0E-59FF-4419-BB19-829EA92FA7B9@mellanox.com>
It is re-applied to stable/17.11 per author's request.
Thanks,
Yongseok
> On Dec 19, 2018, at 4:19 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
> Hi,
>
> This patch is being removed from stable/17.11 as it was mistakenly merged.
> Patches having 'fix' keyword in the title were merged even though those don't
> have "Cc: stable@dpdk.org" tag in the commit message.
>
> If you think this patch is still needed for stable/17.11, please let me know.
> Then I'll take it back.
>
>
> Thanks,
> Yongseok
>
>
>> On Nov 29, 2018, at 3:11 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
>>
>> Hi,
>>
>> FYI, your patch has been queued to LTS release 17.11.5
>>
>> Note it hasn't been pushed to https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=02%7C01%7Cyskoh%40mellanox.com%7Cf8136684c7644017005908d66610c045%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636808619472748243&sdata=kj1dA7LDiDb72yIzo4ad4Wg2NsP%2BnbDhk1xKIeiI4Vc%3D&reserved=0 yet.
>> It will be pushed if I get no objections before 12/01/18. So please
>> shout if anyone has objections.
>>
>> Also note that after the patch there's a diff of the upstream commit vs the patch applied
>> to the branch. If the code is different (ie: not only metadata diffs), due for example to
>> a change in context or macro names, please double check it.
>>
>> Thanks.
>>
>> Yongseok
>>
>> ---
>> From e013021836efb2d1a228b525d5aee8c7e41e8bb9 Mon Sep 17 00:00:00 2001
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Date: Wed, 24 Oct 2018 12:10:10 +0100
>> Subject: [PATCH] kni: fix build on Linux 4.19
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> [ upstream commit a9460a0b2efb80a913d8770dc188e816b227622f ]
>>
>> The build error observed with Linux kernel 4.19 when KNI ethtool
>> support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y)
>>
>> .../build/build/kernel/linux/kni/kni_ethtool.c:193:3:
>> error: ‘struct ethtool_ops’ has no member named ‘get_settings’;
>> .get_settings = kni_get_settings,
>> ^~~~~~~~~~~~
>>
>> .../build/build/kernel/linux/kni/kni_ethtool.c:194:3:
>> error: ‘struct ethtool_ops’ has no member named ‘set_settings’;
>> .set_settings = kni_set_settings,
>> ^~~~~~~~~~~~
>>
>> With kernel 4.19 ethtool_ops `get_settings` & `set_settings` are
>> replaced with `get_link_ksettings` & `set_link_ksettings`
>> Commit 9b3004953503 ("ethtool: drop get_settings and set_settings callbacks")
>>
>> This fix practically removes `get_settings` & `set_settings` support
>> for the kernel versions that have the new ethtool_ops without
>> implementing the new ones.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 8 ++++++++
>> lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h | 2 ++
>> lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c | 8 ++++++++
>> lib/librte_eal/linuxapp/kni/kni_ethtool.c | 10 ++++++++++
>> 4 files changed, 28 insertions(+)
>>
>> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c
>> index aed14bcc8..7a520ecec 100644
>> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c
>> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c
>> @@ -150,6 +150,7 @@ static const char igb_gstrings_test[][ETH_GSTRING_LEN] = {
>> #define IGB_TEST_LEN (sizeof(igb_gstrings_test) / ETH_GSTRING_LEN)
>> #endif /* ETHTOOL_TEST */
>>
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> {
>> struct igb_adapter *adapter = netdev_priv(netdev);
>> @@ -274,7 +275,9 @@ static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> #endif /* ETH_TP_MDI_X */
>> return 0;
>> }
>> +#endif
>>
>> +#ifndef ETHTOOL_SLINKSETTINGS
>> static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> {
>> struct igb_adapter *adapter = netdev_priv(netdev);
>> @@ -379,6 +382,7 @@ static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> clear_bit(__IGB_RESETTING, &adapter->state);
>> return 0;
>> }
>> +#endif
>>
>> static u32 igb_get_link(struct net_device *netdev)
>> {
>> @@ -2752,8 +2756,12 @@ static int igb_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
>> #endif /* ETHTOOL_GRXRINGS */
>>
>> static const struct ethtool_ops igb_ethtool_ops = {
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> .get_settings = igb_get_settings,
>> +#endif
>> +#ifndef ETHTOOL_SLINKSETTINGS
>> .set_settings = igb_set_settings,
>> +#endif
>> .get_drvinfo = igb_get_drvinfo,
>> .get_regs_len = igb_get_regs_len,
>> .get_regs = igb_get_regs,
>> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h
>> index 59415469c..cc3f8ea41 100644
>> --- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h
>> +++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h
>> @@ -905,8 +905,10 @@ s32 ixgbe_dcb_hw_ets(struct ixgbe_hw *hw, struct ieee_ets *ets, int max_frame);
>> #endif /* CONFIG_DCB */
>>
>> extern void ixgbe_clean_rx_ring(struct ixgbe_ring *rx_ring);
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> extern int ixgbe_get_settings(struct net_device *netdev,
>> struct ethtool_cmd *ecmd);
>> +#endif
>> extern int ixgbe_write_uc_addr_list(struct ixgbe_adapter *adapter,
>> struct net_device *netdev, unsigned int vfn);
>> extern void ixgbe_full_sync_mac_table(struct ixgbe_adapter *adapter);
>> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> index cdfcb9596..1296829bc 100644
>> --- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> +++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> @@ -173,6 +173,7 @@ static const char ixgbe_gstrings_test[][ETH_GSTRING_LEN] = {
>> #define IXGBE_TEST_LEN (sizeof(ixgbe_gstrings_test) / ETH_GSTRING_LEN)
>> #endif /* ETHTOOL_TEST */
>>
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> int ixgbe_get_settings(struct net_device *netdev,
>> struct ethtool_cmd *ecmd)
>> {
>> @@ -362,7 +363,9 @@ int ixgbe_get_settings(struct net_device *netdev,
>>
>> return 0;
>> }
>> +#endif
>>
>> +#ifndef ETHTOOL_SLINKSETTINGS
>> static int ixgbe_set_settings(struct net_device *netdev,
>> struct ethtool_cmd *ecmd)
>> {
>> @@ -406,6 +409,7 @@ static int ixgbe_set_settings(struct net_device *netdev,
>> }
>> return err;
>> }
>> +#endif
>>
>> static void ixgbe_get_pauseparam(struct net_device *netdev,
>> struct ethtool_pauseparam *pause)
>> @@ -2830,8 +2834,12 @@ static int ixgbe_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
>> #endif /* ETHTOOL_GRXRINGS */
>> //static
>> struct ethtool_ops ixgbe_ethtool_ops = {
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> .get_settings = ixgbe_get_settings,
>> +#endif
>> +#ifndef ETHTOOL_SLINKSETTINGS
>> .set_settings = ixgbe_set_settings,
>> +#endif
>> .get_drvinfo = ixgbe_get_drvinfo,
>> .get_regs_len = ixgbe_get_regs_len,
>> .get_regs = ixgbe_get_regs,
>> diff --git a/lib/librte_eal/linuxapp/kni/kni_ethtool.c b/lib/librte_eal/linuxapp/kni/kni_ethtool.c
>> index 0c88589c9..8174e98db 100644
>> --- a/lib/librte_eal/linuxapp/kni/kni_ethtool.c
>> +++ b/lib/librte_eal/linuxapp/kni/kni_ethtool.c
>> @@ -46,6 +46,8 @@ kni_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
>> priv->lad_dev->ethtool_ops->get_drvinfo(priv->lad_dev, info);
>> }
>>
>> +/* ETHTOOL_GLINKSETTINGS replaces ETHTOOL_GSET */
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> static int
>> kni_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>> {
>> @@ -53,7 +55,10 @@ kni_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>>
>> return priv->lad_dev->ethtool_ops->get_settings(priv->lad_dev, ecmd);
>> }
>> +#endif
>>
>> +/* ETHTOOL_SLINKSETTINGS replaces ETHTOOL_SSET */
>> +#ifndef ETHTOOL_SLINKSETTINGS
>> static int
>> kni_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>> {
>> @@ -61,6 +66,7 @@ kni_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>>
>> return priv->lad_dev->ethtool_ops->set_settings(priv->lad_dev, ecmd);
>> }
>> +#endif
>>
>> static void
>> kni_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
>> @@ -209,8 +215,12 @@ kni_get_ethtool_stats(struct net_device *dev, struct ethtool_stats *stats,
>> struct ethtool_ops kni_ethtool_ops = {
>> .begin = kni_check_if_running,
>> .get_drvinfo = kni_get_drvinfo,
>> +#ifndef ETHTOOL_GLINKSETTINGS
>> .get_settings = kni_get_settings,
>> +#endif
>> +#ifndef ETHTOOL_SLINKSETTINGS
>> .set_settings = kni_set_settings,
>> +#endif
>> .get_regs_len = kni_get_regs_len,
>> .get_regs = kni_get_regs,
>> .get_wol = kni_get_wol,
>> --
>> 2.11.0
>>
>> ---
>> Diff of the applied patch vs upstream commit (please double-check if non-empty:
>> ---
>> --- - 2018-11-29 15:01:48.389325238 -0800
>> +++ 0072-kni-fix-build-on-Linux-4.19.patch 2018-11-29 15:01:45.186964000 -0800
>> @@ -1,4 +1,4 @@
>> -From a9460a0b2efb80a913d8770dc188e816b227622f Mon Sep 17 00:00:00 2001
>> +From e013021836efb2d1a228b525d5aee8c7e41e8bb9 Mon Sep 17 00:00:00 2001
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Date: Wed, 24 Oct 2018 12:10:10 +0100
>> Subject: [PATCH] kni: fix build on Linux 4.19
>> @@ -6,6 +6,8 @@
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> +[ upstream commit a9460a0b2efb80a913d8770dc188e816b227622f ]
>> +
>> The build error observed with Linux kernel 4.19 when KNI ethtool
>> support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=y)
>>
>> @@ -29,17 +31,17 @@
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> - kernel/linux/kni/ethtool/igb/igb_ethtool.c | 8 ++++++++
>> - kernel/linux/kni/ethtool/ixgbe/ixgbe.h | 2 ++
>> - kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.c | 8 ++++++++
>> - kernel/linux/kni/kni_ethtool.c | 10 ++++++++++
>> + lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 8 ++++++++
>> + lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h | 2 ++
>> + lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c | 8 ++++++++
>> + lib/librte_eal/linuxapp/kni/kni_ethtool.c | 10 ++++++++++
>> 4 files changed, 28 insertions(+)
>>
>> -diff --git a/kernel/linux/kni/ethtool/igb/igb_ethtool.c b/kernel/linux/kni/ethtool/igb/igb_ethtool.c
>> -index 002f75c48..b6bddc025 100644
>> ---- a/kernel/linux/kni/ethtool/igb/igb_ethtool.c
>> -+++ b/kernel/linux/kni/ethtool/igb/igb_ethtool.c
>> -@@ -135,6 +135,7 @@ static const char igb_gstrings_test[][ETH_GSTRING_LEN] = {
>> +diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c
>> +index aed14bcc8..7a520ecec 100644
>> +--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c
>> ++++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c
>> +@@ -150,6 +150,7 @@ static const char igb_gstrings_test[][ETH_GSTRING_LEN] = {
>> #define IGB_TEST_LEN (sizeof(igb_gstrings_test) / ETH_GSTRING_LEN)
>> #endif /* ETHTOOL_TEST */
>>
>> @@ -47,7 +49,7 @@
>> static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> {
>> struct igb_adapter *adapter = netdev_priv(netdev);
>> -@@ -259,7 +260,9 @@ static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> +@@ -274,7 +275,9 @@ static int igb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> #endif /* ETH_TP_MDI_X */
>> return 0;
>> }
>> @@ -57,7 +59,7 @@
>> static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> {
>> struct igb_adapter *adapter = netdev_priv(netdev);
>> -@@ -364,6 +367,7 @@ static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> +@@ -379,6 +382,7 @@ static int igb_set_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
>> clear_bit(__IGB_RESETTING, &adapter->state);
>> return 0;
>> }
>> @@ -65,7 +67,7 @@
>>
>> static u32 igb_get_link(struct net_device *netdev)
>> {
>> -@@ -2737,8 +2741,12 @@ static int igb_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
>> +@@ -2752,8 +2756,12 @@ static int igb_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
>> #endif /* ETHTOOL_GRXRINGS */
>>
>> static const struct ethtool_ops igb_ethtool_ops = {
>> @@ -78,11 +80,11 @@
>> .get_drvinfo = igb_get_drvinfo,
>> .get_regs_len = igb_get_regs_len,
>> .get_regs = igb_get_regs,
>> -diff --git a/kernel/linux/kni/ethtool/ixgbe/ixgbe.h b/kernel/linux/kni/ethtool/ixgbe/ixgbe.h
>> -index 6ff941334..cc15ec6ab 100644
>> ---- a/kernel/linux/kni/ethtool/ixgbe/ixgbe.h
>> -+++ b/kernel/linux/kni/ethtool/ixgbe/ixgbe.h
>> -@@ -890,8 +890,10 @@ s32 ixgbe_dcb_hw_ets(struct ixgbe_hw *hw, struct ieee_ets *ets, int max_frame);
>> +diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h
>> +index 59415469c..cc3f8ea41 100644
>> +--- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h
>> ++++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe.h
>> +@@ -905,8 +905,10 @@ s32 ixgbe_dcb_hw_ets(struct ixgbe_hw *hw, struct ieee_ets *ets, int max_frame);
>> #endif /* CONFIG_DCB */
>>
>> extern void ixgbe_clean_rx_ring(struct ixgbe_ring *rx_ring);
>> @@ -93,11 +95,11 @@
>> extern int ixgbe_write_uc_addr_list(struct ixgbe_adapter *adapter,
>> struct net_device *netdev, unsigned int vfn);
>> extern void ixgbe_full_sync_mac_table(struct ixgbe_adapter *adapter);
>> -diff --git a/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.c b/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> -index 44cdc9f20..f2ded19e9 100644
>> ---- a/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> -+++ b/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> -@@ -158,6 +158,7 @@ static const char ixgbe_gstrings_test[][ETH_GSTRING_LEN] = {
>> +diff --git a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> +index cdfcb9596..1296829bc 100644
>> +--- a/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> ++++ b/lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_ethtool.c
>> +@@ -173,6 +173,7 @@ static const char ixgbe_gstrings_test[][ETH_GSTRING_LEN] = {
>> #define IXGBE_TEST_LEN (sizeof(ixgbe_gstrings_test) / ETH_GSTRING_LEN)
>> #endif /* ETHTOOL_TEST */
>>
>> @@ -105,7 +107,7 @@
>> int ixgbe_get_settings(struct net_device *netdev,
>> struct ethtool_cmd *ecmd)
>> {
>> -@@ -347,7 +348,9 @@ int ixgbe_get_settings(struct net_device *netdev,
>> +@@ -362,7 +363,9 @@ int ixgbe_get_settings(struct net_device *netdev,
>>
>> return 0;
>> }
>> @@ -115,7 +117,7 @@
>> static int ixgbe_set_settings(struct net_device *netdev,
>> struct ethtool_cmd *ecmd)
>> {
>> -@@ -391,6 +394,7 @@ static int ixgbe_set_settings(struct net_device *netdev,
>> +@@ -406,6 +409,7 @@ static int ixgbe_set_settings(struct net_device *netdev,
>> }
>> return err;
>> }
>> @@ -123,7 +125,7 @@
>>
>> static void ixgbe_get_pauseparam(struct net_device *netdev,
>> struct ethtool_pauseparam *pause)
>> -@@ -2815,8 +2819,12 @@ static int ixgbe_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
>> +@@ -2830,8 +2834,12 @@ static int ixgbe_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)
>> #endif /* ETHTOOL_GRXRINGS */
>> //static
>> struct ethtool_ops ixgbe_ethtool_ops = {
>> @@ -136,11 +138,11 @@
>> .get_drvinfo = ixgbe_get_drvinfo,
>> .get_regs_len = ixgbe_get_regs_len,
>> .get_regs = ixgbe_get_regs,
>> -diff --git a/kernel/linux/kni/kni_ethtool.c b/kernel/linux/kni/kni_ethtool.c
>> -index a44e7d949..b1c84f8f0 100644
>> ---- a/kernel/linux/kni/kni_ethtool.c
>> -+++ b/kernel/linux/kni/kni_ethtool.c
>> -@@ -27,6 +27,8 @@ kni_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
>> +diff --git a/lib/librte_eal/linuxapp/kni/kni_ethtool.c b/lib/librte_eal/linuxapp/kni/kni_ethtool.c
>> +index 0c88589c9..8174e98db 100644
>> +--- a/lib/librte_eal/linuxapp/kni/kni_ethtool.c
>> ++++ b/lib/librte_eal/linuxapp/kni/kni_ethtool.c
>> +@@ -46,6 +46,8 @@ kni_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
>> priv->lad_dev->ethtool_ops->get_drvinfo(priv->lad_dev, info);
>> }
>>
>> @@ -149,7 +151,7 @@
>> static int
>> kni_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>> {
>> -@@ -34,7 +36,10 @@ kni_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>> +@@ -53,7 +55,10 @@ kni_get_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>>
>> return priv->lad_dev->ethtool_ops->get_settings(priv->lad_dev, ecmd);
>> }
>> @@ -160,7 +162,7 @@
>> static int
>> kni_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>> {
>> -@@ -42,6 +47,7 @@ kni_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>> +@@ -61,6 +66,7 @@ kni_set_settings(struct net_device *dev, struct ethtool_cmd *ecmd)
>>
>> return priv->lad_dev->ethtool_ops->set_settings(priv->lad_dev, ecmd);
>> }
>> @@ -168,7 +170,7 @@
>>
>> static void
>> kni_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
>> -@@ -190,8 +196,12 @@ kni_get_ethtool_stats(struct net_device *dev, struct ethtool_stats *stats,
>> +@@ -209,8 +215,12 @@ kni_get_ethtool_stats(struct net_device *dev, struct ethtool_stats *stats,
>> struct ethtool_ops kni_ethtool_ops = {
>> .begin = kni_check_if_running,
>> .get_drvinfo = kni_get_drvinfo,
>
next prev parent reply other threads:[~2019-01-04 20:33 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:09 [dpdk-stable] patch 'net/mlx5: add Bluefield device id' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'eal/arm64: fix instrinsic for GCC < 4.9' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'mem: fix memory initialization time' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'build: enable ARM NEON flag when __aarch64__ defined' " Yongseok Koh
2018-11-29 23:09 ` [dpdk-stable] patch 'acl: forbid rule with priority zero' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: support matching QinQ ethertype' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: fix wrong usage of bind command' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'examples/vhost: remove unnecessary constant' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: use evenly distributed default RSS RETA' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: do not ignore RSS key on device config' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: optimize mbuf pool allocation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/nfp: fix mbuf flags with checksum good' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net: fix Intel prepare function for IP checksum offload' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix SAL annotation for input buffers' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: properly align on line continuation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix build because of no declaration' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: check size of memory to read sensors data to' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: avoid usage of too big arrays on stack' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: prevent access to the NIC config before probe' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix a typo in unicast filter insertion comment' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: fix MAC Tx stats for less or equal to 64 bytes' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc: fix an Rx queue double release possibility' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc: fix a Tx " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: fix Rx slave fairness' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/failsafe: remove not supported multicast MAC filter' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc/base: make last byte of module information available' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'ethdev: fix doxygen comment to be with structure' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bonding: stop and deactivate slaves on stop' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/test-crypto-perf: fix check for auth key' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/test-crypto-perf: fix check for cipher IV' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/test-crypto-perf: fix double allocation of memory' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'crypto/aesni_mb: fix possible array overrun' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'test/crypto: fix number of queue pairs' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'event/sw: fix cq index check for unlink usecases' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'test/event: check burst mode capability' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'mem: fix undefined behavior in NUMA-aware mapping' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'igb_uio: fix refcount if open returns error' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e: fix send admin queue command before init' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e/base: properly clean resources' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e/base: gracefully clean the " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/i40e/base: correct global reset timeout calculation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/ixgbe: wait longer for link after fiber MAC setup' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/enic: do not use non-standard integer types' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/enic: set Rx VLAN offload flag for non-stripped packets' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/nfp: fix RSS' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnx2x: fix to disable further interrupts' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnx2x: fix call to link handling periodic function' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/enic: fix flow API memory leak' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: fix uninitialized pointer access in Tx' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: fix registration of VF async event completion ring' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: set MAC filtering as outer for non tunnel frames' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/bnxt: set VLAN strip mode before default VNIC cfg' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: fix csum parse-tunnel command invocation' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/sfc: receive prepared packets even in Rx exception case' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'mbuf: fix Tx offload mask' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: clarify L3 Tx checksum prerequisite' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: clarify L4 " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/failsafe: use prefix for function' " Yongseok Koh
2018-12-20 0:17 ` Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'doc: add VFIO in ENA guide' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: fix printf format in event callback' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'app/testpmd: fix duplicate exit' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'net/e1000: do not error out if Rx drop enable is set' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'eal: use correct data type for bitmap slab operations' " Yongseok Koh
2018-11-29 23:10 ` [dpdk-stable] patch 'crypto/mvsam: update hash digest sizes' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: fix vdev socket initialization' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: fix physical port " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kvargs: fix processing a null list' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'igb_uio: fix unexpected removal for hot-unplug' " Yongseok Koh
2018-12-20 0:18 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'latency: fix timestamp marking and latency calculation' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test/hash: fix bucket size in perf test' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix build on Linux 4.19' " Yongseok Koh
2018-12-20 0:19 ` Yongseok Koh
2019-01-04 20:33 ` Yongseok Koh [this message]
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix kernel FIFO synchronization' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix build on Linux < 3.14' " Yongseok Koh
2018-12-20 0:19 ` Yongseok Koh
2018-12-20 8:30 ` Thomas Monjalon
2018-12-28 9:25 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: reserve NUMA node per port and per ring' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: keep promiscuous on if allmulticast is enabled' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: enable loopback function for X722 MAC' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: update Tx offload mask' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ixgbe: " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ena: fix passing RSS hash to mbuf' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix typo in testpmd guide' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'ip_frag: fix overflow in key comparison' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: support strlcpy function' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal/linux: fix memory leak of logid' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/virtio: fix PCI config error handling' " Yongseok Koh
2018-11-30 15:23 ` Tiwei Bie
2018-11-30 18:02 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'bus/pci: compare kernel driver instead of interrupt handler' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal/linux: handle UIO read failure in " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'mk: disable gcc AVX512F support' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'crypto/scheduler: fix build with gcc 8.2' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: fix build with gcc 9.0' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: fix offload not supported mask' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net: fix build with pedantic' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: clarify TSO Tx offload prerequisite' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/igb: update Tx offload mask' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'ip_frag: use key length for key comparison' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'bus/pci: fix config r/w access' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test/hash: fix build' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: introduce rte version of fls' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: fix build' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'pci: fix parsing of address without function number' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/tap: fix file descriptor check' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/e1000/base: fix uninitialized variable' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/mlx5: fix build on PPC64' " Yongseok Koh
2018-12-20 0:20 ` Yongseok Koh
2018-12-20 8:34 ` Thomas Monjalon
2018-11-29 23:11 ` [dpdk-stable] patch 'net/thunderx: fix Tx desc corruption in scatter-gather mode' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/virtio-user: fix typo in error message' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/virtio: fix unchecked return value' " Yongseok Koh
2018-11-30 15:23 ` Tiwei Bie
2018-11-30 18:01 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'vhost: remove unneeded null pointer check' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/bonding: fix crash when stopping mode 4 port' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/qede: fix crash when configure fails' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'app/testpmd: fix L4 length for UDP checksum' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ixgbevf: fix link state' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test/reorder: fix out of bound access' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'efd: fix write unlock during ring creation' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e: fix X710 Rx after reading some registers' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/ixgbe: fix maximum wait time in comment' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'examples/ipv4_multicast: fix leak of cloned packets' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'test: release ring resources after PMD perf test' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'usertools: check for lspci dependency' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix NUMA library name in Linux guide' " Yongseok Koh
2018-12-20 0:21 ` Yongseok Koh
2019-01-08 16:48 ` Burakov, Anatoly
2019-01-08 18:51 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix formatting in IP reassembly app " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'doc: fix function name in flow filtering " Yongseok Koh
2018-12-20 0:21 ` Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'eal: fix build with -O1' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'kni: fix possible uninitialized variable' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/i40e/base: fix comment referencing internal data' " Yongseok Koh
2018-11-29 23:11 ` [dpdk-stable] patch 'net/qede: fix Tx offload mask' " Yongseok Koh
2018-11-29 23:12 ` [dpdk-stable] patch 'bus/pci: fix allocation of device path' " Yongseok Koh
2018-11-29 23:12 ` [dpdk-stable] patch 'vfio: do not needlessly setup device in secondary process' " Yongseok Koh
2018-12-20 0:22 ` Yongseok Koh
2019-01-08 16:47 ` Burakov, Anatoly
2019-01-08 18:50 ` Yongseok Koh
2019-01-09 8:53 ` Burakov, Anatoly
2018-11-29 23:12 ` [dpdk-stable] patch 'eal: fix devargs reference after probing failure' " Yongseok Koh
2018-12-20 0:22 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7BC9510C-41EA-41D2-BD91-D1725F758329@mellanox.com \
--to=yskoh@mellanox.com \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).