* [PATCH v2 1/1] baseband/acc: fix ring memory allocation logic
[not found] <20241108003238.1921588-1-nicolas.chautru@intel.com>
@ 2024-11-08 0:32 ` Nicolas Chautru
2024-11-08 9:00 ` Maxime Coquelin
2024-11-08 10:32 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Chautru @ 2024-11-08 0:32 UTC (permalink / raw)
To: dev, maxime.coquelin
Cc: hemant.agrawal, hernan.vargas, Nicolas Chautru, stable
Allowing ring memory allocation whose end address is aligned with 64 MB.
Previous logic was off by one.
Fixes: 060e76729302 ("baseband/acc100: add queue configuration")
Cc: stable@dpdk.org
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/acc/acc_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
index 4c60b7896b..bf218332be 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -795,7 +795,7 @@ alloc_sw_rings_min_mem(struct rte_bbdev *dev, struct acc_device *d,
sw_rings_base, ACC_SIZE_64MBYTE);
next_64mb_align_addr_iova = sw_rings_base_iova +
next_64mb_align_offset;
- sw_ring_iova_end_addr = sw_rings_base_iova + dev_sw_ring_size;
+ sw_ring_iova_end_addr = sw_rings_base_iova + dev_sw_ring_size - 1;
/* Check if the end of the sw ring memory block is before the
* start of next 64MB aligned mem address
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] baseband/acc: fix ring memory allocation logic
2024-11-08 0:32 ` [PATCH v2 1/1] baseband/acc: fix ring memory allocation logic Nicolas Chautru
@ 2024-11-08 9:00 ` Maxime Coquelin
2024-11-08 10:32 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2024-11-08 9:00 UTC (permalink / raw)
To: Nicolas Chautru, dev; +Cc: hemant.agrawal, hernan.vargas, stable
On 11/8/24 01:32, Nicolas Chautru wrote:
> Allowing ring memory allocation whose end address is aligned with 64 MB.
> Previous logic was off by one.
>
> Fixes: 060e76729302 ("baseband/acc100: add queue configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/acc_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
> index 4c60b7896b..bf218332be 100644
> --- a/drivers/baseband/acc/acc_common.h
> +++ b/drivers/baseband/acc/acc_common.h
> @@ -795,7 +795,7 @@ alloc_sw_rings_min_mem(struct rte_bbdev *dev, struct acc_device *d,
> sw_rings_base, ACC_SIZE_64MBYTE);
> next_64mb_align_addr_iova = sw_rings_base_iova +
> next_64mb_align_offset;
> - sw_ring_iova_end_addr = sw_rings_base_iova + dev_sw_ring_size;
> + sw_ring_iova_end_addr = sw_rings_base_iova + dev_sw_ring_size - 1;
>
> /* Check if the end of the sw ring memory block is before the
> * start of next 64MB aligned mem address
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] baseband/acc: fix ring memory allocation logic
2024-11-08 0:32 ` [PATCH v2 1/1] baseband/acc: fix ring memory allocation logic Nicolas Chautru
2024-11-08 9:00 ` Maxime Coquelin
@ 2024-11-08 10:32 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2024-11-08 10:32 UTC (permalink / raw)
To: Nicolas Chautru, dev; +Cc: hemant.agrawal, hernan.vargas, stable
On 11/8/24 01:32, Nicolas Chautru wrote:
> Allowing ring memory allocation whose end address is aligned with 64 MB.
> Previous logic was off by one.
>
> Fixes: 060e76729302 ("baseband/acc100: add queue configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/acc_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to next-baseband/for-main
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-08 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20241108003238.1921588-1-nicolas.chautru@intel.com>
2024-11-08 0:32 ` [PATCH v2 1/1] baseband/acc: fix ring memory allocation logic Nicolas Chautru
2024-11-08 9:00 ` Maxime Coquelin
2024-11-08 10:32 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).