patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix dereference before null check
@ 2020-08-24 11:46 wangyunjian
  2020-08-24 12:41 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2020-08-24 11:46 UTC (permalink / raw)
  To: dev, rmody, shshaikh; +Cc: jerry.lilijun, xudingke, Yunjian Wang, stable

From: Yunjian Wang <wangyunjian@huawei.com>

Coverity flags that 'fp->sb_info' variable is used before
it's checked for NULL. This patch fixes this issue.

Coverity issue: 260413
Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/net/qede/qede_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index ea264f59d..75d78cebb 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -676,9 +676,9 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)
 
 	for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) {
 		fp = &qdev->fp_array[sb_idx];
-		DP_INFO(edev, "Free sb_info index 0x%x\n",
-				fp->sb_info->igu_sb_id);
 		if (fp->sb_info) {
+			DP_INFO(edev, "Free sb_info index 0x%x\n",
+					fp->sb_info->igu_sb_id);
 			OSAL_DMA_FREE_COHERENT(edev, fp->sb_info->sb_virt,
 				fp->sb_info->sb_phys,
 				sizeof(struct status_block));
-- 
2.23.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix dereference before null check
  2020-08-24 11:46 [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix dereference before null check wangyunjian
@ 2020-08-24 12:41 ` Ferruh Yigit
  2020-09-29 18:08   ` Jerin Jacob
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2020-08-24 12:41 UTC (permalink / raw)
  To: wangyunjian, dev, rmody, shshaikh; +Cc: jerry.lilijun, xudingke, stable

On 8/24/2020 12:46 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> Coverity flags that 'fp->sb_info' variable is used before
> it's checked for NULL. This patch fixes this issue.
> 
> Coverity issue: 260413
> Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix dereference before null check
  2020-08-24 12:41 ` Ferruh Yigit
@ 2020-09-29 18:08   ` Jerin Jacob
  0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2020-09-29 18:08 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: wangyunjian, dpdk-dev, Rasesh Mody, Shahed Shaikh,
	Lilijun (Jerry),
	xudingke, dpdk stable

On Mon, Aug 24, 2020 at 6:11 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 8/24/2020 12:46 PM, wangyunjian wrote:
> > From: Yunjian Wang <wangyunjian@huawei.com>
> >
> > Coverity flags that 'fp->sb_info' variable is used before
> > it's checked for NULL. This patch fixes this issue.
> >
> > Coverity issue: 260413
> > Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net-mrvl/main. Thanks



>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-29 18:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 11:46 [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix dereference before null check wangyunjian
2020-08-24 12:41 ` Ferruh Yigit
2020-09-29 18:08   ` Jerin Jacob

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git