patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <>
To: "Wei Hu (Xavier)" <>,
Subject: Re: [dpdk-stable] [PATCH v3] ethdev: fix VLAN offloads set if no driver callback
Date: Fri, 17 Jan 2020 14:31:36 +0000
Message-ID: <> (raw)
In-Reply-To: <>

On 1/17/2020 11:49 AM, Wei Hu (Xavier) wrote:
> From: "Wei Hu (Xavier)" <>
> Currently, there is a potential problem that changing the content of
> dev->data->dev_conf.rxmode.offloads even when there is no vlan_offload_set
> driver callback.
> It is a good idea that prevent the side effect and make the API return
> success if no change requested. This patch fixes the problem, the detail
> information as below:
>  - keep possibility to do dummy set even if there is no driver callback
>  - do not touch Rx mode offloads in device data before checking the driver
>    callback availability
>  - ensure that Rx mode offloads are rolled back correctly if driver
>    callback returns error
> Fixes: dfebfc9882fb ("ethdev: support dynamic configuration of QinQ strip")

I think the problem (API modifying the device config even 'vlan_offload_set'
dev_ops is not implemented) exists from the beginning.

Fixes: 81f9db8ecc2c ("ethdev: add vlan offload support")

> Cc:
> Signed-off-by: Wei Hu (Xavier) <>
> Signed-off-by: Chunsong Feng <>
> Signed-off-by: Min Wang (Jushui) <>
> Signed-off-by: Min Hu (Connor) <>
> Reviewed-by: Andrew Rybchenko <>

  reply	other threads:[~2020-01-17 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 11:49 Wei Hu (Xavier)
2020-01-17 14:31 ` Ferruh Yigit [this message]
2020-01-17 14:34   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone