From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 391ED456A1 for ; Wed, 24 Jul 2024 13:33:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A3CB42F01; Wed, 24 Jul 2024 13:33:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id E171342D28; Wed, 24 Jul 2024 13:33:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721820800; x=1753356800; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=lj+5UjJaK31rboJ3hxdwAq0ClRKaiXD7KgEvEY5P8gk=; b=oGWxFGSfFk6dpWPNR+Wg3UH+EG2z8nB+RXse5bxqhYZF5PT+DJyy+xHj VBkfjRT+xDoJKH5FR38bDZ82zHDUPZcIq9HBSKmbJ1asklZy/zmIdYNv1 r9NzfmUmsjBT8z05LcPSB1FlVIgi1obAdZlcdKribVwEwZI68WPU735KM wErW3Z4bCLUYPKcOwRO2Wo7gxQsX6nvj8zpksD4P5INUtHkYtcIAhNDMC MuJTds8/0v0fRkBNVjEwxGp2Fg/cxu6gDN+YsOZB+BpTJzXx7NJK5CN2S S8ZfmLTniayMEcvb5K4yXHJyYxSmJHsY9wiqbC5mf4ClgY/v09CH9ZAIA w==; X-CSE-ConnectionGUID: Ck1YCHP2St6/upqYOLctrQ== X-CSE-MsgGUID: ZCdposWQRwSUrTkKBSHG1A== X-IronPort-AV: E=McAfee;i="6700,10204,11142"; a="23304301" X-IronPort-AV: E=Sophos;i="6.09,232,1716274800"; d="scan'208";a="23304301" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2024 04:33:18 -0700 X-CSE-ConnectionGUID: RuMRjNipQt6UvHa065mzfA== X-CSE-MsgGUID: B6SHboX9TN+BV1aewLVUiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,232,1716274800"; d="scan'208";a="56705256" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jul 2024 04:33:17 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 24 Jul 2024 04:33:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 24 Jul 2024 04:33:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 24 Jul 2024 04:33:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jlNveILljQJH/WtMNqiY0VjSsqma+VcalVTgDGlk1S9KmRMBowYVucu7rJKGP9qxYbhlpvdJJqenfRABCxm+GrNnC6GyN2iXYqLLylq2UAhe/rdWRbGDm5CoXH6wSMm72Umi/3b+M0nHr8orD3QQSy40Oc/spOD3wlRnH2UGJXgY621WNI5s/Tw8S33lsB9jWP3e5/SWDKS5EcOvDs+/c3JlIdUzcKHAzbwgCscTpub2d/9Gp+AnVBD0ydmlIjmZUnO6SSK5v48a7naiMeljlt0wZZ5Pjbeod4JE+HvGFE7+Gb2JdkipD0V80rZKvFQXlU+o1DigNxWufajBqrWkhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W2MLzPKNPqCS8JOBOwmKHhfJJlrHEY/MXtA216t/8tI=; b=Lj2Phyn+2nZjtX8u3w8nqhz5B3SSUBV3QVuBkP4ItJjPqAfOabDzz0Ytf5dMYb5ej2ksnG3hkfCV3ZqyprMKcr8jQ5SmkEB5Uap2DLyPYDJimfggDDiaEiBPUWo00Rme29QIJc5KWx8/jKNjYsZ/qy53boslF4VYAVz9evZ5cBMPSeFrYHWrQ8+8PjyplKWtLSNUTacJejrKceXzC/rgybT5asEhcy1J/hpW1f1MsXsukLm/m9NUANIx5i5LZIbKpQ2IwKhbDjwx4LmX2VkEDgyvcHhHjtvkOcnLbvgM1LN5whLz+5lQ7MiKLw49mx5PnfIE0ulHkshjodAM/ZhfBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by SN7PR11MB6900.namprd11.prod.outlook.com (2603:10b6:806:2a8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Wed, 24 Jul 2024 11:33:10 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2962:1efd:f912:a5a3]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2962:1efd:f912:a5a3%5]) with mapi id 15.20.7784.020; Wed, 24 Jul 2024 11:33:10 +0000 Message-ID: <7d006696-9a40-4c23-824d-1e984743632a@intel.com> Date: Wed, 24 Jul 2024 12:33:04 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem To: Akhil Goyal , "Medvedkin, Vladimir" , Chaoyong He , "dev@dpdk.org" , Anoob Joseph , "Nithin Kumar Dabilpuram" , Gagandeep Singh , Kai Ji , Brian Dooley , Jack Bond-Preston , "pablo.de.lara.guarch@intel.com" , "hemant.agrawal@nxp.com" , "suanmingm@nvidia.com" CC: "oss-drivers@corigine.com" , Shihong Wang , "stable@dpdk.org" References: <20240311024939.2523778-2-chaoyong.he@corigine.com> <20240314020052.3107549-1-chaoyong.he@corigine.com> <7c690dcb-8824-452e-85d5-7f665ff56246@intel.com> <4494141c-268a-4b41-8582-37ca96ddaf0a@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0183.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::21) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|SN7PR11MB6900:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e686094-b431-46dd-9737-08dcabd4653f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|7416014|1800799024|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TmZTenRoQW0vQk5uUXpkWFlLWnBidUxyaFdkZzJVZDRhanZ6c3ZaaDNPRzVs?= =?utf-8?B?Mkp0eVo1N1BGWFVUaUtMMnppaEJkUGQ1dld3UXZaL3dhdHNGem5zNm5hUHNs?= =?utf-8?B?dC9pRW1PZ1g3ck94UFJINmoyR25JRUlYU3p1Um5YYm9ZZERpWk9uRU1WdUF5?= =?utf-8?B?Y2JYVUpGbEdPU1BjbDJSM1Q0eklzTlY4WGNhZ1JZdmZ3Z0ZQTHJWd2FZTE1z?= =?utf-8?B?SXl4Wis2ZER5RFFtOWV5Q1AyZGdpMEQra3BpVW1UYVRnTUtFd3hDYVNCZE9M?= =?utf-8?B?MlRXcElSWS85MG5zbXhMdW1zVk9GL1JyWnhEUzBLd1NrV2RtdUFCcEFuWE45?= =?utf-8?B?ZDJkcnBqN2dWNHFKQUpJSkt5bFdTMjBtU1R3bENOOWVYRWhFUlFVUU92NXVy?= =?utf-8?B?LzJIY2xxRHlpZU9SUWhhNlZjMlo2dUJ4NDlBMjNRUHg0KzRjVW5RdWRMcytH?= =?utf-8?B?QnFwZ29FSU1PbGUvbjdZcVJzTmtNb0YwbVZ1My9neEk3QThkaFJjQVJJcFlJ?= =?utf-8?B?NlQycDNTYnI3ODJMRlRaNmRVVzNRcFpJcXlMT0s2RldxY244MTZ1MzdtVlVL?= =?utf-8?B?d1pzTXZQMWx5b2p6cE45QTAvWWxFd1cvbmUrRGh4RDRLT3FKY0NMc2NiU3lO?= =?utf-8?B?ZkxMb2hCbHo0SnQ3STNRTGJmbXNod3hFL1hmSU5VUXBaQXRiSDBFRzR5Q25h?= =?utf-8?B?L0trYldxd1dpZjNwT2FmaDMzNXNtVjhmTzlkWVF1b2syMEtreGNpQVhsYnhy?= =?utf-8?B?cjk1TXBXOThzdGFBRzMrNjMzekhPVkVlaWxwM2ZRd0J1R0hodjJaQTVGZ3BS?= =?utf-8?B?ckE1SkdLdUdYdWtEc0ladmQ4NnFUOVM5VE9iUWRJTm9NNFpzbnB3OTBOZXJN?= =?utf-8?B?VnpkYWlUdFcyOUVhemZrZTdoWllLcExTWkNRNUMyeUhFaWdZaXZJa3cxVlY1?= =?utf-8?B?eWc0Q2RSSUdjNExzSUVZVUV4NGpDT3dSSzJpb1JHVnhNUVZpT0JpUzEyTE1Z?= =?utf-8?B?Z0luMVBSVGhHVXIrOWlrOXBzbTNtd3lOaXBKaU44OUJsbjkvRGh1QW41ZGJ6?= =?utf-8?B?OXRBUmdHNWNSS3dpR0R6KzdrR200VTBoeVBZb2VySzBsZWw4Q1c0N2E5NktS?= =?utf-8?B?Y0FBdnBCZmkydzRkTEVOM2ZadS8rNy8xTEtCMGdVZCsycjBnekVWMnJWSnhI?= =?utf-8?B?QzNRMUpZRXRTSTk3UHlUb1E0K0NVR0hEeXFQUzg4Z0cyN1BtMGVmM0JSRFNi?= =?utf-8?B?cjEvS3pWdlJjTmdIYStEMG02amRwS01kbm5yWjIvVTJnRHhESEwxd3duTHJW?= =?utf-8?B?cW4rdEFBZU9xYjFTTU94TEJrYkJPUllPbjNwTzZFdVZILzJDZmFzTWplQWpu?= =?utf-8?B?elZETEk3VGVqL1U5MGxsZTA1QlpmTXBNMnJ4aXAwUDV0em02WDdSbWg3cFNS?= =?utf-8?B?bzA4eEtEcEVDRXdNdCthUDVGNTdIY21yeUFEVitiVEFkbWR6ZGpwVE5kcERS?= =?utf-8?B?SW1TOWdlZko3T0tEMytXVmNsZDVmSURLRXFOMlc4c0p1MjR3SXZsdnNIREZR?= =?utf-8?B?eWZ6S3NKWFlVRzBQdEg5dXBzNjdrQmdvR3hNTGllQndzQTY1Vkxub09ldjYz?= =?utf-8?B?RDZ4UEs2WHVRLzJVejBiYzFOYVE5SUc1TTRFcWp2VE5zY0tTVG00TWNvMjhV?= =?utf-8?B?RTg2bVQwZmJPSkJEcDJPR09tS29URmFJQmFOMndtK1M0dTJOYTQ3cVdoR29w?= =?utf-8?B?enUzNE5Id1ZnaG14Yk95UklHeUVqL25EenAxb0lJYmhRVnlUbE9EY0swUVpn?= =?utf-8?B?cnd4dmw4eVp1c3NnaWg2QT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(7416014)(1800799024)(921020); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjk3NWhTemZJUVVsZzYydW02MllxNyt2bGlaazVpWEs4TitaSml1R1FQLzhn?= =?utf-8?B?TCt2dmtaMThPakZnRXlZNWFkT3VWTWlHK2tac1dKL0JRbW5qNFpmK0VRclNW?= =?utf-8?B?UXdGWVFOa0hCMXBLMHQrSkU4MnRnSnNxUTEzY1F1M29WQWxyTEdjTW8ycXdF?= =?utf-8?B?ejN1bWZTY2xNWlE4dzh5UnRiazh3WldlT1FCTU9ER2wvdlBBRHdkeTdLb2d0?= =?utf-8?B?YnRIdzV5c2VobHR3VTFKWG9wRmRnQTl0dzErWXh0K1hWbm1wZ2E5QjdFc2xj?= =?utf-8?B?ZGdncDFxaVR5elFqRHpYVHI5dUs1M2dkWFY5ZjZCam1HSGc1Q255TlZhTWxm?= =?utf-8?B?S09tcnFUTmczczR0N1hRRHoxMTNQblMxTVg4T0NldERUSEQ2YlNNcnNkU3g1?= =?utf-8?B?Y01JanJ1MExyRW44a1dGUW02VUJBcFlOQVluVVliOGFPOTFXdlZnYVV1ODI1?= =?utf-8?B?QkZNK1pqQ1RtSVh2NTRJei8vTnBjb2RlWllXOGw0Q29Rb2RPaXIwbEltdnc2?= =?utf-8?B?U3pxaSt4WGFYellrNnFQZUhFQWViMG1PYUZDampieU9Yd2xhdnBKcnBCQTli?= =?utf-8?B?dWF4VVBYZU5LcVVTUGFINlZZcEF4YTFGMTNrRGc2Z0NpYm5OOHRBNjZKMzVh?= =?utf-8?B?RXh6ZFp6VjVzUHdwUzcwUmFtK3hsWUk5c3luc1NzVVQ3Y3A5TDBFd0RRazJD?= =?utf-8?B?UnpCVU9VN1ROdy90MUV1S2hBWlJWbFBEYkRqYld3M01VcFlHaWNWU2Fsd1BL?= =?utf-8?B?amVnZW9TeDlUUlVRcnhlQ2FmUFhzTFR3MkhyOUdQK0JtRjYwUGM1SUtkMGVt?= =?utf-8?B?aW9FWC9TRkwyVmQwTVduYk9RUXM2ZXo2a2lRb3FHaXpNSTMwbGxUU2x1bFVM?= =?utf-8?B?L3lTcDBORzIxZEVMa3RtNmlDWEVyV0luNk1ySUxSd0d0Yjh6TWY5aUNmZUY2?= =?utf-8?B?RzRsbzI0L1FRaXZ6UDBxUEFUUzJOZmU4TEUxVDYzckhFSTBaaVVSRENvSWNW?= =?utf-8?B?R3BhODNCMmJKOUxHNFRpMlpVcjNaUmRjbEVlVXowMTNLaXh5Q1VVZU14QkNT?= =?utf-8?B?ZlF5cndCUitzZE1xMGo2dzkyenpuTllKWG5GS09FUk1jc1lKSlcrRHczUjR2?= =?utf-8?B?TVFtR0NzRU1yRGJUTElRZ0hyZHEycSsrQWRoSzM5TFhYOFFoTUNGK2pzMnBV?= =?utf-8?B?dXhrV291UlV5WjlKN0NKaUNEM2M0aVFiaU5wdVYvTmpRNUZHQTFrMEJuckpJ?= =?utf-8?B?YWdxM1RPZnpaSDRRNWsrSXVEWjJOVWhxS0RZKzVyT0NPbEsrcllaVDBSM3Fq?= =?utf-8?B?bW1obkZMNVJCZnlPd0JXczZya3lXVFErcUh3K21nRXU5NGlZQjVCc1gzNEV1?= =?utf-8?B?THBRU0lEWVQyU2t2V3VaVUtsVW13ekFOMzY5RXcvOGVOVXRCVGk1VGQ4VWFW?= =?utf-8?B?TEZsZXptVmJHUVQwbXZzVS9iZG9oNGxSdFdnc3JvdWFlTS9XMWR0RHl5ODdR?= =?utf-8?B?a2ZUVjhwa2JldG5JWUhWSUlDa2FYSGw0bjAvemFnM0gwS3dQNm5kbU9LMmxE?= =?utf-8?B?SEh6UldpSDU0aE5FbnlkNFhIVFYrVG0zTkEwcEJ6bW1Sc0t3cUVzTEJpY1RQ?= =?utf-8?B?a2J5NUZ6ek5oZk1HMVZKQ3JrRWhzcy9Sc2I3ck1FSFRKODZPVTNoYWo0V0U5?= =?utf-8?B?RnJFVElndmtPdHdKTWpMQ09ML05wZFM4cXc3M1NKc2F6djlYMTM0TEIwZ3lq?= =?utf-8?B?WWh6a1Z6eHN3V21sTERDQTAycG1ZdUY3aFRLYlk0TTBRN2srUTcwMnZjZEZF?= =?utf-8?B?NjZrSFRrUGV5MGxsMGVBckxveTdZdFRWKzc4L0Z4S0dMcWJVZVluY3dsTW1V?= =?utf-8?B?ZElMQWtWZ3ZLbzZIcFZreEtmZHorR2NJclN5dUJjYUprVjBHampoWHdmbVpa?= =?utf-8?B?MkdQSjNHcEVYU2NJYkpsdVNPUDJOT09adkpkSVhBUXhzVUdiRUc0SG0vcjV6?= =?utf-8?B?Rzlldk92em9MUXg3MkozTFlKRkdsVXJ0Tzl6eEx6QjdvT2llUDQzRERUa3lC?= =?utf-8?B?czk4V3EvWXIyWXY3OVpsdlQzU3d5cmNyNW9ZWGRUOHpobUpSaXVrOTJzUGVW?= =?utf-8?B?cUREeFloZVJldmQzV3pmdDBGeUlRM0hUKzVaNzZuZnNLbThWWGdsWjA4ai8x?= =?utf-8?B?cVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3e686094-b431-46dd-9737-08dcabd4653f X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2024 11:33:10.0976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ghhr0FTQu3LbTPQeL0un6OxSkoSSihFWn/b9uqksubDUDqFpHKTZ55AKLcTW5vX20pHW09JHbkOrikhW8O7fgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6900 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 24-Jul-24 12:20 PM, Akhil Goyal wrote: >> On 23-Jul-24 5:57 PM, Akhil Goyal wrote: >>>> Hi all, >>>> >>>> This patch breaks ipsec tests with ipsec-secgw: >>>> >>>> >>>> ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 >>>> ... >>>> ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for >> dst=192.168.31.14, >>>> sz=1 >>>> test IPv4 trs_aesctr_sha1 finished with status 1 >>>> ERROR test trs_aesctr_sha1 FAILED >>>> >>> The patch seems to be correct. >>> Please check endianness in the PMD you are testing. >> In my opinion salt should not be affected by endianness and it should be >> used as it is in the key parameter. I think the patch is wrong to make >> it CPU endianness dependent before being passed to the PMDs, any PMD >> that needs the endianness swapped should do it in the PMD code. Indeed >> it's passed around as a 32 bit integer but it's not used as such, and >> when it's actually used it should be evaluated as a byte array. >> >> https://datatracker.ietf.org/doc/html/rfc4106#section-4 >> https://datatracker.ietf.org/doc/html/rfc4106#section-8.1 > As per the rfc, it should be treated as byte order(i.e. big endian). > But here the problem is we treat it as uint32_t which makes it CPU endian when stored in ipsec_sa struct. > The keys are stored as an array of uint8_t, so keys are stored in byte order(Big endian). > > So either we save salt as "uint8_t salt[4]" or do a conversion of cpu_to_be > So that when it is stored in PMD/HW, and we convert it from uint32_t to uint_8 *, there wont be issue. RFC treats it as a "four octet value" - there is no endianness until it's treated like an integer, which it never is. Even if it code it's being stored and passed as an unsigned 32bit integer it is never evaluated as such so its endianness doesn't matter. I agree that we should have it everywhere as "uint8_t salt[4]" but that implies API changes and it doesn't change how the bytes are stored, so the patch will still be wrong. > >>> >>>> >>>> On 03/07/2024 18:58, Akhil Goyal wrote: >>>> >>>> >>>> >>>> >>>> >>>> -----Original Message----- >>>> From: Akhil Goyal >>>> >>>> Sent: Friday, March 15, 2024 12:42 AM >>>> To: Akhil Goyal >>>> ; Chaoyong He >>>> >>>> ; dev@dpdk.org >>>> Cc: oss-drivers@corigine.com >>> drivers@corigine.com> ; Shihong Wang >>>> ; >>>> stable@dpdk.org >>>> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix >>>> SA salt >>>> endianness problem >>>> >>>> >>>> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec- >>>> secgw: fix SA salt >>>> endianness problem >>>> >>>> >>>> From: Shihong Wang >>>> >>>> >>>> The SA salt of struct ipsec_sa is a CPU-endian >>>> u32 variable, but it’s >>>> value is stored in an array of encryption or >>>> authentication keys >>>> according to big-endian. So it maybe need to >>>> convert the endianness >>>> order to ensure that the value assigned to the >>>> SA salt is CPU-endian. >>>> >>>> Fixes: 50d75cae2a2c ("examples/ipsec-secgw: >>>> initialize SA salt") >>>> Fixes: 9413c3901f31 ("examples/ipsec-secgw: >>>> support additional algorithms") >>>> Fixes: 501e9c226adf ("examples/ipsec-secgw: >>>> add AEAD parameters") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Shihong Wang >>>> >>>> Reviewed-by: Chaoyong He >>>> >>>> >>>> >>>> Acked-by: Akhil Goyal >>>> >>>> >>>> Applied to dpdk-next-crypto >>>> >>>> >>>> The patch is pulled back from dpdk-next-crypto. >>>> This change may cause all the PMDs to fail these cases. >>>> Would need acks from PMDs. >>>> >>>> >>>> Applied to dpdk-next-crypto >>>> No update from PMD owners. >>>> Applying it before RC2 so that we have time for fixes if needed. >>>> >>>> >>>> -- >>>> Regards, >>>> Vladimir