From: Kevin Traynor <ktraynor@redhat.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Igor Romanov <igor.romanov@oktetlabs.ru>, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/sfc: fix MTU change to check Rx scatter consistency
Date: Wed, 8 May 2019 17:06:42 +0100 [thread overview]
Message-ID: <7dafc0af-871f-0b7a-e4cc-797e8ac646ad@redhat.com> (raw)
In-Reply-To: <1556007270-1511-1-git-send-email-arybchenko@solarflare.com>
On 23/04/2019 09:14, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> Rx queue setup function checks configured MTU to make sure that
> no oversized packets can be received. But a following call to
> set MTU function might make this check irrelevant.
>
> Add a function to check MTU size against Rx buffer size and
> additional Rx queue info, including Rx scatter offload.
>
> Fixes: e961cf425e02 ("net/sfc: support MTU change")
> Cc: stable@dpdk.org
>
Hi again - this one is causing a build failure on 18.11 branch. Please
send a backport or let me know if it's not required.
CC sfc_ethdev.o
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c: In
function ‘sfc_check_scatter_on_all_rx_queues’:
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42:
error: implicit declaration of function ‘sfc_sa2shared’; did you mean
‘sfc_stats_get’? [-Werror=implicit-function-declaration]
struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
^~~~~~~~~~~~~
sfc_stats_get
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42:
error: nested extern declaration of ‘sfc_sa2shared’ [-Werror=nested-externs]
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42:
error: initialization of ‘struct sfc_adapter_shared * const’ from ‘int’
makes pointer from integer without a cast [-Werror=int-conversion]
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:871:21:
error: dereferencing pointer to incomplete type ‘struct sfc_adapter_shared’
for (i = 0; i < sas->rxq_count; i++) {
^~
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:878:38:
error: ‘struct sfc_adapter’ has no member named ‘rxq_ctrl’; did you mean
‘rxq_max’?
if (!sfc_rx_check_scatter(pdu, sa->rxq_ctrl[i].buf_size,
^~~~~~~~
rxq_max
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
prev parent reply other threads:[~2019-05-08 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 8:14 [dpdk-stable] " Andrew Rybchenko
2019-04-23 11:35 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-05-08 16:06 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dafc0af-871f-0b7a-e4cc-797e8ac646ad@redhat.com \
--to=ktraynor@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=igor.romanov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).