From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 538415681;
Mon, 27 Aug 2018 18:16:32 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
27 Aug 2018 09:16:31 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,295,1531810800"; d="scan'208";a="68475830"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.148])
([10.237.220.148])
by orsmga008.jf.intel.com with ESMTP; 27 Aug 2018 09:16:30 -0700
To: Qi Zhang <qi.z.zhang@intel.com>, dev@dpdk.org
Cc: gage.eads@intel.com, stable@dpdk.org
References: <20180827122732.5531-1-qi.z.zhang@intel.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <7ea4dd19-cd84-7b40-e0b9-ff25b85d6769@intel.com>
Date: Mon, 27 Aug 2018 17:16:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180827122732.5531-1-qi.z.zhang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH] bus/vdev: fix wrong error log on
secondary device scan
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Aug 2018 16:16:33 -0000
On 27-Aug-18 1:27 PM, Qi Zhang wrote:
> When a secondary process handles VDEV_SCAN_ONE mp action, it is possible
> the device is already be inserted. This happens when we have multiple
> secondary processes which cause multiple broadcasts from primary during
> bus->scan. So we don't need to log any error for -EEXIST.
>
> Bugzilla ID: 84
> Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
> Cc: stable@dpdk.org
>
> Reported-by: Eads Gage <gage.eads@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/bus/vdev/vdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 6139dd551..af9526fe6 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -346,6 +346,7 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void *peer)
> const struct vdev_param *in = (const struct vdev_param *)mp_msg->param;
> const char *devname;
> int num;
> + int ret;
>
> strlcpy(mp_resp.name, VDEV_MP_KEY, sizeof(mp_resp.name));
> mp_resp.len_param = sizeof(*ou);
> @@ -380,7 +381,10 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void *peer)
> break;
> case VDEV_SCAN_ONE:
> VDEV_LOG(INFO, "receive vdev, %s", in->name);
> - if (insert_vdev(in->name, NULL, NULL) < 0)
> + ret = insert_vdev(in->name, NULL, NULL);
> + if (ret == -EEXIST)
> + VDEV_LOG(INFO, "device already exist, %s", in->name);
This is probably going to be printed a lot, and there's no real point in
that. Maybe set log level to DEBUG instead?
> + else if (ret < 0)
> VDEV_LOG(ERR, "failed to add vdev, %s", in->name);
> break;
> default:
>
--
Thanks,
Anatoly