From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 38B65A045E
	for <public@inbox.dpdk.org>; Fri, 31 May 2019 15:37:06 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0CCD72C60;
	Fri, 31 May 2019 15:37:06 +0200 (CEST)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 18B942C60;
 Fri, 31 May 2019 15:37:05 +0200 (CEST)
Received: by mail-wr1-f67.google.com with SMTP id p11so1725774wre.7;
 Fri, 31 May 2019 06:37:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:content-transfer-encoding:user-agent:mime-version;
 bh=uSqGVwCcyUNjs2iQPoEBu3BlGT5cPuI0y1ZgJzCIZdo=;
 b=HIsbDqSesIL9P/q+aaVhQjWS2BjXeh2lL9i7gBE3O7hG9EVz6ojPWX3dWmlt29XxZT
 4WY3V5o4iMDq59Rv5Gcw98ss6DRY4e81msO1Yi3crFMOXZlsrXfX2k3hLczhU6PRTweW
 RAnyG+k/Nb6vMkc5oNwh6Z11wWmknxCZqGssap1jU6E5yIgDBINjzqKSwyG3SVnw6yoU
 LVrVLgzltzQXUtD/aPoGD9JbiOWK046g9pkcoZTg4CtbHv7mtvNE5cU1x8Gp1v0Ih7RL
 i2mXNyfZqnjUC55uqDsGVvUnCG8S5KR+qKxMnHCzLDnkzu/gARyPzPjLr/0H/P+B7SvS
 gWOQ==
X-Gm-Message-State: APjAAAXWP6VZLaDvs81Ju9mfVzhe3KnCrMDwAlLH3aaZESn+lQB4p1hm
 p978V6zOfUdSuAtPWfGZeCA=
X-Google-Smtp-Source: APXvYqyq8PHNWTYmjEG+33o85TczbAi1iEirMhbMZ6PmZcAV3+NvyH4LKMBx/J2GAGrS07K+I6PDfg==
X-Received: by 2002:a5d:6748:: with SMTP id l8mr6731945wrw.199.1559309824569; 
 Fri, 31 May 2019 06:37:04 -0700 (PDT)
Received: from localhost ([88.98.246.218])
 by smtp.gmail.com with ESMTPSA id k184sm12162963wmk.0.2019.05.31.06.37.01
 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
 Fri, 31 May 2019 06:37:02 -0700 (PDT)
Message-ID: <80ff3b4893cece8060d4fd7d783783a70e54e49d.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Timothy Redaelli <tredaelli@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org
Date: Fri, 31 May 2019 14:37:01 +0100
In-Reply-To: <0c31ecf46994f3c582f14842446c538ebe0622d9.1559301086.git.tredaelli@redhat.com>
References: <0c31ecf46994f3c582f14842446c538ebe0622d9.1559301086.git.tredaelli@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.30.5-1 
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [PATCH] usertools: Fix clearing any old data
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On Fri, 2019-05-31 at 13:11 +0200, Timothy Redaelli wrote:
> Currently clear_data (dpdk-devbind.py) doesn't work as expected since
> "global devices" is missing and so "devices" is considered a local
> variable.
>=20
> This commit changes "clear_data" function in order to really clear
> devices by adding "global devices".
>=20
> CC:=20
> stable@dpdk.org
>=20
>=20
> Signed-off-by: Timothy Redaelli <
> tredaelli@redhat.com
> >
> ---
>  usertools/dpdk-devbind.py | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 9e79f0d28..e6b551d33 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -210,6 +210,7 @@ def get_pci_device_details(dev_id, probe_lspci):
> =20
>  def clear_data():
>      '''This function clears any old data'''
> +    global devices
>      devices =3D {}
> =20
>  def get_device_details(devices_type):
>=20

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi