From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
stable@dpdk.org, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/rxtx_callbacks: fix port ID format specifier
Date: Wed, 12 May 2021 01:35:12 +0200 [thread overview]
Message-ID: <8146889.VriENkGL5R@thomas> (raw)
In-Reply-To: <20210511223435.GA4881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
12/05/2021 00:34, Tyler Retzlaff:
> On Thu, May 06, 2021 at 01:13:07AM +0200, Thomas Monjalon wrote:
> > 06/05/2021 00:45, Tyler Retzlaff:
> > > as a side question, what is the projects stance on getting more warnings
> > > clean? there are a few not enabled that i'd really like to see e.g.
> > > format, conversion, truncation etc..
> > >
> > > i looked at lib/eal previously and there are... hundreds? of instances so
> > > it's a non-trivial task. the problem i see is somehow getting to a
> > > warnings clean state where we can enable -Werror in the CI pipeline but
> > > at the same time figuring out how to prevent new instances from
> > > appearing until we do.
> >
> > I don't understand the question.
> > We are already supposed to be warning-free,
> > and -werror should be enabled in all CI labs.
> > What are the gaps?
>
> with the warnings we have enabled -Werror passes, but we don't have all
> the warnings we could have that are of value. it would be great to see
> -Wconversion -Wsign-compare -Wsign-conversion passing clean.
>
> i admit it is a lot of work though.
-Wsign-compare is enabled for sure, look at config/meson.build.
For the conversion warnings, I don't know.
Do not hesitate to propose new warnings enablement
with a list of warnings it is generating in its current state,
so we can decide whether to enable (and fix) or not.
next prev parent reply other threads:[~2021-05-11 23:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 2:56 [dpdk-stable] " Dmitry Kozlyuk
2021-05-04 0:11 ` [dpdk-stable] [dpdk-dev] " Tyler Retzlaff
2021-05-04 6:48 ` Dmitry Kozlyuk
2021-05-05 16:00 ` Tyler Retzlaff
2021-05-05 21:39 ` Thomas Monjalon
2021-05-05 22:45 ` Tyler Retzlaff
2021-05-05 23:13 ` Thomas Monjalon
2021-05-11 22:34 ` Tyler Retzlaff
2021-05-11 23:35 ` Thomas Monjalon [this message]
2021-05-05 21:51 ` [dpdk-stable] [PATCH v2] " Dmitry Kozlyuk
2021-05-05 21:54 ` [dpdk-stable] [PATCH v3] " Dmitry Kozlyuk
2021-05-06 2:56 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2021-05-12 19:37 ` Thomas Monjalon
2021-05-06 2:54 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8146889.VriENkGL5R@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).