From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>,
Kevin Traynor <ktraynor@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error
Date: Tue, 2 Jul 2019 18:56:52 +0100 [thread overview]
Message-ID: <81d914fd-3db9-239c-c0e7-746bac7d4142@intel.com> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07F03B3F@PGSMSX103.gar.corp.intel.com>
On 6/12/2019 2:04 AM, Zhao1, Wei wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Tuesday, June 11, 2019 10:42 PM
>> To: Zhao1, Wei <wei.zhao1@intel.com>; Kevin Traynor
>> <ktraynor@redhat.com>; dev@dpdk.org
>> Cc: stable@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error
>>
>> On 6/11/2019 2:28 AM, Zhao1, Wei wrote:
>>> Hi, Kevin Traynor
>>> This patch is based on Yigit Ferruh's suggestion in the following mail.
>>> https://mails.dpdk.org/archives/dev/2019-May/132178.html
>>> If we take your propose, it means we do need any patch at all.
>>> Because the code implement now is just that scheme, we will do "or" for
>> offloads.
>>> Hello Ferruh,What is your comment?
>>
>> My comment was if the user not set the queue offload use the default one, so I
>> think we don't need to track individual offload options.
>>
>> But also there is slightly difference between user not set the value and
>> 'offloads' being zero. What if user set the offloads value to '0' to disable all
>> offloads, it will use default values in this case.
>>
>
> Yes, we can not distinguish between not set the value and using 0 to disable it, so if the bit is 0 how can we
> Know the actual purpose of users? I think it is hard track individual offload as Kevin Traynor said.
Yes it is hard to track, and I believe this is better than the existing code, so:
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2019-07-02 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 6:45 [dpdk-stable] " Wei Zhao
2019-06-10 10:09 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2019-06-11 1:28 ` Zhao1, Wei
2019-06-11 14:41 ` Ferruh Yigit
2019-06-12 1:04 ` Zhao1, Wei
2019-07-02 17:56 ` Ferruh Yigit [this message]
2019-07-02 18:02 ` Ferruh Yigit
2019-06-11 1:31 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81d914fd-3db9-239c-c0e7-746bac7d4142@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).