From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E8B8A04DB for ; Wed, 2 Dec 2020 15:42:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D902C99C; Wed, 2 Dec 2020 15:42:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 07382C99C for ; Wed, 2 Dec 2020 15:42:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606920160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f3L2ggekZLe4D9jeZGq6mZZHF/W2jCjtW4NhzHbyT/8=; b=X1EFkQr/CADnF/FglJNBwGxoNVxSTMyEviiDUJIasv19YKT7+hX5AlH9/uezEe2FCgcWuL u+Ng74uEO4hn9DdvQ2TSrgmwb/vRPBMsCWGd34UHohdOUBuHXuLSTEh9E32hyZC+viTbnj SQFld0MEQfXk+EkIKxT8r/OpkmbQAO4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-rR3Fkr1JMnKFBeJ4jVxaEQ-1; Wed, 02 Dec 2020 09:42:38 -0500 X-MC-Unique: rR3Fkr1JMnKFBeJ4jVxaEQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5428E814406; Wed, 2 Dec 2020 14:42:37 +0000 (UTC) Received: from [10.36.115.131] (ovpn-115-131.ams2.redhat.com [10.36.115.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3BE060BFA; Wed, 2 Dec 2020 14:42:34 +0000 (UTC) To: Olivier Matz , stable@dpdk.org Cc: Bruce Richardson , Radu Nicolau References: <20201202143849.26557-1-olivier.matz@6wind.com> From: Kevin Traynor Message-ID: <838afee8-fe95-84a4-c3c5-c547811f1f02@redhat.com> Date: Wed, 2 Dec 2020 14:42:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201202143849.26557-1-olivier.matz@6wind.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 02/12/2020 14:38, Olivier Matz wrote: > Fix compilation of examples/multi_process: > >> examples/multi_process/client_server_mp/mp_server/main.c:68:4: error: >> implicit declaration of function ‘rte_ether_format_addr’; >> did you mean ‘ether_format_addr’? [-Werror=implicit-function-declaration] >> rte_ether_format_addr(err_address, >> ^~~~~~~~~~~~~~~~~~~~~ > > This failure happens after the backport of > commit a7500412fc5c ("examples/multi_process: fix build on Ubuntu > 20.04"), which uses a function that does not exist in this branch. The > function was introduced by upstream commit 538da7a1cad2 ("net: add rte > prefix to ether functions"), and is just a renaming of an existing > function. > Thanks Olivier. I had noticed this too and fixed locally. I will take your patch as you sent it upstream first. > Fixes: a7500412fc5c ("examples/multi_process: fix build on Ubuntu 20.04") > > Signed-off-by: Olivier Matz > --- > examples/multi_process/client_server_mp/mp_server/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c > index 1a5bf534ff..62abd62cf3 100644 > --- a/examples/multi_process/client_server_mp/mp_server/main.c > +++ b/examples/multi_process/client_server_mp/mp_server/main.c > @@ -65,14 +65,14 @@ get_printable_mac_addr(uint16_t port) > > if (unlikely(port >= RTE_MAX_ETHPORTS)) { > if (err_address[0] == '\0') > - rte_ether_format_addr(err_address, > + ether_format_addr(err_address, > sizeof(err_address), &null_mac); > return err_address; > } > if (unlikely(addresses[port][0]=='\0')){ > struct ether_addr mac; > rte_eth_macaddr_get(port, &mac); > - rte_ether_format_addr(addresses[port], > + ether_format_addr(addresses[port], > sizeof(addresses[port]), &mac); > } > return addresses[port]; >