From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64954A0350 for ; Sun, 21 Jun 2020 15:36:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55A021C0BD; Sun, 21 Jun 2020 15:36:17 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 195A01C0BD; Sun, 21 Jun 2020 15:36:14 +0200 (CEST) IronPort-SDR: FTbV7tXm4v12xrw7L3rFnf6h+eU/SXp8+oeQhhIbkrAlCBvyg07sI7zXtuBPnx2vbpBxo/WDnD QAfDTuKB5sLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9658"; a="123829937" X-IronPort-AV: E=Sophos;i="5.75,263,1589266800"; d="scan'208";a="123829937" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2020 06:36:14 -0700 IronPort-SDR: 7PR+ABXHbEx+bdEPH3h+OnO68Lx7aM3sMN4qxjqekiPK3My0RBPK2d0TdRdwbucNPtqs9VBQWR KlhgAuWVeeRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,263,1589266800"; d="scan'208";a="274762583" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.249.172.228]) ([10.249.172.228]) by orsmga003.jf.intel.com with ESMTP; 21 Jun 2020 06:36:11 -0700 To: alvinx.zhang@intel.com, dev@dpdk.org Cc: stable@dpdk.org, beilei.xing@intel.com, maox.jiang@intel.com References: <20200610120703.8268-1-alvinx.zhang@intel.com> From: Jeff Guo Message-ID: <83f175ae-9f24-44a6-4cc1-10471152b8f4@intel.com> Date: Sun, 21 Jun 2020 21:36:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200610120703.8268-1-alvinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix modifying the number of queues X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" hi, alvin On 6/10/2020 8:07 PM, alvinx.zhang@intel.com wrote: > From: Alvin Zhang > > For the newly created VF, if the number of qps is greater than 4 > at startup, it may fail to start. This patch updates the API > `i40evf_dev_configure`. Could you explicit explain why it limit to 4 qps, and more detail about below code change with the purpose of the patch. > Fixes: c48eb308ed13 ("net/i40e: support VF request more queues") > Cc: stable@dpdk.org > > Signed-off-by: Alvin Zhang > --- > drivers/net/i40e/i40e_ethdev_vf.c | 32 ++++++++++++++++++++++++-------- > 1 file changed, 24 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index bb5d28a..7500e0a 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1082,13 +1082,10 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev, > args.out_buffer = vf->aq_resp; > args.out_size = I40E_AQ_BUF_SZ; > > - rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev); Why interrupt handler is no need to cancel here and more why this change is related with this patch according with the commit log? > err = i40evf_execute_vf_cmd(dev, &args); > if (err) > PMD_DRV_LOG(ERR, "fail to execute command OP_REQUEST_QUEUES"); > > - rte_eal_alarm_set(I40EVF_ALARM_INTERVAL, > - i40evf_dev_alarm_handler, dev); > return err; > } > > @@ -1516,7 +1513,7 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev, > hw->bus.device = pci_dev->addr.devid; > hw->bus.func = pci_dev->addr.function; > hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; > - hw->adapter_stopped = 0; > + hw->adapter_stopped = 1; Why it should be set stopped when init dev? > hw->adapter_closed = 0; > > /* Pass the information to the rte_eth_dev_close() that it should also > @@ -1612,16 +1609,35 @@ static int eth_i40evf_pci_remove(struct rte_pci_device *pci_dev) > ad->tx_vec_allowed = true; > > if (num_queue_pairs > vf->vsi_res->num_queue_pairs) { > - int ret = 0; > + struct i40e_hw *hw; > + int ret; > > + hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > PMD_DRV_LOG(INFO, "change queue pairs from %u to %u", > vf->vsi_res->num_queue_pairs, num_queue_pairs); > + if (hw->adapter_stopped == 0) { > + PMD_DRV_LOG(WARNING, "Device must be stopped first!"); > + return -EINVAL; > + } > + > + rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev); > ret = i40evf_request_queues(dev, num_queue_pairs); > - if (ret != 0) > + if (ret) > return ret; > > - ret = i40evf_dev_reset(dev); > - if (ret != 0) > + /* > + * The device must be reinitiated after queue resources > + * changed > + */ Should you check below part is reinitialize process according to exist dev_close and dev_init. > + i40e_shutdown_adminq(hw); > + i40evf_disable_irq0(hw); > + rte_free(vf->vf_res); > + vf->vf_res = NULL; > + rte_free(vf->aq_resp); > + vf->aq_resp = NULL; > + > + ret = i40evf_dev_init(dev); > + if (ret) > return ret; > } >