From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E90EA0C46 for ; Tue, 14 Sep 2021 13:28:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77F924003C; Tue, 14 Sep 2021 13:28:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 02D41410ED for ; Tue, 14 Sep 2021 13:28:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631618929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qcBHmtLYe0zm/N5FI+AZqRdo1ywh6HPsU1s4bJ3pk5g=; b=dkdt4FZeap4kUx6LTj1eEbaWO4DWX+nqy9S9abb2awrnvo3NWS4peodJ7jv7f7CvJqw8Ab y4HtFJDAwU20hm2njtjzVeo0MPbdBbzo0pox5g061waFP5RERpm9Zf/A1XDdMrfg3hAX13 aauQ1wk4fa4LEQR8VwLT+sjGTAh+SQ8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-O9E-EYHbPLOemzhsX9Q6-A-1; Tue, 14 Sep 2021 07:28:46 -0400 X-MC-Unique: O9E-EYHbPLOemzhsX9Q6-A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D70E802923; Tue, 14 Sep 2021 11:28:44 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87C3D5C3DF; Tue, 14 Sep 2021 11:28:38 +0000 (UTC) To: Andrew Rybchenko , Chenbo Xia , Jens Freimann , Ivan Ilchenko Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org References: <20210902143939.45596-1-andrew.rybchenko@oktetlabs.ru> <0b7f2784-5f08-b209-d719-741012d4bd47@oktetlabs.ru> From: Maxime Coquelin Message-ID: <849110ec-9978-eb11-6b5c-c826dd0ac660@redhat.com> Date: Tue, 14 Sep 2021 13:28:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <0b7f2784-5f08-b209-d719-741012d4bd47@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH] net/virtio: fix device configure without jumbo Rx offload X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/14/21 1:17 PM, Andrew Rybchenko wrote: > On 9/14/21 2:07 PM, Maxime Coquelin wrote: >> >> >> On 9/2/21 4:39 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Use max-pkt-len only if jumbo frames offload is requested >>> since otherwise this field isn't valid. >>> >>> Fixes: 8b90e4358112 ("net/virtio: set offload flag for jumbo frames") >>> Fixes: 4e8169eb0d2d ("net/virtio: fix Rx scatter offload") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Ivan Ilchenko >>> Signed-off-by: Andrew Rybchenko >>> --- >>> drivers/net/virtio/virtio_ethdev.c | 8 ++++++-- >>> 1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>> index e58085a2c9..9bce6833db 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.c >>> +++ b/drivers/net/virtio/virtio_ethdev.c >>> @@ -2099,10 +2099,14 @@ virtio_dev_configure(struct rte_eth_dev *dev) >>> return ret; >>> } >>> >>> - if (rxmode->max_rx_pkt_len > hw->max_mtu + ether_hdr_len) >>> + if ((rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) && >>> + (rxmode->max_rx_pkt_len > hw->max_mtu + ether_hdr_len)) >>> req_features &= ~(1ULL << VIRTIO_NET_F_MTU); >>> >>> - hw->max_rx_pkt_len = rxmode->max_rx_pkt_len; >>> + if (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) >>> + hw->max_rx_pkt_len = rxmode->max_rx_pkt_len; >>> + else >>> + hw->max_rx_pkt_len = ether_hdr_len + dev->data->mtu; >>> >>> if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | >>> DEV_RX_OFFLOAD_TCP_CKSUM)) >>> >> >> Reviewed-by: Maxime Coquelin > > Maxime, please, make letters lower case in From E-mail on > applying. > Done!