From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Itsuro Oda <oda@valinux.co.jp>,
dev@dpdk.org, zhihong.wang@intel.com, xiaolong.ye@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3] vhost: make iotlb cache name unique among multi processes
Date: Thu, 9 Apr 2020 16:25:55 +0200 [thread overview]
Message-ID: <87d14ce3-f9e4-8893-e1a4-7d233f3e39ec@redhat.com> (raw)
In-Reply-To: <20200311231918.20701-1-oda@valinux.co.jp>
On 3/12/20 12:19 AM, Itsuro Oda wrote:
> Currently, iotlb cache name is comprised of vid and virtqueue
> index. For example, "iotlb_cache_0_0". Because vid is assigned
> per process, iotlb cache name is not unique among multi processes.
> For example a secondary process uses a vhost
> (ex. eth_vhost0,iface=/tmp/sock0) and another secondary process
> uses a vhost (ex. eth_vhost1,iface=/tmp/sock1), iotlb cache
> name of both vhost ("iotlb_cache_0_0") are same and as a result
> iotlb cache is broken.
>
> This patch makes iotlb cache name unique among milti processes
> by adding process id to the iotlb cache name.
>
> The prefix of the name is shortend to "iotlb_" since the maximum
> length of pool name is 25 bytes (RTE_MEMPOOL_NAMESIZE is 26).
> Note that it is just 25 characters in maximum at the moment.
> Here,
> * pid_t == int: max 10 digits.
> * vid < MAX_VHOST_DECICE(1024): max 4 digits.
> * vq_index < VHOST_MAX_VRING(256): max 3 digits.
>
> Fixes: d012d1f293f4 (vhost: add IOTLB helper functions)
> Cc: stable@dpdk.org
>
> Signed-off-by: Itsuro Oda <oda@valinux.co.jp>
> ---
> v3:
> * change format.
> * fix commit message.
>
> v2:
> * use the process id to make the iotlb cache name unique.
>
> lib/librte_vhost/iotlb.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-04-09 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 5:00 [dpdk-stable] [PATCH] " Itsuro Oda
2020-03-10 11:32 ` Ye Xiaolong
2020-03-10 12:44 ` [dpdk-stable] [dpdk-dev] " Van Haaren, Harry
2020-03-10 12:58 ` Maxime Coquelin
2020-03-11 0:24 ` [dpdk-stable] [PATCH v2] " Itsuro Oda
2020-03-11 23:19 ` [dpdk-stable] [PATCH v3] " Itsuro Oda
2020-04-09 14:25 ` Maxime Coquelin [this message]
2020-04-10 14:45 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d14ce3-f9e4-8893-e1a4-7d233f3e39ec@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=oda@valinux.co.jp \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).