From: Paolo Valerio <pvalerio@redhat.com> To: "Wang, Haiyue" <haiyue.wang@intel.com>, David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Rong, Leyi" <leyi.rong@intel.com>, "Tu, Lijuan" <lijuan.tu@intel.com>, dpdk stable <stable@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com> Subject: Re: [dpdk-stable] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum Date: Tue, 02 Feb 2021 18:42:34 +0100 Message-ID: <87o8h29xit.fsf@fed.void> (raw) In-Reply-To: <BN8PR11MB379526A102AB5969E87E2651F7B59@BN8PR11MB3795.namprd11.prod.outlook.com> "Wang, Haiyue" <haiyue.wang@intel.com> writes: >> -----Original Message----- >> From: Wang, Haiyue >> Sent: Tuesday, February 2, 2021 20:57 >> To: David Marchand <david.marchand@redhat.com> >> Cc: dev <dev@dpdk.org>; pvalerio@redhat.com; Aaron Conole <aconole@redhat.com>; Zhang, Qi Z >> <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>; Tu, Lijuan <Lijuan.Tu@intel.com>; dpdk >> stable <stable@dpdk.org>; Guo, Jia <jia.guo@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; >> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; >> Ruifeng Wang (Arm Technology China) <ruifeng.wang@arm.com> >> Subject: RE: [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum >> >> > -----Original Message----- >> > From: David Marchand <david.marchand@redhat.com> >> > Sent: Tuesday, February 2, 2021 20:54 >> > To: Wang, Haiyue <haiyue.wang@intel.com> >> > Cc: dev <dev@dpdk.org>; pvalerio@redhat.com; Aaron Conole <aconole@redhat.com>; Zhang, Qi Z >> > <qi.z.zhang@intel.com>; Rong, Leyi <leyi.rong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>; dpdk >> > stable <stable@dpdk.org>; Guo, Jia <jia.guo@intel.com>; Richardson, Bruce >> <bruce.richardson@intel.com>; >> > Ananyev, Konstantin <konstantin.ananyev@intel.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; >> > Ruifeng Wang (Arm Technology China) <ruifeng.wang@arm.com> >> > Subject: Re: [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum >> > >> > On Tue, Feb 2, 2021 at 1:42 PM Wang, Haiyue <haiyue.wang@intel.com> wrote: >> > > > If the driver/hw can't report a valid checksum hint, it should >> > > > announce it does not know if the checksum is valid (neither bad, nor >> > > > good). >> > > > >> > > > So the workaround for udp packets (on this hw model) would be to >> > > > report PKT_RX_L4_CKSUM_UNKNOWN. >> > > > The sw application will then have to recompute the checksum itself if needed. >> > > > >> > > >> > > Make sense, but not sure the vector path can handle this more easily. Will try. >> > >> > Refining this a bit. >> > It looks like hw correctly reports "good" checksums, so maybe instead >> > report PKT_RX_L4_CKSUM_UNKNOWN only for reports of "bad" checksums >> > from the hw? >> >> I guess Paolo will complain about the performance drop for zero checksum >> UDP. ;-) >> :) > > Deep into OVS for detail, 'PKT_RX_L4_CKSUM_UNKNOWN' is a graceful way. ;-) > Will work for this target. yes, validation gets skipped in such case. I'll be happy to test it once posted. > > /* Validation must be skipped if checksum is 0 on IPv4 packets */ > return (udp->udp_csum == 0 && key->dl_type == htons(ETH_TYPE_IP)) > || (validate_checksum ? checksum_valid(key, data, size, l3) : true); > >> > >> > -- >> > David Marchand
next prev parent reply other threads:[~2021-02-02 17:42 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-02 7:06 Haiyue Wang 2021-02-02 9:45 ` David Marchand 2021-02-02 12:42 ` Wang, Haiyue 2021-02-02 12:53 ` David Marchand 2021-02-02 12:56 ` Wang, Haiyue 2021-02-02 14:28 ` Wang, Haiyue 2021-02-02 17:42 ` Paolo Valerio [this message] 2021-02-02 12:54 ` Wang, Haiyue 2021-02-03 2:19 ` [dpdk-stable] [PATCH v2] net/ixgbe: fix UDP zero checksum error Haiyue Wang 2021-02-03 8:07 ` Zhang, Qi Z 2021-02-03 8:32 ` David Marchand 2021-02-04 7:45 ` Zhang, Qi Z 2021-02-04 14:39 ` [dpdk-stable] [PATCH v3] " Haiyue Wang 2021-02-05 17:50 ` Paolo Valerio 2021-02-07 18:40 ` Paolo Valerio 2021-02-08 13:48 ` Ananyev, Konstantin 2021-02-09 1:23 ` Zhang, Qi Z 2021-02-25 10:54 ` David Marchand 2021-04-07 11:53 ` David Marchand 2021-04-08 1:12 ` Wang, Haiyue
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87o8h29xit.fsf@fed.void \ --to=pvalerio@redhat.com \ --cc=aconole@redhat.com \ --cc=bruce.richardson@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=haiyue.wang@intel.com \ --cc=jerinj@marvell.com \ --cc=jia.guo@intel.com \ --cc=konstantin.ananyev@intel.com \ --cc=leyi.rong@intel.com \ --cc=lijuan.tu@intel.com \ --cc=qi.z.zhang@intel.com \ --cc=ruifeng.wang@arm.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git