From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 497ABA0A0E for ; Tue, 11 May 2021 14:16:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C8C4410ED; Tue, 11 May 2021 14:16:38 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id E1D374069F; Tue, 11 May 2021 14:16:34 +0200 (CEST) IronPort-SDR: z7jFmbRau8jhFRRpLlDd+1LYs6rja6SmEIaCGM8xJScjGGY+xnwr4rK5Ueh48mSKLexND/wtzi SLNo0pEZhIAA== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="199477248" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="199477248" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 05:16:32 -0700 IronPort-SDR: +yC845tbGpSxo8Nhn9+OQzivbjlrBrXk3Gd6zqnrSP6foHz8CNdnsvq10LeQGuw6Il3Dv62VZe F7iWIQwxd3pA== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="537000954" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 05:16:30 -0700 To: Michal Krawczyk Cc: dev@dpdk.org, ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, stable@dpdk.org, Amit Bernstein References: <87e65a42-4ae5-1a81-8f8e-74759fc14999@intel.com> <20210511064554.10656-1-mk@semihalf.com> <20210511064554.10656-14-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <88c7a86b-7184-b782-1171-efc7674bfff9@intel.com> Date: Tue, 11 May 2021 13:16:26 +0100 MIME-Version: 1.0 In-Reply-To: <20210511064554.10656-14-mk@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v4 13/19] net/ena: indicate Rx RSS hash presence X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 5/11/2021 7:45 AM, Michal Krawczyk wrote: > To make it possible to the app to determine if the hash was calculated > for the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's > ol_flags. > > As the PMD wasn't setting that, the application couldn't check if there > is a hash in a proper way. > > The hash is valid only if it's UDP or TCP and the IP packet wasn't > fragmented. > > Fixes: e5df9f33db00 ("net/ena: fix passing RSS hash to mbuf") > Cc: stable@dpdk.org > > Signed-off-by: Michal Krawczyk > Reviewed-by: Igor Chauskin > Reviewed-by: Amit Bernstein > --- > v4: > * Add release notes. > * Always announce DEV_RX_OFFLOAD_RSS_HASH if RSS is enabled. > > doc/guides/rel_notes/release_21_05.rst | 1 + > drivers/net/ena/ena_ethdev.c | 12 ++++++++++-- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst > index 755d5fcd32..389a7a05ac 100644 > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -210,6 +210,7 @@ New Features > * Changed memcpy mapping to the dpdk-optimized version. > * Updated ena_com (HAL) to the latest version. > * Fixed bugs when requesting large LLQ headers using the devargs. > + * Added indication of the RSS hash presence in the mbuf. > > * **Added support of multiple data-units in cryptodev API.** > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 6092288239..9a43ab50fe 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -51,6 +51,8 @@ > > #define ENA_MIN_RING_DESC 128 > > +#define ENA_PTYPE_HAS_HASH (RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP) > + > enum ethtool_stringset { > ETH_SS_TEST = 0, > ETH_SS_STATS, > @@ -314,6 +316,11 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf, > else > ol_flags |= PKT_RX_L4_CKSUM_GOOD; > > + if (likely((packet_type & ENA_PTYPE_HAS_HASH) && !ena_rx_ctx->frag)) { > + ol_flags |= PKT_RX_RSS_HASH; > + mbuf->hash.rss = ena_rx_ctx->hash; > + } > + > mbuf->ol_flags = ol_flags; > mbuf->packet_type = packet_type; > } > @@ -1960,6 +1967,9 @@ static int ena_dev_configure(struct rte_eth_dev *dev) > > adapter->state = ENA_ADAPTER_STATE_CONFIG; > > + if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) > + dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; > + Also need to advertise this offload in 'dev_info->rx_offload_capa'. > adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; > adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; > return 0; > @@ -2245,8 +2255,6 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > ++rx_ring->rx_stats.bad_csum; > } > > - mbuf->hash.rss = ena_rx_ctx.hash; > - > rx_pkts[completed] = mbuf; > rx_ring->rx_stats.bytes += mbuf->pkt_len; > } >