From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id EBAD11150;
Wed, 23 Jan 2019 12:49:14 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
23 Jan 2019 03:49:13 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,511,1539673200"; d="scan'208";a="118755091"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.84])
([10.237.220.84])
by fmsmga008.fm.intel.com with ESMTP; 23 Jan 2019 03:49:12 -0800
To: Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: stable@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
References: <1548087515-18823-1-git-send-email-arybchenko@solarflare.com>
<5358053.gQHV9Io9Z3@xps>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <8a15117c-9cf4-2736-655b-7852538d265e@intel.com>
Date: Wed, 23 Jan 2019 11:49:11 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <5358053.gQHV9Io9Z3@xps>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: fix errno to have
positive value
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 11:49:15 -0000
On 22-Jan-19 4:03 PM, Thomas Monjalon wrote:
> 21/01/2019 17:18, Andrew Rybchenko:
>> rte_errno should be set to positive value from errno.h plus
>> few RTE-specific values.
>>
>> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
>> Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Applied, thanks
>
> There are other occurrences in drivers:
> git grep 'rte_errno = -E'
>
There could also possibly be rte_errno = -value; type assignments. I
imagine most of them are correct (since the value itself was negative in
the first place, so additional '-' flips the sign again), but it doesn't
hurt to check :)
--
Thanks,
Anatoly