From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 792C8A0C3F for ; Mon, 28 Jun 2021 11:48:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 648F74068A; Mon, 28 Jun 2021 11:48:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 9F1194068A for ; Mon, 28 Jun 2021 11:47:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624873677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKVDGYu8NsYh+LX72reEgJ1RnJl+QvlejOsKhALfrrQ=; b=VIOMWRtR2Gb+t+7GiSbkffbj5Ua3ywTzvRy8SkLz+H7EKaS1jv5XMpTv2TG1+rUw+VNLEc 8xMaPLT1YI9vp5IAfjBFvsd5xgL4lMUn9EFJxEYviP0GP5AAI35swmiphHuQBFmI2dyLJu HYsZsmVtGShqyoS4GXeFsjdMmrETEho= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-CwEgExRlOZKCC1s7blfkxA-1; Mon, 28 Jun 2021 05:47:53 -0400 X-MC-Unique: CwEgExRlOZKCC1s7blfkxA-1 Received: by mail-wm1-f72.google.com with SMTP id n11-20020a05600c3b8bb02901ec5ef98aa0so796410wms.0 for ; Mon, 28 Jun 2021 02:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oKVDGYu8NsYh+LX72reEgJ1RnJl+QvlejOsKhALfrrQ=; b=Lq2kAqRbfC7wKkAOKYtmLsqeRZx9SiNGTgd84LWL/R5Qyy/YVE7xZsGE9OfDualY9T zUPfP5gjcRsGs6fT3M2ye5/zgGj/jMR/D0YxxBGJx2qTzOwlN0Q/CvigEhIpTDzfgMRl qNPAgjFNn0Cf3DSQAXv/j76mx9rak8xvlEPT4losCvBxxx84GsWNFEkgj1A26xmSV8xc rX5StOgtYVqlx90czqP6ylWo0SY1iN81aOiMlGJuGt2FfedsNn1R3JMHEinPRCvyBJcU gsyKbSro2KlzKHlEphO+G346zLn238zvdor8qlRVjQoyz9/1E/+RgT6MlQIFsnVvVSKP cJEQ== X-Gm-Message-State: AOAM5325W7A0cn7m4OcPYSnzCmCxYDnzySIf5o5+nOeowNviJBWnLRuV AUSnx9Mh9QFXgbjPuMBW10xOa6h+Gfoxq8CC7VJUsK6edJxCusuQrXZ0nByvmcbNow0Ya3iym2v 3JlOU8P4= X-Received: by 2002:adf:e904:: with SMTP id f4mr26436862wrm.334.1624873671932; Mon, 28 Jun 2021 02:47:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRTiBxcxDs0pdS9A3yCsxYKADJ/RwXiqQ9Zg73uPCMosfOYE0N8w6rLSukt+7CF9VfAcirYQ== X-Received: by 2002:adf:e904:: with SMTP id f4mr26436854wrm.334.1624873671803; Mon, 28 Jun 2021 02:47:51 -0700 (PDT) Received: from [192.168.0.36] ([78.17.79.77]) by smtp.gmail.com with ESMTPSA id f22sm12987067wmb.46.2021.06.28.02.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 02:47:51 -0700 (PDT) To: Luca Boccassi , Christian Ehrhardt , dpdk stable , Akhil Goyal References: <205f243e1ed6df6d5b17817e6af4a91f0705fb56.camel@debian.org> From: Kevin Traynor Message-ID: <8a5c03be-cca7-2659-d652-fc7abc0619f7@redhat.com> Date: Mon, 28 Jun 2021 10:47:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <205f243e1ed6df6d5b17817e6af4a91f0705fb56.camel@debian.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] Why was "drivers/crypto: fix build with -fno-common" not picked for 19.11 stable back then? X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 28/06/2021 10:13, Luca Boccassi wrote: > On Mon, 2021-06-28 at 09:34 +0200, Christian Ehrhardt wrote: >> Hi, >> there is an old patch [1] which back then was not considered/taken >> into 19.11 series. >> This is now breaking Clang build [2]. >> >> Since you were the Author/Maintainers back then I wanted to ask if >> there was a reason to not pick it? If it should be picked now and if >> there are any special things to consider for a backport? >> >> Chiming in/subscribing to the bug would also be appreciated. >> >> [1]: https://github.com/DPDK/dpdk/commit/eef9e0412a84cddf8944379ed4995314b4369370 >> [2]: https://bugs.dpdk.org/show_bug.cgi?id=733#c6 > > Can't remember the details about this particular one, but I think > several fixes were backported for the -fno-common issue in 19.11 > I have some recollection is that as -fcommon was the default in gcc at the time of 18.11/19.11 release, using the patch 50b03f3b8eaf ("drivers/crypto: disable gcc 10 no-common errors") to continue to keep it building in the same way, may have been seen as more acceptable in stable than using the same patch on main when gcc had a different default. I had to send that patch as there was no fuller solution provided by the crypto maintainers at the time. Then, late on it was provided and applied to main. So it might have been a mix of the workaround seen as good enough for stable and the other patch coming in late, but I'm not 100% about it.