From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B40AA04AB for ; Wed, 6 Nov 2019 20:04:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45B0D1E8E9; Wed, 6 Nov 2019 20:04:02 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id ACD051E8D0 for ; Wed, 6 Nov 2019 20:04:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573067040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QU8aZiLgZwJrl/oTBBbVE3EICVm/dkDZmY5nbXFcdIE=; b=Kc1M9QWGzUXP3s9UzlGC2fj3GAvRQaQCGFXHq1bKgK/m/MkmkN0vSc4Z0lYISkWwgORXrJ LnUgAAli9kgmKd1Qx7zQZ/zpYscHV1EKoYYT0/xJjVPM/HOWnWr6TPp3VG7zLrD+M7vOvu 0y3CtzsjzEDY0Q/u5z150v2yB/9s0as= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-8HQ9fA7sPR2zMVb9clXo8Q-1; Wed, 06 Nov 2019 14:03:56 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7DF31800D6B; Wed, 6 Nov 2019 19:03:55 +0000 (UTC) Received: from [10.36.118.56] (unknown [10.36.118.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3512427072; Wed, 6 Nov 2019 19:03:51 +0000 (UTC) To: "Ferriter, Cian" , David Marchand Cc: dev , dpdk stable , "Yigit, Ferruh" References: <20191001125315.6191-1-ktraynor@redhat.com> <20191001125315.6191-2-ktraynor@redhat.com> <63b80ce5-6847-7983-52eb-69836d20f191@redhat.com> <579B86492DFB364BBA627A48FB30C90E75E01B95@IRSMSX102.ger.corp.intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <8af40878-d916-adaf-af70-18aa9d32681d@redhat.com> Date: Wed, 6 Nov 2019 19:03:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <579B86492DFB364BBA627A48FB30C90E75E01B95@IRSMSX102.ger.corp.intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 8HQ9fA7sPR2zMVb9clXo8Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 05/11/2019 17:10, Ferriter, Cian wrote: >=20 >=20 >> -----Original Message----- >> From: Kevin Traynor >> Sent: Tuesday 5 November 2019 16:41 >> To: David Marchand >> Cc: dev ; Ferriter, Cian ; dpdk >> stable ; Yigit, Ferruh >> Subject: Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks >> >> On 30/10/2019 07:52, David Marchand wrote: >>> On Tue, Oct 1, 2019 at 2:54 PM Kevin Traynor >> wrote: >>>> >>>> Previously rx/tx_queues were passed into eth_from_pcaps_common() as >>>> ptrs and were checked for being NULL. >>>> >>>> In commit da6ba28f0540 ("net/pcap: use a struct to pass user >>>> options") that changed to pass in a ptr to a pmd_devargs_all which >>>> contains the rx/tx_queues. >>>> >>>> The parameter checking was not updated as part of that commit and >>>> coverity caught that there was still a check if rx/tx_queues were >>>> NULL, apparently after they had been dereferenced. >>>> >>>> Fix that by checking the pmd_devargs_all ptr and removing the NULL >>>> checks on rx/tx_queues. >>>> >>>> 1231 struct pmd_devargs *rx_queues =3D &devargs_all->rx_queues; >>>> 1232 struct pmd_devargs *tx_queues =3D &devargs_all->tx_queues; >>>> 1233 const unsigned int nb_rx_queues =3D rx_queues->num_of_queu= e; >>>> deref_ptr: Directly dereferencing pointer tx_queues. >>>> 1234 const unsigned int nb_tx_queues =3D tx_queues->num_of_queu= e; >>>> 1235 unsigned int i; >>>> 1236 >>>> 1237 /* do some parameter checking */ >>>> CID 345004: Dereference before null check (REVERSE_INULL) >>>> [select issue] >>>> 1238 if (rx_queues =3D=3D NULL && nb_rx_queues > 0) >>>> 1239 return -1; >>>> CID 345029 (#1 of 1): Dereference before null check (REVERSE_INULL= ) >>>> check_after_deref: Null-checking tx_queues suggests that it may be >>>> null, but it has already been dereferenced on all paths leading to >>>> the check. >>>> 1240 if (tx_queues =3D=3D NULL && nb_tx_queues > 0) >>>> 1241 return -1; >>>> >>>> Coverity issue: 345029 >>>> Coverity issue: 345044 >>>> Fixes: da6ba28f0540 ("net/pcap: use a struct to pass user options") >>>> Cc: cian.ferriter@intel.com >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Kevin Traynor >>> >>> This patch hides the coverity warning. >>> But can't we just remove those checks? >>> >>> Iiuc, the checks on NULL pointers are unnecessary since >>> >> https://git.dpdk.org/dpdk/commit/?id=3Da0fce1193ce13a50c00624cb36605ebe >> f7a3e60b. >>> >>> >> >> Aside from the Coverity complaint about rxq/txq NULL check after use, th= e >> checks didn't seem to make sense anymore as rxq/txq are part of devargs_= all >> struct now, so they were removed. >> >> I added the NULL check on devargs_all to avoid a NULL deference while >> getting them instead. The check isn't doing any harm, but looking at the >> current paths to this fn. can see devargs_all would not be NULL, so I'm = ok to >> remove it too. Cian/Ferruh, wdyt? >=20 > I'm OK to remove this. Looks like it's no longer necessary. Good find Dav= id! >=20 Thanks Cian, I kept your Ack for v2.