From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65C27A09E4 for ; Thu, 1 Apr 2021 13:27:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54A8E1410A2; Thu, 1 Apr 2021 13:27:43 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3D9434067B; Thu, 1 Apr 2021 13:27:40 +0200 (CEST) IronPort-SDR: sl+ZH9RZZOGvIwx892BqDyeqf3vV20pFZtx5BJSBh+16BZ1ghQiogLn3o1uxiNEgVdw5F/TUwI xcN7RjaHJz6w== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="277410549" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="277410549" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 04:27:39 -0700 IronPort-SDR: fn6TvD3sUtj/le5DGaJi7UlhTTVbDZCfYzR9vWSxZt56MOtQs0pKjGLo/4wTxuaBUG07cAIAMi TYdBhqIl3TcQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="596302042" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.250.93]) ([10.213.250.93]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 04:27:37 -0700 To: Nithin Dabilpuram Cc: David Marchand , David Christensen , Jerin Jacob Kollanukkaran , dev , dpdk stable References: <20201012081106.10610-1-ndabilpuram@marvell.com> <20210115073243.7025-1-ndabilpuram@marvell.com> <20210115073243.7025-2-ndabilpuram@marvell.com> From: "Burakov, Anatoly" Message-ID: <8b50eaf9-d4fc-6749-82f5-07c2ba45301b@intel.com> Date: Thu, 1 Apr 2021 12:27:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v8 1/3] vfio: revert changes for map contiguous areas in one go X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 05-Mar-21 3:50 PM, Nithin Dabilpuram wrote: > On Fri, Mar 05, 2021 at 01:54:34PM +0000, Burakov, Anatoly wrote: >> On 05-Mar-21 7:50 AM, David Marchand wrote: >>> On Fri, Jan 15, 2021 at 8:33 AM Nithin Dabilpuram >>> wrote: >>>> >>>> In order to save DMA entries limited by kernel both for externel >>>> memory and hugepage memory, an attempt was made to map physically >>>> contiguous memory in one go. This cannot be done as VFIO IOMMU type1 >>>> does not support partially unmapping a previously mapped memory >>>> region while Heap can request for multi page mapping and >>>> partial unmapping. >>>> Hence for going back to old method of mapping/unmapping at >>>> memseg granularity, this commit reverts >>>> commit d1c7c0cdf7ba ("vfio: map contiguous areas in one go") >>>> >>>> Also add documentation on what module parameter needs to be used >>>> to increase the per-container dma map limit for VFIO. >>>> >>>> Fixes: d1c7c0cdf7ba ("vfio: map contiguous areas in one go") >>>> Cc: anatoly.burakov@intel.com >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Nithin Dabilpuram >>>> Acked-by: Anatoly Burakov >>>> Acked-by: David Christensen >>> >>> There is a regression reported in bz: https://bugs.dpdk.org/show_bug.cgi?id=649 >>> >>> I assigned it to Anatoly for now. >>> Nithin, can you have a loo too? >>> >>> Thanks. >>> >>> >> >> I've responded on the bug tracker as well, but to repeat it here: this is >> not a regression, this is intended behavior. We cannot do anything about >> this. > > To add, for test case to pass, either limits have to be increased, or use "--mp-alloc=xmemhuge" > instead of "--mp-alloc=xmem" which is forcing system page size or reduce total mbuf count > to reduce page count. > Technically, one is not a replacement for the other, so the correct way to handle it is to increase the limits, not using xmemhuge. -- Thanks, Anatoly