From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, ramirose@gmail.com,
arybchenko@solarflare.com, ferruh.yigit@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits
Date: Fri, 22 Mar 2019 18:06:14 +0100 [thread overview]
Message-ID: <8de1b82d-29a8-10be-75b1-463c9d755c19@redhat.com> (raw)
In-Reply-To: <1553261824-1881-3-git-send-email-david.marchand@redhat.com>
On 3/22/19 2:37 PM, David Marchand wrote:
> fwd engine statistics are stored as unsigned int (32bits) and can wrap
> quite quickly.
> Example: sending 7mpps for 614s gives us 4298000000 packets =>
> 0x1002e4680 larger than 32bits.
>
> testpmd reports forwarding stats as:
> RX-packets: 3500381 TX-packets: 3500010 TX-dropped: 371
>
> While the port and accumulated stats are reported as 64bits:
> RX-packets: 4298467677 RX-dropped: 0 RX-total: 4298467677
> TX-packets: 4298467306 TX-dropped: 371 TX-total: 4298467677
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Changelog since v2:
> - split out of the previous patch with a dedicated commitlog
> - Cc'd stable
>
> ---
> app/test-pmd/testpmd.c | 51 +++++++++++++++++---------------------------------
> app/test-pmd/testpmd.h | 12 ++++++------
> 2 files changed, 23 insertions(+), 40 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
next prev parent reply other threads:[~2019-03-22 17:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1550158972-21895-1-git-send-email-david.marchand@redhat.com>
[not found] ` <1552318522-18777-1-git-send-email-david.marchand@redhat.com>
2019-03-11 15:35 ` [dpdk-stable] [PATCH v2 1/4] app/testpmd: remove unused fwd_ctx field David Marchand
2019-03-19 18:29 ` Ferruh Yigit
[not found] ` <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-20 13:49 ` Andrew Rybchenko
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-20 13:55 ` Andrew Rybchenko
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-20 13:58 ` Andrew Rybchenko
[not found] ` <1553261824-1881-1-git-send-email-david.marchand@redhat.com>
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-22 17:03 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 17:17 ` Maxime Coquelin
2019-03-22 17:23 ` David Marchand
2019-03-22 17:31 ` Andrew Rybchenko
2019-03-22 17:35 ` [dpdk-stable] " Andrew Rybchenko
2019-03-22 17:43 ` David Marchand
2019-03-23 19:12 ` David Marchand
2019-03-25 6:34 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-22 17:06 ` Maxime Coquelin [this message]
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-22 17:11 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
[not found] ` <1553503906-1508-1-git-send-email-david.marchand@redhat.com>
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-25 8:55 ` Andrew Rybchenko
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 3/4] app/testpmd: remove useless casts on statistics David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de1b82d-29a8-10be-75b1-463c9d755c19@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).