patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
@ 2021-03-17  8:23 Wei Huang
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Wei Huang @ 2021-03-17  8:23 UTC (permalink / raw)
  To: dev, rosen.xu, qi.z.zhang; +Cc: stable, tianfei.zhang, Wei Huang

Below coverity issues are fixed in this patch set.
367480, 367482

Wei Huang (2):
  raw/ifpga/base: use untained variable as argument
  raw/ifpga/base: add argument to use untained variable

 drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

-- 
2.29.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument
  2021-03-17  8:23 [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Wei Huang
@ 2021-03-17  8:23 ` Wei Huang
  2021-04-01  7:48   ` Zhang, Tianfei
                     ` (2 more replies)
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Wei Huang
  2021-04-01 12:17 ` [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Zhang, Qi Z
  2 siblings, 3 replies; 12+ messages in thread
From: Wei Huang @ 2021-03-17  8:23 UTC (permalink / raw)
  To: dev, rosen.xu, qi.z.zhang; +Cc: stable, tianfei.zhang, Wei Huang

In fme_spi_init(), passing tainted expression "fme->max10_dev"
to function "intel_max10_device_remove" has risk. Untainted
variable "max10" should be used.

Coverity issue: 367480
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")

Signed-off-by: Wei Huang <wei.huang@intel.com>
---
 drivers/raw/ifpga/base/ifpga_fme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
index 43c7b9c3dc..a63f90331f 100644
--- a/drivers/raw/ifpga/base/ifpga_fme.c
+++ b/drivers/raw/ifpga/base/ifpga_fme.c
@@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature *feature)
 	return ret;
 
 max10_fail:
-	intel_max10_device_remove(fme->max10_dev);
+	intel_max10_device_remove(max10);
 spi_fail:
 	altera_spi_release(spi_master);
 	return ret;
-- 
2.29.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable
  2021-03-17  8:23 [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Wei Huang
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
@ 2021-03-17  8:23 ` Wei Huang
  2021-04-01  7:48   ` Zhang, Tianfei
  2021-04-01  8:48   ` Xu, Rosen
  2021-04-01 12:17 ` [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Zhang, Qi Z
  2 siblings, 2 replies; 12+ messages in thread
From: Wei Huang @ 2021-03-17  8:23 UTC (permalink / raw)
  To: dev, rosen.xu, qi.z.zhang; +Cc: stable, tianfei.zhang, Wei Huang

In fme_nios_spi_init(), passing tainted expression "fme->max10_dev"
to function "fme_get_board_interface" has risk. Add new arguemnt in
function "fme_get_board_interface" to accept untainted variable.

Coverity issue: 367482
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")

Signed-off-by: Wei Huang <wei.huang@intel.com>
---
 drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
index a63f90331f..4edb9e09e1 100644
--- a/drivers/raw/ifpga/base/ifpga_fme.c
+++ b/drivers/raw/ifpga/base/ifpga_fme.c
@@ -857,7 +857,8 @@ static int board_type_to_info(u32 type,
 	return 0;
 }
 
-static int fme_get_board_interface(struct ifpga_fme_hw *fme)
+static int fme_get_board_interface(struct ifpga_fme_hw *fme,
+	struct intel_max10_device *max10_dev)
 {
 	struct fme_bitstream_id id;
 	struct ifpga_hw *hw;
@@ -911,15 +912,15 @@ static int fme_get_board_interface(struct ifpga_fme_hw *fme)
 			fme->board_info.nums_of_fvl,
 			fme->board_info.ports_per_fvl);
 
-	if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val))
+	if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val))
 		return -EINVAL;
 	fme->board_info.boot_page = val & 0x7;
 
-	if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val))
+	if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val))
 		return -EINVAL;
 	fme->board_info.max10_version = val;
 
-	if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val))
+	if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val))
 		return -EINVAL;
 	fme->board_info.nios_fw_version = val;
 
@@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature)
 
 	max10->bus = hw->pci_data->bus;
 
-	fme_get_board_interface(fme);
+	fme_get_board_interface(fme, max10);
 
 	mgr->sensor_list = &max10->opae_sensor_list;
 
@@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature)
 	return ret;
 
 spi_fail:
-	intel_max10_device_remove(fme->max10_dev);
+	intel_max10_device_remove(max10);
 release_dev:
 	altera_spi_release(spi_master);
 	return -ENODEV;
-- 
2.29.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
@ 2021-04-01  7:48   ` Zhang, Tianfei
  2021-04-01  8:48   ` Xu, Rosen
  2021-04-07 14:57   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  2 siblings, 0 replies; 12+ messages in thread
From: Zhang, Tianfei @ 2021-04-01  7:48 UTC (permalink / raw)
  To: Huang, Wei, dev, Xu, Rosen, Zhang, Qi Z; +Cc: stable



> -----Original Message-----
> From: Huang, Wei <wei.huang@intel.com>
> Sent: 2021年3月17日 16:24
> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Subject: [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument
> 
> In fme_spi_init(), passing tainted expression "fme->max10_dev"
> to function "intel_max10_device_remove" has risk. Untainted variable
> "max10" should be used.
> 
> Coverity issue: 367480
> Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
> 
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> ---
>  drivers/raw/ifpga/base/ifpga_fme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga/base/ifpga_fme.c
> b/drivers/raw/ifpga/base/ifpga_fme.c
> index 43c7b9c3dc..a63f90331f 100644
> --- a/drivers/raw/ifpga/base/ifpga_fme.c
> +++ b/drivers/raw/ifpga/base/ifpga_fme.c
> @@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature
> *feature)
>  	return ret;
> 
>  max10_fail:
> -	intel_max10_device_remove(fme->max10_dev);
> +	intel_max10_device_remove(max10);
>  spi_fail:
>  	altera_spi_release(spi_master);
>  	return ret;
> --
Acked-by: Tianfei zhang <Tianfei.zhang@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Wei Huang
@ 2021-04-01  7:48   ` Zhang, Tianfei
  2021-04-01  8:48   ` Xu, Rosen
  1 sibling, 0 replies; 12+ messages in thread
From: Zhang, Tianfei @ 2021-04-01  7:48 UTC (permalink / raw)
  To: Huang, Wei, dev, Xu, Rosen, Zhang, Qi Z; +Cc: stable



> -----Original Message-----
> From: Huang, Wei <wei.huang@intel.com>
> Sent: 2021年3月17日 16:24
> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Subject: [PATCH v1 2/2] raw/ifpga/base: add argument to use untained
> variable
> 
> In fme_nios_spi_init(), passing tainted expression "fme->max10_dev"
> to function "fme_get_board_interface" has risk. Add new arguemnt in
> function "fme_get_board_interface" to accept untainted variable.
> 
> Coverity issue: 367482
> Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
> 
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> ---
>  drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/raw/ifpga/base/ifpga_fme.c
> b/drivers/raw/ifpga/base/ifpga_fme.c
> index a63f90331f..4edb9e09e1 100644
> --- a/drivers/raw/ifpga/base/ifpga_fme.c
> +++ b/drivers/raw/ifpga/base/ifpga_fme.c
> @@ -857,7 +857,8 @@ static int board_type_to_info(u32 type,
>  	return 0;
>  }
> 
> -static int fme_get_board_interface(struct ifpga_fme_hw *fme)
> +static int fme_get_board_interface(struct ifpga_fme_hw *fme,
> +	struct intel_max10_device *max10_dev)
>  {
>  	struct fme_bitstream_id id;
>  	struct ifpga_hw *hw;
> @@ -911,15 +912,15 @@ static int fme_get_board_interface(struct
> ifpga_fme_hw *fme)
>  			fme->board_info.nums_of_fvl,
>  			fme->board_info.ports_per_fvl);
> 
> -	if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val))
> +	if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val))
>  		return -EINVAL;
>  	fme->board_info.boot_page = val & 0x7;
> 
> -	if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val))
> +	if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val))
>  		return -EINVAL;
>  	fme->board_info.max10_version = val;
> 
> -	if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val))
> +	if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val))
>  		return -EINVAL;
>  	fme->board_info.nios_fw_version = val;
> 
> @@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature
> *feature)
> 
>  	max10->bus = hw->pci_data->bus;
> 
> -	fme_get_board_interface(fme);
> +	fme_get_board_interface(fme, max10);
> 
>  	mgr->sensor_list = &max10->opae_sensor_list;
> 
> @@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature
> *feature)
>  	return ret;
> 
>  spi_fail:
> -	intel_max10_device_remove(fme->max10_dev);
> +	intel_max10_device_remove(max10);
>  release_dev:
>  	altera_spi_release(spi_master);
>  	return -ENODEV;
> --
Acked-by: Tianfei zhang <Tianfei.zhang@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
  2021-04-01  7:48   ` Zhang, Tianfei
@ 2021-04-01  8:48   ` Xu, Rosen
  2021-04-07 14:57   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  2 siblings, 0 replies; 12+ messages in thread
From: Xu, Rosen @ 2021-04-01  8:48 UTC (permalink / raw)
  To: Huang, Wei, dev, Zhang, Qi Z; +Cc: stable, Zhang, Tianfei

Hi,

-----Original Message-----
From: Huang, Wei <wei.huang@intel.com> 
Sent: Wednesday, March 17, 2021 4:24 PM
To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei <wei.huang@intel.com>
Subject: [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument

In fme_spi_init(), passing tainted expression "fme->max10_dev"
to function "intel_max10_device_remove" has risk. Untainted variable "max10" should be used.

Coverity issue: 367480
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")

Signed-off-by: Wei Huang <wei.huang@intel.com>
---
 drivers/raw/ifpga/base/ifpga_fme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
index 43c7b9c3dc..a63f90331f 100644
--- a/drivers/raw/ifpga/base/ifpga_fme.c
+++ b/drivers/raw/ifpga/base/ifpga_fme.c
@@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature *feature)
 	return ret;
 
 max10_fail:
-	intel_max10_device_remove(fme->max10_dev);
+	intel_max10_device_remove(max10);
 spi_fail:
 	altera_spi_release(spi_master);
 	return ret;
--
2.29.2

Acked-by: Rosen Xu <rosen.xu@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Wei Huang
  2021-04-01  7:48   ` Zhang, Tianfei
@ 2021-04-01  8:48   ` Xu, Rosen
  1 sibling, 0 replies; 12+ messages in thread
From: Xu, Rosen @ 2021-04-01  8:48 UTC (permalink / raw)
  To: Huang, Wei, dev, Zhang, Qi Z; +Cc: stable, Zhang, Tianfei

Hi,

-----Original Message-----
From: Huang, Wei <wei.huang@intel.com> 
Sent: Wednesday, March 17, 2021 4:24 PM
To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei <wei.huang@intel.com>
Subject: [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable

In fme_nios_spi_init(), passing tainted expression "fme->max10_dev"
to function "fme_get_board_interface" has risk. Add new arguemnt in function "fme_get_board_interface" to accept untainted variable.

Coverity issue: 367482
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")

Signed-off-by: Wei Huang <wei.huang@intel.com>
---
 drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
index a63f90331f..4edb9e09e1 100644
--- a/drivers/raw/ifpga/base/ifpga_fme.c
+++ b/drivers/raw/ifpga/base/ifpga_fme.c
@@ -857,7 +857,8 @@ static int board_type_to_info(u32 type,
 	return 0;
 }
 
-static int fme_get_board_interface(struct ifpga_fme_hw *fme)
+static int fme_get_board_interface(struct ifpga_fme_hw *fme,
+	struct intel_max10_device *max10_dev)
 {
 	struct fme_bitstream_id id;
 	struct ifpga_hw *hw;
@@ -911,15 +912,15 @@ static int fme_get_board_interface(struct ifpga_fme_hw *fme)
 			fme->board_info.nums_of_fvl,
 			fme->board_info.ports_per_fvl);
 
-	if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val))
+	if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val))
 		return -EINVAL;
 	fme->board_info.boot_page = val & 0x7;
 
-	if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val))
+	if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val))
 		return -EINVAL;
 	fme->board_info.max10_version = val;
 
-	if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val))
+	if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val))
 		return -EINVAL;
 	fme->board_info.nios_fw_version = val;
 
@@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature)
 
 	max10->bus = hw->pci_data->bus;
 
-	fme_get_board_interface(fme);
+	fme_get_board_interface(fme, max10);
 
 	mgr->sensor_list = &max10->opae_sensor_list;
 
@@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature)
 	return ret;
 
 spi_fail:
-	intel_max10_device_remove(fme->max10_dev);
+	intel_max10_device_remove(max10);
 release_dev:
 	altera_spi_release(spi_master);
 	return -ENODEV;
--
2.29.2

Acked-by: Rosen Xu <rosen.xu@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
  2021-03-17  8:23 [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Wei Huang
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Wei Huang
@ 2021-04-01 12:17 ` Zhang, Qi Z
  2021-04-20  8:09   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  2 siblings, 1 reply; 12+ messages in thread
From: Zhang, Qi Z @ 2021-04-01 12:17 UTC (permalink / raw)
  To: Huang, Wei, dev, Xu, Rosen; +Cc: stable, Zhang, Tianfei



> -----Original Message-----
> From: Huang, Wei <wei.huang@intel.com>
> Sent: Wednesday, March 17, 2021 4:24 PM
> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
> <wei.huang@intel.com>
> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
> 
> Below coverity issues are fixed in this patch set.
> 367480, 367482
> 
> Wei Huang (2):
>   raw/ifpga/base: use untained variable as argument
>   raw/ifpga/base: add argument to use untained variable
> 
>  drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> --
> 2.29.2

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument
  2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
  2021-04-01  7:48   ` Zhang, Tianfei
  2021-04-01  8:48   ` Xu, Rosen
@ 2021-04-07 14:57   ` Ferruh Yigit
  2 siblings, 0 replies; 12+ messages in thread
From: Ferruh Yigit @ 2021-04-07 14:57 UTC (permalink / raw)
  To: Wei Huang, dev, rosen.xu, qi.z.zhang; +Cc: stable, tianfei.zhang

On 3/17/2021 8:23 AM, Wei Huang wrote:
> In fme_spi_init(), passing tainted expression "fme->max10_dev"
> to function "intel_max10_device_remove" has risk. Untainted
> variable "max10" should be used.
> 
> Coverity issue: 367480
> Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
> 

Following is from the coverity:
2. tainted_return_value: Function intel_max10_device_probe returns tainted data.
3. var_assign: Assigning: max10 = intel_max10_device_probe(spi_master, 0), which 
taints max10
5. var_assign_var: Assigning: fme->max10_dev = max10. Both are now tainted.


'max10' is tainted at first place, and 'fme->max10_dev' is tainted because of 
'max10'. In this case how replacing 'fme->max10_dev' with 'max10' helps?

Did you verified that change is fixing the coverity issue?


And as the previous one, what is the exact problem, what is tainted data and how 
it is a problem, can you please describe?

> Signed-off-by: Wei Huang <wei.huang@intel.com>
> ---
>   drivers/raw/ifpga/base/ifpga_fme.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
> index 43c7b9c3dc..a63f90331f 100644
> --- a/drivers/raw/ifpga/base/ifpga_fme.c
> +++ b/drivers/raw/ifpga/base/ifpga_fme.c
> @@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature *feature)
>   	return ret;
>   
>   max10_fail:
> -	intel_max10_device_remove(fme->max10_dev);
> +	intel_max10_device_remove(max10);
>   spi_fail:
>   	altera_spi_release(spi_master);
>   	return ret;
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
  2021-04-01 12:17 ` [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Zhang, Qi Z
@ 2021-04-20  8:09   ` Ferruh Yigit
  2021-04-20  9:12     ` Zhang, Qi Z
  0 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2021-04-20  8:09 UTC (permalink / raw)
  To: Zhang, Qi Z, Huang, Wei, dev, Xu, Rosen; +Cc: stable, Zhang, Tianfei

On 4/1/2021 1:17 PM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Huang, Wei <wei.huang@intel.com>
>> Sent: Wednesday, March 17, 2021 4:24 PM
>> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang, Wei
>> <wei.huang@intel.com>
>> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
>>
>> Below coverity issues are fixed in this patch set.
>> 367480, 367482
>>
>> Wei Huang (2):
>>    raw/ifpga/base: use untained variable as argument
>>    raw/ifpga/base: add argument to use untained variable
>>
>>   drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
>>   1 file changed, 8 insertions(+), 7 deletions(-)
>>
>> --
>> 2.29.2
> 
> Applied to dpdk-next-net-intel.
> 

Hi Qi,

What is the status of this set?
It is not merged to your tree, and its patchwork status is 'Rejected'.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
  2021-04-20  8:09   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
@ 2021-04-20  9:12     ` Zhang, Qi Z
  2021-04-20  9:29       ` Zhang, Qi Z
  0 siblings, 1 reply; 12+ messages in thread
From: Zhang, Qi Z @ 2021-04-20  9:12 UTC (permalink / raw)
  To: Yigit, Ferruh, Huang, Wei, dev, Xu, Rosen; +Cc: stable, Zhang, Tianfei



> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, April 20, 2021 4:10 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Huang, Wei <wei.huang@intel.com>;
> dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in
> DPDK-26381
> 
> On 4/1/2021 1:17 PM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Huang, Wei <wei.huang@intel.com>
> >> Sent: Wednesday, March 17, 2021 4:24 PM
> >> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> >> <qi.z.zhang@intel.com>
> >> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>; Huang,
> >> Wei <wei.huang@intel.com>
> >> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
> >>
> >> Below coverity issues are fixed in this patch set.
> >> 367480, 367482
> >>
> >> Wei Huang (2):
> >>    raw/ifpga/base: use untained variable as argument
> >>    raw/ifpga/base: add argument to use untained variable
> >>
> >>   drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
> >>   1 file changed, 8 insertions(+), 7 deletions(-)
> >>
> >> --
> >> 2.29.2
> >
> > Applied to dpdk-next-net-intel.
> >
> 
> Hi Qi,
> 
> What is the status of this set?
> It is not merged to your tree, and its patchwork status is 'Rejected'.

I think the status is wrong updated, and the patches are just dropped after re-sync with next-net, thanks for capture this.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
  2021-04-20  9:12     ` Zhang, Qi Z
@ 2021-04-20  9:29       ` Zhang, Qi Z
  0 siblings, 0 replies; 12+ messages in thread
From: Zhang, Qi Z @ 2021-04-20  9:29 UTC (permalink / raw)
  To: Yigit, Ferruh, Huang, Wei, dev, Xu, Rosen; +Cc: stable, Zhang, Tianfei



> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, April 20, 2021 5:13 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Huang, Wei
> <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in
> DPDK-26381
> 
> 
> 
> > -----Original Message-----
> > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > Sent: Tuesday, April 20, 2021 4:10 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Huang, Wei
> > <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> > Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in
> > DPDK-26381
> >
> > On 4/1/2021 1:17 PM, Zhang, Qi Z wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Huang, Wei <wei.huang@intel.com>
> > >> Sent: Wednesday, March 17, 2021 4:24 PM
> > >> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> > >> <qi.z.zhang@intel.com>
> > >> Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>;
> > >> Huang, Wei <wei.huang@intel.com>
> > >> Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381
> > >>
> > >> Below coverity issues are fixed in this patch set.
> > >> 367480, 367482
> > >>
> > >> Wei Huang (2):
> > >>    raw/ifpga/base: use untained variable as argument
> > >>    raw/ifpga/base: add argument to use untained variable
> > >>
> > >>   drivers/raw/ifpga/base/ifpga_fme.c | 15 ++++++++-------
> > >>   1 file changed, 8 insertions(+), 7 deletions(-)
> > >>
> > >> --
> > >> 2.29.2
> > >
> > > Applied to dpdk-next-net-intel.
> > >
> >
> > Hi Qi,
> >
> > What is the status of this set?
> > It is not merged to your tree, and its patchwork status is 'Rejected'.
> 
> I think the status is wrong updated, and the patches are just dropped after
> re-sync with next-net, thanks for capture this.

OK, the patch set should be rejected, as they already be covered by below patch. 
http://patchwork.dpdk.org/project/dpdk/patch/20210408085151.54996-2-wei.huang@intel.com/
So there is no miss operation in path work, just can't remember what happened :)

We are OK now.



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-04-20  9:29 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17  8:23 [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Wei Huang
2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Wei Huang
2021-04-01  7:48   ` Zhang, Tianfei
2021-04-01  8:48   ` Xu, Rosen
2021-04-07 14:57   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-03-17  8:23 ` [dpdk-stable] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Wei Huang
2021-04-01  7:48   ` Zhang, Tianfei
2021-04-01  8:48   ` Xu, Rosen
2021-04-01 12:17 ` [dpdk-stable] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Zhang, Qi Z
2021-04-20  8:09   ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-04-20  9:12     ` Zhang, Qi Z
2021-04-20  9:29       ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git