patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Kadam, Pallavi" <>
To: Dmitry Kozlyuk <>,
Cc:, Khoa To <>,
	Tal Shnaiderman <>,
	Narcisa Ana Maria Vasile <>,
	Dmitry Malloy <>
Subject: Re: [dpdk-stable] [PATCH] eal/windows: use bundled getopt with MinGW
Date: Mon, 28 Sep 2020 12:53:51 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/24/2020 4:17 PM, Dmitry Kozlyuk wrote:
> Clang builds use getopt.c in librte_eal while MinGW provides
> implementation as part of the toolchain. Statically linking librte_eal
> to an application that depends on getopt results in undefined reference
> errors with MinGW. There are no such errors with Clang, because with
> Clang librte_eal actually defines getopt functions.
> Use getopt.c in EAL with Clang and MinGW to get identical behavior.
> Adjust code for MinGW. Incidentally, this removes a bug when free() is
> called on uninitialized memory.
> Fixes: 5e373e456e6 ("eal/windows: add getopt implementation")
> Cc:
> Signed-off-by: Dmitry Kozlyuk <>
> Reported-by: Khoa To <>
> Reported-by: Tal Shnaiderman <>
Acked-by: Pallavi Kadam < 

      parent reply	other threads:[~2020-09-28 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 23:17 Dmitry Kozlyuk
2020-09-26  1:23 ` [dpdk-stable] [EXTERNAL] " Khoa To
2020-10-05  7:23   ` Thomas Monjalon
2020-09-28 19:53 ` Kadam, Pallavi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).