Re: [dpdk-stable] [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

Re: [dpdk-stable] [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

[Kevin Traynor]

On 06/29/2018 10:29 AM, John Daley wrote:
> Updated a few commits in the patchset per suggestions by Ferrus Yigit.
> thanks,
> John
> 
> Hyong Youb Kim (12):
>   net/enic: fix receive packet types
>   net/enic: update the UDP RSS detection mechanism
>   net/enic: do not overwrite admin Tx queue limit
>   net/enic: initialize RQ fetch index before enabling RQ
>   net/enic: report ring limits and preferred default values
>   net/enic: add devarg to specify ingress VLAN rewrite mode
>   net/enic: add handlers to add/delete vxlan port number
>   net/enic: use mbuf pointer array for inflight Tx packets
>   net/enic: support mbuf fast free offload
>   net/enic: reduce Tx completion updates
>   net/enic: add the simple version of Tx handler
>   net/enic: check maximum packet size in Tx prepare handler
> 
> John Daley (3):
>   net/enic: add simple Rx handler
>   net/enic: cap Rx packet processing to end of desc ring
>   doc: update release notes with new enic features
> 

Hi John, seems like many of these would be candidates for stable branches?

>  doc/guides/nics/enic.rst               |  15 +-
>  doc/guides/nics/features/enic.ini      |   1 +
>  doc/guides/rel_notes/release_18_08.rst |   8 +
>  drivers/net/enic/base/cq_desc.h        |   1 +
>  drivers/net/enic/base/vnic_dev.c       |  16 ++
>  drivers/net/enic/base/vnic_dev.h       |   4 +
>  drivers/net/enic/base/vnic_devcmd.h    |  23 ++-
>  drivers/net/enic/base/vnic_enet.h      |   5 +-
>  drivers/net/enic/base/vnic_nic.h       |   4 +-
>  drivers/net/enic/base/vnic_rq.h        |   2 +
>  drivers/net/enic/base/vnic_wq.c        |   9 +-
>  drivers/net/enic/base/vnic_wq.h        |  12 +-
>  drivers/net/enic/enic.h                |  12 ++
>  drivers/net/enic/enic_compat.h         |   5 +
>  drivers/net/enic/enic_ethdev.c         | 168 +++++++++++++++--
>  drivers/net/enic/enic_main.c           | 125 ++++++++++---
>  drivers/net/enic/enic_res.c            |  13 +-
>  drivers/net/enic/enic_res.h            |  16 ++
>  drivers/net/enic/enic_rxtx.c           | 333 +++++++++++++++++++++++++++++----
>  19 files changed, 668 insertions(+), 104 deletions(-)
> 

Re: [dpdk-stable] [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

[John Daley (johndale)]

Hi Kevin,
Inline.
-john

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, July 25, 2018 11:37 AM
> To: John Daley (johndale) <johndale@cisco.com>; ferruh.yigit@intel.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance
> improvements
> 
> On 06/29/2018 10:29 AM, John Daley wrote:
> > Updated a few commits in the patchset per suggestions by Ferrus Yigit.
> > thanks,
> > John
> >
> > Hyong Youb Kim (12):
> >   net/enic: fix receive packet types
> >   net/enic: update the UDP RSS detection mechanism
> >   net/enic: do not overwrite admin Tx queue limit
> >   net/enic: initialize RQ fetch index before enabling RQ
> >   net/enic: report ring limits and preferred default values
> >   net/enic: add devarg to specify ingress VLAN rewrite mode
> >   net/enic: add handlers to add/delete vxlan port number
> >   net/enic: use mbuf pointer array for inflight Tx packets
> >   net/enic: support mbuf fast free offload
> >   net/enic: reduce Tx completion updates
> >   net/enic: add the simple version of Tx handler
> >   net/enic: check maximum packet size in Tx prepare handler
> >
> > John Daley (3):
> >   net/enic: add simple Rx handler
> >   net/enic: cap Rx packet processing to end of desc ring
> >   doc: update release notes with new enic features
> >
> 
> Hi John, seems like many of these would be candidates for stable branches?

Yes, a few of them. We will backport, test and submit to the stable branches as soon as we are done with 18.08 testing.
Thanks,
John

> 
> >  doc/guides/nics/enic.rst               |  15 +-
> >  doc/guides/nics/features/enic.ini      |   1 +
> >  doc/guides/rel_notes/release_18_08.rst |   8 +
> >  drivers/net/enic/base/cq_desc.h        |   1 +
> >  drivers/net/enic/base/vnic_dev.c       |  16 ++
> >  drivers/net/enic/base/vnic_dev.h       |   4 +
> >  drivers/net/enic/base/vnic_devcmd.h    |  23 ++-
> >  drivers/net/enic/base/vnic_enet.h      |   5 +-
> >  drivers/net/enic/base/vnic_nic.h       |   4 +-
> >  drivers/net/enic/base/vnic_rq.h        |   2 +
> >  drivers/net/enic/base/vnic_wq.c        |   9 +-
> >  drivers/net/enic/base/vnic_wq.h        |  12 +-
> >  drivers/net/enic/enic.h                |  12 ++
> >  drivers/net/enic/enic_compat.h         |   5 +
> >  drivers/net/enic/enic_ethdev.c         | 168 +++++++++++++++--
> >  drivers/net/enic/enic_main.c           | 125 ++++++++++---
> >  drivers/net/enic/enic_res.c            |  13 +-
> >  drivers/net/enic/enic_res.h            |  16 ++
> >  drivers/net/enic/enic_rxtx.c           | 333 +++++++++++++++++++++++++++++---
> -
> >  19 files changed, 668 insertions(+), 104 deletions(-)
> >