From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23A9B4586B for ; Mon, 26 Aug 2024 13:17:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CB98402A7; Mon, 26 Aug 2024 13:17:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2697140272 for ; Mon, 26 Aug 2024 13:17:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724671065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mwuvZG60QX69Xgd8t7evM0CsIvI7/isYwd3cZGBbvF0=; b=VSkU++JlpmmWX5YcgPN/anGZvO4UlYTpR9GEdlzdaP0KGRzJj1ViRY+ItLkAID9HNZWeIc X+AD88JxLeNa5r4kRzmzbDveAySEE8CimBW9S1oXhJzPssFtkNbSqaTiq4IQxmUjAQ878O 6YpL9YXDHI25GPjhSBftUQzcpWOZun4= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-sKP29V2kMzm-aWcXEAcsIg-1; Mon, 26 Aug 2024 07:17:44 -0400 X-MC-Unique: sKP29V2kMzm-aWcXEAcsIg-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5bee990ad19so6121120a12.0 for ; Mon, 26 Aug 2024 04:17:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724671063; x=1725275863; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mwuvZG60QX69Xgd8t7evM0CsIvI7/isYwd3cZGBbvF0=; b=djaGLgfuQT+WAdmqIfhyXZt4yQ9/j3g32WFjfMduJuzWzlAbuDa+6g8lF2N4xuCZun v9+V+StAd4Q30JIk+mPh3qGcNNBGDLHZsAl90QAWNq25z4Kls0DqvIfGpsHJ0iCraOHG n5+ZaQNAUTmViCS4UHWkk9xv+m59Y5uYRIUQZjGwhi9NxGk+lUkV6ayNxAqrXRm4eyDx ff7rhY8S1HxxVvqM60uLHWUSU+Vm5FXIwZttXBPQca+mtLZivMiCG00Y/7CdAYDpnJvN NxDf1vVESiToanrN80Ak8/n5ndAS1pEgu+uDruqVpKPvaHivcMP/jhLAy+bUrOfY8eMw 3O1A== X-Gm-Message-State: AOJu0Yyx5jmDPSXTXpV29jVUwIi6yOxFNdpF1jWzpgWRPHhIaqVmE73U 7pliOSHvshVjZL0A3scNCrmxZ8Ur175+9i1s+bGek2ZDlw75ESZvOXfOlj4aYk+pmnTMd5rNSVo nHVfqYdQhC0T/MHRW9MYITKvwQ7SLtJlRmgXzwBXnpJDrmrWqLbyu X-Received: by 2002:a05:6402:34c8:b0:5be:ec0a:c10f with SMTP id 4fb4d7f45d1cf-5bf2bdbeb03mr13204840a12.2.1724671062846; Mon, 26 Aug 2024 04:17:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IES03t0wAfjSR3ftbucSZFHDg2647pdu77Oxv5e9gAY2zE7hwf7Z8/KPJGPcuA1ri4wSMZDPQ== X-Received: by 2002:a05:6402:34c8:b0:5be:ec0a:c10f with SMTP id 4fb4d7f45d1cf-5bf2bdbeb03mr13204820a12.2.1724671062305; Mon, 26 Aug 2024 04:17:42 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.36]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3c9dcesm5552213a12.30.2024.08.26.04.17.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 04:17:41 -0700 (PDT) Message-ID: <908f1df9-7f08-40b6-bdf9-ed72e32c4bff@redhat.com> Date: Mon, 26 Aug 2024 12:17:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: patch 'net/ena: fix bad checksum handling' has been queued to stable release 21.11.8 To: "Brandes, Shai" Cc: dpdk stable References: <20240823161929.1004778-1-ktraynor@redhat.com> <20240823161929.1004778-109-ktraynor@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 26/08/2024 11:26, Brandes, Shai wrote: > Hi Kevin, > Hi Shai, > I think there is one net/ena patch that was not picked up for the stable release (likely since there are two patches with similar title). > I would appreciate if you could verify. > > The missing patch: net/ena: fix wrong handling of checksum > see patchwork https://patches.dpdk.org/project/dpdk/patch/20240702144626.14545-14-shaibran@amazon.com/ > Thanks for checking! It wasn't listed as relevant for 21.11 LTS as the 'Fixes:' tag indicates it is fixing a feature introduced after 21.11. commit f66055c7564050e55c7eab147d039bf01048829a Author: Shai Brandes Date: Tue Jul 2 17:46:24 2024 +0300 net/ena: fix checksum handling This change fixes an issue where a non tcp/udp packet can be indicated to have an invalid csum. If the device erroneously tries to verify the csum on a non tcp/udp packet it will result in false indication that there is a csum error. This change make the driver ignore the indication for csum error on such packets. Fixes: 84daba9962b5 ("net/ena: add extra Rx checksum related xstats") Cc: stable@dpdk.org Signed-off-by: Shai Brandes $ git tag --contains 84daba9962b5 v22.03 ... If you believe the Fixes: tag is incorrect and it should go to 21.11 branch, let me know (though I see it doesn't apply cleanly). thanks, Kevin. > All the best, > Shai Brandes > ENA drivers team > >> -----Original Message----- >> From: Kevin Traynor >> Sent: Friday, August 23, 2024 7:19 PM >> To: Brandes, Shai >> Cc: dpdk stable >> Subject: [EXTERNAL] patch 'net/ena: fix bad checksum handling' has been >> queued to stable release 21.11.8 >> >> CAUTION: This email originated from outside of the organization. Do not click >> links or open attachments unless you can confirm the sender and know the >> content is safe. >> >> >> >> Hi, >> >> FYI, your patch has been queued to stable release 21.11.8 >> >> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. >> It will be pushed if I get no objections before 08/28/24. So please shout if >> anyone has objections. >> >> Also note that after the patch there's a diff of the upstream commit vs the >> patch applied to the branch. This will indicate if there was any rebasing >> needed to apply to the stable branch. If there were code changes for >> rebasing >> (ie: not only metadata diffs), please double check that the rebase was >> correctly done. >> >> Queued patches are on a temporary branch at: >> https://github.com/kevintraynor/dpdk-stable >> >> This queued commit can be viewed at: >> https://github.com/kevintraynor/dpdk- >> stable/commit/082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f >> >> Thanks. >> >> Kevin >> >> --- >> From 082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Mon Sep 17 00:00:00 >> 2001 >> From: Shai Brandes >> Date: Tue, 2 Jul 2024 17:46:22 +0300 >> Subject: [PATCH] net/ena: fix bad checksum handling >> >> [ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] >> >> Removed a workaround for a false L4 bad Rx csum indication from the >> device. The workaround was to set it as unknown so the application would >> check it instead. >> The issue was fixed in the device, thus the driver bad csum handling should >> be fixed in the PMD. >> >> Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4") >> >> Signed-off-by: Shai Brandes >> --- >> drivers/net/ena/ena_ethdev.c | 8 +------- >> 1 file changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c >> index 1c61f793e6..84c41f1b9d 100644 >> --- a/drivers/net/ena/ena_ethdev.c >> +++ b/drivers/net/ena/ena_ethdev.c >> @@ -311,11 +311,5 @@ static inline void ena_rx_mbuf_prepare(struct >> rte_mbuf *mbuf, >> else >> if (unlikely(ena_rx_ctx->l4_csum_err)) >> - /* >> - * For the L4 Rx checksum offload the HW may indicate >> - * bad checksum although it's valid. Because of that, >> - * we're setting the UNKNOWN flag to let the app >> - * re-verify the checksum. >> - */ >> - ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; >> + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; >> else >> ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; >> -- >> 2.46.0 >> >> --- >> Diff of the applied patch vs upstream commit (please double-check if non- >> empty: >> --- >> --- - 2024-08-23 17:18:12.913173354 +0100 >> +++ 0109-net-ena-fix-bad-checksum-handling.patch 2024-08-23 >> 17:18:09.849430556 +0100 >> @@ -1 +1 @@ >> -From fa4bb7025255036fcff9556c637efa2627ac4af4 Mon Sep 17 00:00:00 2001 >> +From 082bd6be7b93ae090f2bdcc55fddc48c3bf16c2f Mon Sep 17 00:00:00 >> 2001 >> @@ -5,0 +6,2 @@ >> +[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] >> + >> @@ -13 +14,0 @@ >> -Cc: stable@dpdk.org >> @@ -21 +22 @@ >> -index 4e7171e629..b43b913903 100644 >> +index 1c61f793e6..84c41f1b9d 100644 >> @@ -24,3 +25,3 @@ >> -@@ -675,11 +675,5 @@ static inline void ena_rx_mbuf_prepare(struct >> ena_ring *rx_ring, >> - if (unlikely(ena_rx_ctx->l4_csum_err)) { >> - ++rx_stats->l4_csum_bad; >> +@@ -311,11 +311,5 @@ static inline void ena_rx_mbuf_prepare(struct >> rte_mbuf *mbuf, >> + else >> + if (unlikely(ena_rx_ctx->l4_csum_err)) >> @@ -35,2 +36,2 @@ >> - } else { >> - ++rx_stats->l4_csum_good; >> + else >> + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; >