From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150080.outbound.protection.outlook.com [40.107.15.80]) by dpdk.org (Postfix) with ESMTP id 7BB9F1B94A for ; Thu, 20 Dec 2018 01:18:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pRLjvSml4XqVckkJR6q/VnpijDP1WzIGfbjFMiez/ig=; b=qzzO7HqpL7/3d//72hhf0zFplSa8GWDE9y+iY0X8Unu2Com1f4irvjVQxqceckToQxWLcw/8sfBZHUgx+Q3+sxggFuN2QR2cUFFJgIh5pZAJJAPublUfIjZ+ydAv8HtFe9T7jfdmDbano2e4vPGc0S5JFZ5q6EpnOCVmFnl5uXs= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4010.eurprd05.prod.outlook.com (52.134.66.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.22; Thu, 20 Dec 2018 00:18:35 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d43a:3775:8af7:29c6]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d43a:3775:8af7:29c6%3]) with mapi id 15.20.1425.025; Thu, 20 Dec 2018 00:18:35 +0000 From: Yongseok Koh To: Jeff Guo CC: Ferruh Yigit , dpdk stable Thread-Topic: [dpdk-stable] patch 'igb_uio: fix unexpected removal for hot-unplug' has been queued to LTS release 17.11.5 Thread-Index: AQHUiDlKcd9Srpr5fEWdEFz/gxmd7aWG4qMA Date: Thu, 20 Dec 2018 00:18:35 +0000 Message-ID: <913A0707-5366-4D66-A8C5-2C1B19AD504D@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> <20181129231202.30436-69-yskoh@mellanox.com> In-Reply-To: <20181129231202.30436-69-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4010; 6:y/MQ0D5frKrZG4J5aKglr3u6WqQjXTjkcauRqAQYqZ1UNo8okHA8E4pp387OFAD44LOKiGGRs6BDQDcXxcGQWONeTnn74vXw9umDKxNtj54mTrjwt5wIcsls+UmeLUQoEgqaU/ixai7FieiYP75GCshj23Xd//UMcAa+wU7cHzfR2b2SY4is+fgwfSNysZ9cFIeVfWxAMVc4njVtPR00jNEJhbpDB+hFeXwuUVAnIgZcPA2CR+T5ShmCUdMVZcVxN9wZRd9km1P7QZbHf7m9GtTEiqPa777m8/acBWwiWFvY4qvkdCfMd9QjPuXu3n/wRaPVCngNS7N9Ozrd2EU+GkbWwRu08zIcFkGMnasmtT5qfM484BuX86U1dbECVmqp2fDoeUC2ifageye+6Vn9ZjDVZTdodRsdQ4pOOqkoxyqHo5TpooQLFS2wikusLcZJJLtw/FOru3HKWDqNZvQugA==; 5:9PmT2iY12yDIhfhLAK7sn2d5SSz5oc0+8BJVzBxRwzL8fl1dtroWS7Agjv+hdF7FSTUJgMZ86wBNoD93ZNFICQ2N+rUyKaP/18sho+vX7VLLYmRbRh/mK3HDsK7FnhFDrpSqDcgv8e0lhEpsrjtf7U5WVH9rk3Ei4LYuAF/suCM=; 7:u0q7nBBkZ1dqtbVneXxckGwWYUG2a3PB9+ubkfYfefMovnLCvce/76We3tInwV5I0hUO0JMATy7dkXXDZL4cR1DUPETtvuFB8iCKcTAX/VZA4ygIXxxH0Z0W9zDsUCFbb5mhvnuRYnaGe8tShb94sA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e8607ff5-b8a2-41c1-929b-08d66610aeb9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4010; x-ms-traffictypediagnostic: DB3PR0502MB4010: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(3231475)(944501520)(4982022)(52105112)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB4010; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4010; x-forefront-prvs: 0892FA9A88 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(376002)(346002)(366004)(39860400002)(69234005)(189003)(199004)(28163001)(3846002)(229853002)(966005)(256004)(14444005)(106356001)(14454004)(76176011)(6116002)(66066001)(81166006)(97736004)(45080400002)(6486002)(105586002)(2906002)(4326008)(99286004)(6436002)(4001150100001)(6246003)(5660300001)(6306002)(6512007)(81156014)(36756003)(33656002)(25786009)(54906003)(71190400001)(478600001)(83716004)(8936002)(71200400001)(53936002)(186003)(102836004)(6916009)(2616005)(53546011)(86362001)(7736002)(316002)(26005)(446003)(68736007)(6506007)(486006)(476003)(11346002)(82746002)(305945005)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4010; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: lLjOLXnI1RWLUCqusas+BFLkDLwDh2WmyFFLyP5OXeD33BE7y29MeBvgTHAIef3Y2hIllVhoJ92iZhd/4oq1DnmDDOkLRwobaRUwGXsTNU1mUrP6XOyG9aJbYAr9x0pNy6Lr9sT/6VlIdfj0TDMgCzY6OUFdwceEKqtBvnne6ei1z54FKU+vBRtoUXAtSEglYk+9P63c/vYdjS7cqfx48ZTj+x1r8eE7UiHpdXwBq5kPop7WjJzYrvHwUqQDPg3etoQYLbDcEjGhsedKQU9FhEdNf7wcU3JR/d7q1lnBbyWG6R/322aFxnZDUuygGa/4 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <408648DAEA0FF7499A9690C6FDF8C463@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8607ff5-b8a2-41c1-929b-08d66610aeb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2018 00:18:35.5317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4010 Subject: Re: [dpdk-stable] patch 'igb_uio: fix unexpected removal for hot-unplug' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 00:18:36 -0000 Hi, This patch is being removed from stable/17.11 as it was mistakenly merged. Patches having 'fix' keyword in the title were merged even though those don= 't have "Cc: stable@dpdk.org" tag in the commit message. If you think this patch is still needed for stable/17.11, please let me kno= w. Then I'll take it back. Thanks, Yongseok > On Nov 29, 2018, at 3:11 PM, Yongseok Koh wrote: >=20 > Hi, >=20 > FYI, your patch has been queued to LTS release 17.11.5 >=20 > Note it hasn't been pushed to https://emea01.safelinks.protection.outlook= .com/?url=3Dhttp%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=3D02%7C01= %7Cyskoh%40mellanox.com%7C9a85707264f84fa23fbc08d656506c13%7Ca652971c7d2e4d= 9ba6a4d149256f461b%7C0%7C0%7C636791300746459390&sdata=3DRiJcaNBcf8to1Bf= kg%2FfrK7lG%2FxBlKu%2F5EYnIxD2MBhI%3D&reserved=3D0 yet. > It will be pushed if I get no objections before 12/01/18. So please > shout if anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he patch applied > to the branch. If the code is different (ie: not only metadata diffs), du= e for example to > a change in context or macro names, please double check it. >=20 > Thanks. >=20 > Yongseok >=20 > --- > From 8933c679415efb064aa46025fc84df6765577897 Mon Sep 17 00:00:00 2001 > From: Jeff Guo > Date: Thu, 18 Oct 2018 14:27:15 +0800 > Subject: [PATCH] igb_uio: fix unexpected removal for hot-unplug >=20 > [ upstream commit 70efa4116420b6f7a0734711dd603d3024366c79 ] >=20 > When a device is hot-unplugged, pci_remove will be invoked unexpectedly > before pci_release, it will caused kernel hung issue which will throw the > error info of "Trying to free already-free IRQ XXX". And on the other han= d, > if pci_remove before pci_release, the interrupt will not got chance to be > disabled. So this patch aim to fix this issue by adding pci_release call > in pci_remove, it will gurranty that all pci clean up will be done before > pci removal. >=20 > Signed-off-by: Jeff Guo > Acked-by: Ferruh Yigit > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/l= inuxapp/igb_uio/igb_uio.c > index 45d70272d..22484ac14 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -577,6 +577,8 @@ igbuio_pci_remove(struct pci_dev *dev) > { > struct rte_uio_pci_dev *udev =3D pci_get_drvdata(dev); >=20 > + igbuio_pci_release(&udev->info, NULL); > + > sysfs_remove_group(&dev->dev.kobj, &dev_attr_grp); > uio_unregister_device(&udev->info); > igbuio_pci_release_iomem(&udev->info); > --=20 > 2.11.0 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if non= -empty: > --- > --- - 2018-11-29 15:01:48.264909796 -0800 > +++ 0069-igb_uio-fix-unexpected-removal-for-hot-unplug.patch 2018-11-29 1= 5:01:45.176961000 -0800 > @@ -1,8 +1,10 @@ > -From 70efa4116420b6f7a0734711dd603d3024366c79 Mon Sep 17 00:00:00 2001 > +From 8933c679415efb064aa46025fc84df6765577897 Mon Sep 17 00:00:00 2001 > From: Jeff Guo > Date: Thu, 18 Oct 2018 14:27:15 +0800 > Subject: [PATCH] igb_uio: fix unexpected removal for hot-unplug >=20 > +[ upstream commit 70efa4116420b6f7a0734711dd603d3024366c79 ] > + > When a device is hot-unplugged, pci_remove will be invoked unexpectedly > before pci_release, it will caused kernel hung issue which will throw the > error info of "Trying to free already-free IRQ XXX". And on the other han= d, > @@ -14,14 +16,14 @@ > Signed-off-by: Jeff Guo > Acked-by: Ferruh Yigit > --- > - kernel/linux/igb_uio/igb_uio.c | 2 ++ > + lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > -diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_u= io.c > -index fede66cf2..3cf394bdf 100644 > ---- a/kernel/linux/igb_uio/igb_uio.c > -+++ b/kernel/linux/igb_uio/igb_uio.c > -@@ -570,6 +570,8 @@ igbuio_pci_remove(struct pci_dev *dev) > +diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/= linuxapp/igb_uio/igb_uio.c > +index 45d70272d..22484ac14 100644 > +--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > ++++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +@@ -577,6 +577,8 @@ igbuio_pci_remove(struct pci_dev *dev) > { > struct rte_uio_pci_dev *udev =3D pci_get_drvdata(dev); >=20