Re: 21.11.9 patches review and test

[Kevin Traynor <ktraynor@redhat.com>]

On 17/12/2024 10:01, Xu, HailinX wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Wednesday, December 4, 2024 11:59 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali Alnubani <alialnu@nvidia.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
>> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
>> <thomas@monjalon.net>; yanghliu@redhat.com
>> Subject: 21.11.9 patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 21.11.9.
>>
>> The planned date for the final release is 17th December 2024.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
>>
>> These patches are located at branch 21.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
> Update the test status for Intel part. Vhost part is done, the other part is in progress and Found one build issue.
> 
> issue:
>     DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1  -> fix patch from Kaiwen Deng <kaiwenx.deng@intel.com>
> 

Thanks Hailin. What is the issue reported ? Are you saying the patch
below [1] is cause ? The patch seems fine to me, it is just adding a
NULL check before dereference:

-     if (vf->vf_res->vf_cap_flags &
-         VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
+     if (vf->vf_res != NULL &&
+         vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {

[1]
commit c78d01172de035fa7e997841d44b01f58ed7cf83
Author: Kaiwen Deng <kaiwenx.deng@intel.com>
Date:   Tue Aug 6 08:35:27 2024 +0800

    net/iavf: fix crash when link is unstable

    [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]

    Physical link instability may cause a core dump because unstable
    physical links can result in a large number of link change events. Some
    of these events may be captured by vf before vf resources are allocated,
    and that will result in a core dump.

    This commit will check if vf_res is invalid before dereferencing it.

    Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message
without interrupt")

    Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
    Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
>   Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4, FreeBSD14.1, SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found 
> - All test done. No new dpdk issue is found.
> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
> - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
> - All test done. No new dpdk issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
> - on going. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
> - on going. No new dpdk issue is found.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
> - on going. No new dpdk issue is found.
> 		
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
> - All test done. No new dpdk issue is found.
> * Cryptodev: 
>   *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>     - on going. No new dpdk issue is found.
>   *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
>     - on going. No new dpdk issue is found.
> 
> 
> Regards,
> Xu, Hailin
>