21.11.9 patches review and test

21.11.9 patches review and test

[Kevin Traynor]

Hi all,

Here is a list of patches targeted for stable release 21.11.9.

The planned date for the final release is 17th December 2024.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1

These patches are located at branch 21.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Kevin

---
Ajit Khaparde (1):
      net/bnxt: fix TCP and UDP checksum flags

Alan Elder (1):
      net/netvsc: fix using Tx queue higher than Rx queues

Aleksandr Loktionov (1):
      net/i40e/base: fix misleading debug logs and comments

Alexander Kozyrev (3):
      net/mlx5: fix shared queue port number in vector Rx
      common/mlx5: fix error CQE handling for 128 bytes CQE
      net/mlx5: fix miniCQEs number calculation

Anatoly Burakov (1):
      net/i40e/base: fix setting flags in init function

Andre Muezerie (1):
      rcu: fix implicit conversion in bit shift

Artur Tyminski (1):
      net/i40e/base: fix DDP loading with reserved track ID

Barbara Skobiej (3):
      net/ixgbe/base: fix unchecked return value
      net/i40e/base: fix unchecked return value
      net/i40e/base: fix loop bounds

Bill Xiang (2):
      vhost: fix offset while mapping log base address
      vdpa: update used flags in used ring relay

Bing Zhao (1):
      net/mlx5: workaround list management of Rx queue control

Bruce Richardson (10):
      eal/x86: fix 32-bit write combining store
      net/i40e: fix AVX-512 pointer copy on 32-bit
      net/ice: fix AVX-512 pointer copy on 32-bit
      net/iavf: fix AVX-512 pointer copy on 32-bit
      build: remove version check on compiler links function
      net/ice: detect stopping a flow director queue twice
      app/dumpcap: remove unused struct array
      eventdev: fix possible array underflow/overflow
      net/iavf: add segment-length check to Tx prep
      net/iavf: fix VF reset when using DCF

Chaoyong He (1):
      net/nfp: fix link change return value

Chengwen Feng (6):
      examples/eventdev: fix queue crash with generic pipeline
      ethdev: verify queue ID in Tx done cleanup
      net/hns3: verify reset type from firmware
      dmadev: fix potential null pointer access
      net/hns3: restrict tunnel flow rule to one header
      net/mvneta: fix possible out-of-bounds write

Danylo Vodopianov (1):
      app/testpmd: fix aged flow destroy

Dave Ertman (1):
      net/ice/base: fix VLAN replay after reset

David Marchand (2):
      net/iavf: preserve MAC address with i40e PF Linux driver
      crypto/openssl: fix 3DES-CTR with big endian CPUs

Dengdui Huang (2):
      net/hns3: fix error code for repeatedly create counter
      net/hns3: fix fully use hardware flow director table

Eryk Rybak (1):
      net/i40e/base: fix blinking X722 with X557 PHY

Fabio Pricoco (2):
      net/ice/base: add bounds check
      net/ice/base: fix iteration of TLVs in Preserved Fields Area

Farah Smith (1):
      net/bnxt/tf_core: fix Thor TF EM key size check

Fidaullah Noonari (1):
      app/procinfo: fix leak on exit

Gagandeep Singh (2):
      crypto/dpaa2_sec: fix memory leak
      bus/dpaa: fix PFDRs leaks due to FQRNIs

Hanumanth Pothula (1):
      event/octeontx: fix possible integer overflow

Hemant Agrawal (4):
      bus/dpaa: fix VSP for 1G fm1-mac9 and 10
      bus/dpaa: fix the fman details status
      examples/l2fwd-event: fix spinlock handling
      bus/dpaa: fix lock condition during error handling

Igor Gutorov (1):
      net/mlx5: fix reported Rx/Tx descriptor limits

Jiawen Wu (8):
      net/txgbe: fix SWFW mbox
      net/txgbe: fix VF-PF mbox interrupt
      net/txgbe: remove outer UDP checksum capability
      net/txgbe: fix driver load bit to inform firmware
      net/ngbe: fix driver load bit to inform firmware
      net/ngbe: reconfigure more MAC Rx registers
      net/ngbe: fix interrupt lost in legacy or MSI mode
      net/ngbe: restrict configuration of VLAN strip offload

Jie Hai (2):
      net/hns3: remove some basic address dump
      net/hns3: fix dump counter of registers

Jun Wang (1):
      net/e1000: fix link status crash in secondary process

Kaiwen Deng (1):
      net/iavf: fix crash when link is unstable

Kiran Kumar K (1):
      common/cnxk: fix RSS key configuration

Kommula Shiva Shankar (1):
      net/virtio-user: reset used index counter

Lewis Donzis (1):
      net/ixgbe: fix link status delay on FreeBSD

Long Li (1):
      net/netvsc: force Tx VLAN offload on 801.2Q packet

Malcolm Bumgardner (1):
      dev: fix callback lookup when unregistering device

Mihai Brodschi (1):
      net/memif: fix buffer overflow in zero copy Rx

Niall Meade (1):
      ethdev: fix overflow in descriptor count

Paul Greenwalt (1):
      net/ice/base: fix link speed for 200G

Peter Morrow (1):
      net/bnxt: fix reading SFF-8436 SFP EEPROMs

Peter Spreadborough (1):
      net/bnxt: fix bad action offset in Tx BD

Radoslaw Tyl (1):
      net/i40e/base: fix repeated register dumps

Rakesh Kudurumalla (3):
      net/cnxk: fix Rx timestamp handling for VF
      net/cnxk: fix Rx offloads to handle timestamp
      common/cnxk: fix base log level

Roger Melton (1):
      net/vmxnet3: fix crash after configuration failure

Rohit Raj (2):
      net/dpaa: fix typecasting channel ID
      bus/fslmc: fix Coverity warnings in QBMAN

Shani Peretz (1):
      common/mlx5: fix misalignment

Shun Hao (1):
      net/mlx5: fix memory leak in metering

Sivaprasad Tummala (1):
      power: fix mapped lcore ID

Stephen Hemminger (30):
      bpf: fix free function mismatch if convert fails
      baseband/la12xx: fix use after free in modem config
      crypto/bcmfs: fix free function mismatch
      dma/idxd: fix free function mismatch in device probe
      event/cnxk: fix free function mismatch in port config
      net/e1000: fix use after free in filter flush
      net/sfc: fix use after free in debug logs
      raw/ifpga/base: fix use after free
      raw/ifpga: fix free function mismatch in interrupt config
      examples/vhost: fix free function mismatch
      net/tap: avoid memcpy with null argument
      app/testpmd: remove unnecessary cast
      net/pcap: set live interface as non-blocking
      net/ena: revert redefining memcpy
      net/tap: restrict maximum number of MP FDs
      net/pcap: fix blocking Rx
      test/bonding: remove redundant info query
      examples/ntb: check info query return
      net/bnx2x: remove dead conditional
      net/bnx2x: fix always true expression
      net/bnx2x: fix possible infinite loop at startup
      net/bnx2x: fix duplicate branch
      member: fix choice of bucket for displacement
      test/bonding: fix loop on members
      test/bonding: fix MAC address comparison
      test/event: avoid duplicate initialization
      test/eal: fix loop coverage for alignment macros
      test/eal: fix lcore check
      app/testpmd: remove redundant policy action condition
      doc: correct definition of stats per queue feature

Sunil Kumar Kori (1):
      common/cnxk: fix build on Ubuntu 24.04

Thomas Monjalon (2):
      net/nfb: fix use after free
      devtools: fix check of multiple commits fixed at once

Timothy Redaelli (1):
      net/ionic: fix build with Fedora Rawhide

Vanshika Shukla (1):
      net/dpaa: fix reallocate mbuf handling

Varun Sethi (1):
      common/dpaax/caamflib: fix PDCP SNOW-ZUC watchdog

Viacheslav Ovsiienko (4):
      net/mlx5: fix number of supported flex parsers
      app/testpmd: remove flex item init command leftover
      net/mlx5: fix next protocol validation after flex item
      net/mlx5: fix non full word sample fields in flex item

Vladimir Medvedkin (4):
      fib6: add runtime checks in AVX512 lookup
      fib: fix AVX512 lookup
      hash: fix thash LFSR initialization
      net/i40e: check register read for outer VLAN

Wathsala Vithanage (1):
      power: enable CPPC

Re: 21.11.9 patches review and test

[Yanghang Liu]

[-- Attachment #1: Type: text/plain, Size: 10540 bytes --]

I tested below 18 scenarios on RHEL 9.2 and didn't find any new dpdk issues.

   - VM with device assignment(PF) throughput testing(1G hugepage size):
   PASS
   - VM with device assignment(PF) throughput testing(2M hugepage size) :
   PASS
   - VM with device assignment(VF) throughput testing: PASS
   - PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
   - PVP vhost-user 2Q throughput testing: PASS
   - PVP vhost-user 1Q - cross numa node throughput testing: PASS
   - VM with vhost-user 2 queues throughput testing: PASS
   - vhost-user reconnect with dpdk-client, qemu-server(qemu reconnect):
   PASS
   - vhost-user reconnect with dpdk-client, qemu-server(ovs reconnect): PASS
   - PVP  reconnect with dpdk-client, qemu-server: PASS
   - PVP 1Q live migration testing: PASS
   - PVP 1Q cross numa node live migration testing: PASS
   - VM with ovs+dpdk+vhost-user 1Q live migration testing: PASS
   - VM with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
   - VM with ovs+dpdk+vhost-user 2Q live migration testing: PASS
   - VM with ovs+dpdk+vhost-user 4Q live migration testing: PASS
   - Host PF + DPDK testing: PASS
   - Host VF + DPDK testing: PASS


Test Versions:

   - qemu-kvm-7.2
   - kernel 5.14
   - libvirt 9.0
   - git describe
      - v21.11.9-rc1
   - git log

commit f197f1e13ccfb74c92ad05602443dd0984f39540

Author: Kevin Traynor <ktraynor@redhat.com>

Date:   Wed Dec 4 15:24:08 2024 +0000

version: 21.11.9-rc1

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>


   - Test device : X540-AT2 NIC(ixgbe, 10G)

Tested-by: Yanghang Liu <yanghliu@redhat.com>


On Wed, Dec 4, 2024 at 11:58 PM Kevin Traynor <ktraynor@redhat.com> wrote:

> Hi all,
>
> Here is a list of patches targeted for stable release 21.11.9.
>
> The planned date for the final release is 17th December 2024.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
>
> These patches are located at branch 21.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Kevin
>
> ---
> Ajit Khaparde (1):
>       net/bnxt: fix TCP and UDP checksum flags
>
> Alan Elder (1):
>       net/netvsc: fix using Tx queue higher than Rx queues
>
> Aleksandr Loktionov (1):
>       net/i40e/base: fix misleading debug logs and comments
>
> Alexander Kozyrev (3):
>       net/mlx5: fix shared queue port number in vector Rx
>       common/mlx5: fix error CQE handling for 128 bytes CQE
>       net/mlx5: fix miniCQEs number calculation
>
> Anatoly Burakov (1):
>       net/i40e/base: fix setting flags in init function
>
> Andre Muezerie (1):
>       rcu: fix implicit conversion in bit shift
>
> Artur Tyminski (1):
>       net/i40e/base: fix DDP loading with reserved track ID
>
> Barbara Skobiej (3):
>       net/ixgbe/base: fix unchecked return value
>       net/i40e/base: fix unchecked return value
>       net/i40e/base: fix loop bounds
>
> Bill Xiang (2):
>       vhost: fix offset while mapping log base address
>       vdpa: update used flags in used ring relay
>
> Bing Zhao (1):
>       net/mlx5: workaround list management of Rx queue control
>
> Bruce Richardson (10):
>       eal/x86: fix 32-bit write combining store
>       net/i40e: fix AVX-512 pointer copy on 32-bit
>       net/ice: fix AVX-512 pointer copy on 32-bit
>       net/iavf: fix AVX-512 pointer copy on 32-bit
>       build: remove version check on compiler links function
>       net/ice: detect stopping a flow director queue twice
>       app/dumpcap: remove unused struct array
>       eventdev: fix possible array underflow/overflow
>       net/iavf: add segment-length check to Tx prep
>       net/iavf: fix VF reset when using DCF
>
> Chaoyong He (1):
>       net/nfp: fix link change return value
>
> Chengwen Feng (6):
>       examples/eventdev: fix queue crash with generic pipeline
>       ethdev: verify queue ID in Tx done cleanup
>       net/hns3: verify reset type from firmware
>       dmadev: fix potential null pointer access
>       net/hns3: restrict tunnel flow rule to one header
>       net/mvneta: fix possible out-of-bounds write
>
> Danylo Vodopianov (1):
>       app/testpmd: fix aged flow destroy
>
> Dave Ertman (1):
>       net/ice/base: fix VLAN replay after reset
>
> David Marchand (2):
>       net/iavf: preserve MAC address with i40e PF Linux driver
>       crypto/openssl: fix 3DES-CTR with big endian CPUs
>
> Dengdui Huang (2):
>       net/hns3: fix error code for repeatedly create counter
>       net/hns3: fix fully use hardware flow director table
>
> Eryk Rybak (1):
>       net/i40e/base: fix blinking X722 with X557 PHY
>
> Fabio Pricoco (2):
>       net/ice/base: add bounds check
>       net/ice/base: fix iteration of TLVs in Preserved Fields Area
>
> Farah Smith (1):
>       net/bnxt/tf_core: fix Thor TF EM key size check
>
> Fidaullah Noonari (1):
>       app/procinfo: fix leak on exit
>
> Gagandeep Singh (2):
>       crypto/dpaa2_sec: fix memory leak
>       bus/dpaa: fix PFDRs leaks due to FQRNIs
>
> Hanumanth Pothula (1):
>       event/octeontx: fix possible integer overflow
>
> Hemant Agrawal (4):
>       bus/dpaa: fix VSP for 1G fm1-mac9 and 10
>       bus/dpaa: fix the fman details status
>       examples/l2fwd-event: fix spinlock handling
>       bus/dpaa: fix lock condition during error handling
>
> Igor Gutorov (1):
>       net/mlx5: fix reported Rx/Tx descriptor limits
>
> Jiawen Wu (8):
>       net/txgbe: fix SWFW mbox
>       net/txgbe: fix VF-PF mbox interrupt
>       net/txgbe: remove outer UDP checksum capability
>       net/txgbe: fix driver load bit to inform firmware
>       net/ngbe: fix driver load bit to inform firmware
>       net/ngbe: reconfigure more MAC Rx registers
>       net/ngbe: fix interrupt lost in legacy or MSI mode
>       net/ngbe: restrict configuration of VLAN strip offload
>
> Jie Hai (2):
>       net/hns3: remove some basic address dump
>       net/hns3: fix dump counter of registers
>
> Jun Wang (1):
>       net/e1000: fix link status crash in secondary process
>
> Kaiwen Deng (1):
>       net/iavf: fix crash when link is unstable
>
> Kiran Kumar K (1):
>       common/cnxk: fix RSS key configuration
>
> Kommula Shiva Shankar (1):
>       net/virtio-user: reset used index counter
>
> Lewis Donzis (1):
>       net/ixgbe: fix link status delay on FreeBSD
>
> Long Li (1):
>       net/netvsc: force Tx VLAN offload on 801.2Q packet
>
> Malcolm Bumgardner (1):
>       dev: fix callback lookup when unregistering device
>
> Mihai Brodschi (1):
>       net/memif: fix buffer overflow in zero copy Rx
>
> Niall Meade (1):
>       ethdev: fix overflow in descriptor count
>
> Paul Greenwalt (1):
>       net/ice/base: fix link speed for 200G
>
> Peter Morrow (1):
>       net/bnxt: fix reading SFF-8436 SFP EEPROMs
>
> Peter Spreadborough (1):
>       net/bnxt: fix bad action offset in Tx BD
>
> Radoslaw Tyl (1):
>       net/i40e/base: fix repeated register dumps
>
> Rakesh Kudurumalla (3):
>       net/cnxk: fix Rx timestamp handling for VF
>       net/cnxk: fix Rx offloads to handle timestamp
>       common/cnxk: fix base log level
>
> Roger Melton (1):
>       net/vmxnet3: fix crash after configuration failure
>
> Rohit Raj (2):
>       net/dpaa: fix typecasting channel ID
>       bus/fslmc: fix Coverity warnings in QBMAN
>
> Shani Peretz (1):
>       common/mlx5: fix misalignment
>
> Shun Hao (1):
>       net/mlx5: fix memory leak in metering
>
> Sivaprasad Tummala (1):
>       power: fix mapped lcore ID
>
> Stephen Hemminger (30):
>       bpf: fix free function mismatch if convert fails
>       baseband/la12xx: fix use after free in modem config
>       crypto/bcmfs: fix free function mismatch
>       dma/idxd: fix free function mismatch in device probe
>       event/cnxk: fix free function mismatch in port config
>       net/e1000: fix use after free in filter flush
>       net/sfc: fix use after free in debug logs
>       raw/ifpga/base: fix use after free
>       raw/ifpga: fix free function mismatch in interrupt config
>       examples/vhost: fix free function mismatch
>       net/tap: avoid memcpy with null argument
>       app/testpmd: remove unnecessary cast
>       net/pcap: set live interface as non-blocking
>       net/ena: revert redefining memcpy
>       net/tap: restrict maximum number of MP FDs
>       net/pcap: fix blocking Rx
>       test/bonding: remove redundant info query
>       examples/ntb: check info query return
>       net/bnx2x: remove dead conditional
>       net/bnx2x: fix always true expression
>       net/bnx2x: fix possible infinite loop at startup
>       net/bnx2x: fix duplicate branch
>       member: fix choice of bucket for displacement
>       test/bonding: fix loop on members
>       test/bonding: fix MAC address comparison
>       test/event: avoid duplicate initialization
>       test/eal: fix loop coverage for alignment macros
>       test/eal: fix lcore check
>       app/testpmd: remove redundant policy action condition
>       doc: correct definition of stats per queue feature
>
> Sunil Kumar Kori (1):
>       common/cnxk: fix build on Ubuntu 24.04
>
> Thomas Monjalon (2):
>       net/nfb: fix use after free
>       devtools: fix check of multiple commits fixed at once
>
> Timothy Redaelli (1):
>       net/ionic: fix build with Fedora Rawhide
>
> Vanshika Shukla (1):
>       net/dpaa: fix reallocate mbuf handling
>
> Varun Sethi (1):
>       common/dpaax/caamflib: fix PDCP SNOW-ZUC watchdog
>
> Viacheslav Ovsiienko (4):
>       net/mlx5: fix number of supported flex parsers
>       app/testpmd: remove flex item init command leftover
>       net/mlx5: fix next protocol validation after flex item
>       net/mlx5: fix non full word sample fields in flex item
>
> Vladimir Medvedkin (4):
>       fib6: add runtime checks in AVX512 lookup
>       fib: fix AVX512 lookup
>       hash: fix thash LFSR initialization
>       net/i40e: check register read for outer VLAN
>
> Wathsala Vithanage (1):
>       power: enable CPPC
>
>

[-- Attachment #2: Type: text/html, Size: 14021 bytes --]

RE: 21.11.9 patches review and test

[Ali Alnubani]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, December 4, 2024 5:59 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali
> Alnubani <alialnu@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-
> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
> yanghliu@redhat.com
> Subject: 21.11.9 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 21.11.9.
> 
> The planned date for the final release is 17th December 2024.
> 
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
> 
> These patches are located at branch 21.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin
> 
> ---

Hello,

We ran the following functional tests with Nvidia hardware on 21.11.9-rc1, and we don't see new issues caused by the changes in this release.:

- Basic functionality:
  Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- rte_flow tests (https://doc.dpdk.org/guides/nics/mlx5.html#supported-hardware-offloads)
- RSS tests.
- VLAN filtering, stripping, and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Buffer Split tests.
- Tx scheduling tests.

Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 22.04 / Driver: MLNX_OFED_LINUX-24.10-1.1.4.0 / Firmware: 22.43.2026
- NIC: ConnectX-7 / OS: Ubuntu 22.04 / Driver: MLNX_OFED_LINUX-24.10-1.1.4.0 / Firmware: 28.43.2026
- DPU: BlueField-2 / DOCA SW version: 2.9.1 / Firmware: 24.43.2026

Additionally, we ran build tests with multiple configurations on the following OS/driver combinations (all passed):
- Debian 12 with MLNX_OFED_LINUX-24.10-1.1.4.0.
- Ubuntu 22.04 with MLNX_OFED_LINUX-24.10-1.1.4.0.
- Ubuntu 24.04 with MLNX_OFED_LINUX-24.10-1.1.4.0.
- Ubuntu 24.04 with rdma-core v50.0.
- Fedora 40 with rdma-core v48.0.
- Fedora 42 (Rawhide) with rdma-core v51.0.
- OpenSUSE Leap 15.6 with rdma-core v49.1.

Thanks,
Ali

Re: 21.11.9 patches review and test

[Kevin Traynor]

On 16/12/2024 18:14, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Wednesday, December 4, 2024 5:59 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Ali
>> Alnubani <alialnu@nvidia.com>; David Christensen <drc@linux.vnet.ibm.com>;
>> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
>> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
>> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin
>> Traynor <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
>> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; NBU-
>> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
>> yanghliu@redhat.com
>> Subject: 21.11.9 patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 21.11.9.
>>
>> The planned date for the final release is 17th December 2024.
>>
>> Please help with testing and validation of your use cases and report
>> any issues/results with reply-all to this mail. For the final release
>> the fixes and reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
>>
>> These patches are located at branch 21.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
> 
> Hello,
> 
> We ran the following functional tests with Nvidia hardware on 21.11.9-rc1, and we don't see new issues caused by the changes in this release.:
> 

Thank you Ali!

> - Basic functionality:
>   Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - rte_flow tests (https://doc.dpdk.org/guides/nics/mlx5.html#supported-hardware-offloads)
> - RSS tests.
> - VLAN filtering, stripping, and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - link_status_interrupt example application tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
> - Hardware LRO tests.
> - Buffer Split tests.
> - Tx scheduling tests.
> 
> Functional tests ran on:
> - NIC: ConnectX-6 Dx / OS: Ubuntu 22.04 / Driver: MLNX_OFED_LINUX-24.10-1.1.4.0 / Firmware: 22.43.2026
> - NIC: ConnectX-7 / OS: Ubuntu 22.04 / Driver: MLNX_OFED_LINUX-24.10-1.1.4.0 / Firmware: 28.43.2026
> - DPU: BlueField-2 / DOCA SW version: 2.9.1 / Firmware: 24.43.2026
> 
> Additionally, we ran build tests with multiple configurations on the following OS/driver combinations (all passed):
> - Debian 12 with MLNX_OFED_LINUX-24.10-1.1.4.0.
> - Ubuntu 22.04 with MLNX_OFED_LINUX-24.10-1.1.4.0.
> - Ubuntu 24.04 with MLNX_OFED_LINUX-24.10-1.1.4.0.
> - Ubuntu 24.04 with rdma-core v50.0.
> - Fedora 40 with rdma-core v48.0.
> - Fedora 42 (Rawhide) with rdma-core v51.0.
> - OpenSUSE Leap 15.6 with rdma-core v49.1.
> 
> Thanks,
> Ali

RE: 21.11.9 patches review and test

[Xu, HailinX]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, December 4, 2024 11:59 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
> <thomas@monjalon.net>; yanghliu@redhat.com
> Subject: 21.11.9 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 21.11.9.
> 
> The planned date for the final release is 17th December 2024.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
> 
> These patches are located at branch 21.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Kevin
> 
> ---
Update the test status for Intel part. Vhost part is done, the other part is in progress and Found one build issue.

issue:
    DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1  -> fix patch from Kaiwen Deng <kaiwenx.deng@intel.com>

# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
  Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4, FreeBSD14.1, SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found 
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- on going. No new dpdk issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- on going. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- on going. No new dpdk issue is found.
		
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. No new dpdk issue is found.
* Cryptodev: 
  *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
    - on going. No new dpdk issue is found.
  *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
    - on going. No new dpdk issue is found.


Regards,
Xu, Hailin

Re: 21.11.9 patches review and test

[Kevin Traynor]

On 17/12/2024 10:01, Xu, HailinX wrote:
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Wednesday, December 4, 2024 11:59 PM
>> To: stable@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>> Ali Alnubani <alialnu@nvidia.com>; David Christensen
>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
>> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
>> <thomas@monjalon.net>; yanghliu@redhat.com
>> Subject: 21.11.9 patches review and test
>>
>> Hi all,
>>
>> Here is a list of patches targeted for stable release 21.11.9.
>>
>> The planned date for the final release is 17th December 2024.
>>
>> Please help with testing and validation of your use cases and report any
>> issues/results with reply-all to this mail. For the final release the fixes and
>> reported validations will be added to the release notes.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
>>
>> These patches are located at branch 21.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks.
>>
>> Kevin
>>
>> ---
> Update the test status for Intel part. Vhost part is done, the other part is in progress and Found one build issue.
> 
> issue:
>     DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1  -> fix patch from Kaiwen Deng <kaiwenx.deng@intel.com>
> 

Thanks Hailin. What is the issue reported ? Are you saying the patch
below [1] is cause ? The patch seems fine to me, it is just adding a
NULL check before dereference:

-     if (vf->vf_res->vf_cap_flags &
-         VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
+     if (vf->vf_res != NULL &&
+         vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {

[1]
commit c78d01172de035fa7e997841d44b01f58ed7cf83
Author: Kaiwen Deng <kaiwenx.deng@intel.com>
Date:   Tue Aug 6 08:35:27 2024 +0800

    net/iavf: fix crash when link is unstable

    [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]

    Physical link instability may cause a core dump because unstable
    physical links can result in a large number of link change events. Some
    of these events may be captured by vf before vf resources are allocated,
    and that will result in a core dump.

    This commit will check if vf_res is invalid before dereferencing it.

    Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message
without interrupt")

    Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
    Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> # Basic Intel(R) NIC testing
> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
>   Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4, FreeBSD14.1, SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found 
> - All test done. No new dpdk issue is found.
> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
> - All test done. No new dpdk issue is found.
> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
> - All test done. No new dpdk issue is found.
> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
> - on going. No new dpdk issue is found.
> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
> - on going. No new dpdk issue is found.
> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
> - on going. No new dpdk issue is found.
> 		
> # Basic cryptodev and virtio testing
> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
> - All test done. No new dpdk issue is found.
> * Cryptodev: 
>   *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>     - on going. No new dpdk issue is found.
>   *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
>     - on going. No new dpdk issue is found.
> 
> 
> Regards,
> Xu, Hailin
> 

Re: 21.11.9 patches review and test

[Kevin Traynor]

On 17/12/2024 11:30, Kevin Traynor wrote:
> On 17/12/2024 10:01, Xu, HailinX wrote:
>>> -----Original Message-----
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Wednesday, December 4, 2024 11:59 PM
>>> To: stable@dpdk.org
>>> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
>>> Ali Alnubani <alialnu@nvidia.com>; David Christensen
>>> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
>>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
>>> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
>>> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Luca
>>> Boccassi <bluca@debian.org>; Pei Zhang <pezhang@redhat.com>; Raslan
>>> Darawsheh <rasland@nvidia.com>; Thomas Monjalon
>>> <thomas@monjalon.net>; yanghliu@redhat.com
>>> Subject: 21.11.9 patches review and test
>>>
>>> Hi all,
>>>
>>> Here is a list of patches targeted for stable release 21.11.9.
>>>
>>> The planned date for the final release is 17th December 2024.
>>>
>>> Please help with testing and validation of your use cases and report any
>>> issues/results with reply-all to this mail. For the final release the fixes and
>>> reported validations will be added to the release notes.
>>>
>>> A release candidate tarball can be found at:
>>>
>>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
>>>
>>> These patches are located at branch 21.11 of dpdk-stable repo:
>>>     https://dpdk.org/browse/dpdk-stable/
>>>
>>> Thanks.
>>>
>>> Kevin
>>>
>>> ---
>> Update the test status for Intel part. Vhost part is done, the other part is in progress and Found one build issue.
>>
>> issue:
>>     DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1  -> fix patch from Kaiwen Deng <kaiwenx.deng@intel.com>
>>
> 
> Thanks Hailin. What is the issue reported ? Are you saying the patch
> below [1] is cause ? The patch seems fine to me, it is just adding a
> NULL check before dereference:
> 
> -     if (vf->vf_res->vf_cap_flags &
> -         VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> +     if (vf->vf_res != NULL &&
> +         vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> 
> [1]
> commit c78d01172de035fa7e997841d44b01f58ed7cf83
> Author: Kaiwen Deng <kaiwenx.deng@intel.com>
> Date:   Tue Aug 6 08:35:27 2024 +0800
> 
>     net/iavf: fix crash when link is unstable
> 
>     [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]
> 
>     Physical link instability may cause a core dump because unstable
>     physical links can result in a large number of link change events. Some
>     of these events may be captured by vf before vf resources are allocated,
>     and that will result in a core dump.
> 
>     This commit will check if vf_res is invalid before dereferencing it.
> 
>     Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message
> without interrupt")
> 
>     Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
>     Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
Hi Hailin/All,

I have an update on 21.11. I had to make the release due to a CVE
embargo lifting, so I wrote up the validation status at the time of release.

There is a link to this thread in the release notes, so any further
testing reported here can be found. Thanks for your testing.

On the compiler issue reported above. I tested on Ubuntu 24.04 with -O1
and there is a maybe-uninitialized warning on the iavf code. For ref
[1]. However, it is not new in 21.11.9 and is not caused by the patch above.

I can reproduce it as far back as 21.11.3, and probably earlier (can't
confirm as earlier version have other build issue with new the latest gcc).

It was too late for a fix so I listed it as a known issue in the release
notes.

thanks,
Kevin.

[1]
In file included from
/usr/lib/gcc/x86_64-linux-gnu/13/include/xmmintrin.h:1322,
                 from
/usr/lib/gcc/x86_64-linux-gnu/13/include/immintrin.h:31,
                 from
/usr/lib/gcc/x86_64-linux-gnu/13/include/x86intrin.h:32,
                 from ../lib/eal/x86/include/rte_vect.h:31,
                 from ../lib/eal/x86/include/rte_memcpy.h:17,
                 from ../lib/net/rte_ether.h:21,
                 from ../lib/ethdev/rte_ethdev.h:172,
                 from ../lib/ethdev/ethdev_driver.h:22,
                 from ../drivers/net/iavf/iavf_rxtx_vec_sse.c:6:
In function \u2018_mm_unpacklo_epi32\u2019,
    inlined from \u2018flex_desc_to_olflags_v\u2019 at
../drivers/net/iavf/iavf_rxtx_vec_sse.c:338:4,
    inlined from \u2018_recv_raw_pkts_vec_flex_rxd\u2019 at
../drivers/net/iavf/iavf_rxtx_vec_sse.c:969:3:
/usr/lib/gcc/x86_64-linux-gnu/13/include/emmintrin.h:1048:19: error:
\u2018descs_bh[0]\u2019 may be used uninitialized
[-Werror=maybe-uninitialized]
 1048 |   return (__m128i)__builtin_ia32_punpckldq128 ((__v4si)__A,
(__v4si)__B);
      |
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/iavf/iavf_rxtx_vec_sse.c: In function
\u2018_recv_raw_pkts_vec_flex_rxd\u2019:
../drivers/net/iavf/iavf_rxtx_vec_sse.c:828:25: note:
\u2018descs_bh[0]\u2019 was declared here
  828 |                 __m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP];
      |                         ^~~~~~~~


>> # Basic Intel(R) NIC testing
>> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
>>   Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4, FreeBSD14.1, SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found 
>> - All test done. No new dpdk issue is found.
>> * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
>> - All test done. No new dpdk issue is found.
>> * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.		
>> - All test done. No new dpdk issue is found.
>> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
>> - on going. No new dpdk issue is found.
>> * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
>> - on going. No new dpdk issue is found.
>> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
>> - on going. No new dpdk issue is found.
>> 		
>> # Basic cryptodev and virtio testing
>> * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
>> - All test done. No new dpdk issue is found.
>> * Cryptodev: 
>>   *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
>>     - on going. No new dpdk issue is found.
>>   *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
>>     - on going. No new dpdk issue is found.
>>
>>
>> Regards,
>> Xu, Hailin
>>
> 

RE: 21.11.9 patches review and test

[Xu, HailinX]

> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, December 18, 2024 1:48 AM
> To: Xu, HailinX <hailinx.xu@intel.com>; stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>; Thomas
> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com; Richardson,
> Bruce <bruce.richardson@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Subject: Re: 21.11.9 patches review and test
> 
> On 17/12/2024 11:30, Kevin Traynor wrote:
> > On 17/12/2024 10:01, Xu, HailinX wrote:
> >>> -----Original Message-----
> >>> From: Kevin Traynor <ktraynor@redhat.com>
> >>> Sent: Wednesday, December 4, 2024 11:59 PM
> >>> To: stable@dpdk.org
> >>> Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> >>> Ali Alnubani <alialnu@nvidia.com>; David Christensen
> >>> <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>;
> >>> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> >>> <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> >>> Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> >>> <ktraynor@redhat.com>; Luca Boccassi <bluca@debian.org>; Pei Zhang
> >>> <pezhang@redhat.com>; Raslan Darawsheh <rasland@nvidia.com>;
> Thomas
> >>> Monjalon <thomas@monjalon.net>; yanghliu@redhat.com
> >>> Subject: 21.11.9 patches review and test
> >>>
> >>> Hi all,
> >>>
> >>> Here is a list of patches targeted for stable release 21.11.9.
> >>>
> >>> The planned date for the final release is 17th December 2024.
> >>>
> >>> Please help with testing and validation of your use cases and report
> >>> any issues/results with reply-all to this mail. For the final
> >>> release the fixes and reported validations will be added to the release
> notes.
> >>>
> >>> A release candidate tarball can be found at:
> >>>
> >>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.9-rc1
> >>>
> >>> These patches are located at branch 21.11 of dpdk-stable repo:
> >>>     https://dpdk.org/browse/dpdk-stable/
> >>>
> >>> Thanks.
> >>>
> >>> Kevin
> >>>
> >>> ---
> >> Update the test status for Intel part. Vhost part is done, the other part is in
> progress and Found one build issue.
> >>
> >> issue:
> >>     DPDK meson build failed with EXTRA_CFLAGS='-O1' on Ubuntu 24.04.1
> >> -> fix patch from Kaiwen Deng <kaiwenx.deng@intel.com>
> >>
> >
> > Thanks Hailin. What is the issue reported ? Are you saying the patch
> > below [1] is cause ? The patch seems fine to me, it is just adding a
> > NULL check before dereference:
> >
> > -     if (vf->vf_res->vf_cap_flags &
> > -         VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> > +     if (vf->vf_res != NULL &&
> > +         vf->vf_res->vf_cap_flags & VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> >
> > [1]
> > commit c78d01172de035fa7e997841d44b01f58ed7cf83
> > Author: Kaiwen Deng <kaiwenx.deng@intel.com>
> > Date:   Tue Aug 6 08:35:27 2024 +0800
> >
> >     net/iavf: fix crash when link is unstable
> >
> >     [ upstream commit 57ed9ca61f44ffc3801f55c749347bd717834008 ]
> >
> >     Physical link instability may cause a core dump because unstable
> >     physical links can result in a large number of link change events. Some
> >     of these events may be captured by vf before vf resources are allocated,
> >     and that will result in a core dump.
> >
> >     This commit will check if vf_res is invalid before dereferencing it.
> >
> >     Fixes: 5e03e316c753 ("net/iavf: handle virtchnl event message
> > without interrupt")
> >
> >     Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> >     Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> Hi Hailin/All,
> 
> I have an update on 21.11. I had to make the release due to a CVE embargo
> lifting, so I wrote up the validation status at the time of release.
> 
> There is a link to this thread in the release notes, so any further testing
> reported here can be found. Thanks for your testing.
> 
> On the compiler issue reported above. I tested on Ubuntu 24.04 with -O1 and
> there is a maybe-uninitialized warning on the iavf code. For ref [1]. However, it
> is not new in 21.11.9 and is not caused by the patch above.
> 
> I can reproduce it as far back as 21.11.3, and probably earlier (can't confirm as
> earlier version have other build issue with new the latest gcc).
> 
> It was too late for a fix so I listed it as a known issue in the release notes.
> 
> thanks,
> Kevin.
> 
Hi Kevin,

Sorry, I may not have expressed it clearly, what I mean is that the solution to this issue has already been provided by Kaiwen.

From: Kaiwen Deng <kaiwenx.deng@intel.com>
Date: Wed, 11 Dec 2024 10:15:49 +0800
Subject: [PATCH] net/iavf: fix uninitialized variable

This patch fixes the variable 'descs_bh' may be used uninitialized.

Fixes: 6ad2944f4e82 ("net/iavf: support Rx timestamp offload on AVX2")

Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
 drivers/net/iavf/iavf_rxtx_vec_sse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_rxtx_vec_sse.c b/drivers/net/iavf/iavf_rxtx_vec_sse.c
index 3f1d5e2ce8..199f5f5ccd 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_sse.c
+++ b/drivers/net/iavf/iavf_rxtx_vec_sse.c
@@ -825,7 +825,7 @@ _recv_raw_pkts_vec_flex_rxd(struct iavf_rx_queue *rxq,
 	     rxdp += IAVF_VPMD_DESCS_PER_LOOP) {
 		__m128i descs[IAVF_VPMD_DESCS_PER_LOOP];
 #ifndef RTE_LIBRTE_IAVF_16BYTE_RX_DESC
-		__m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP];
+		__m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP] = {_mm_setzero_si128()};
 #endif
 		__m128i pkt_mb0, pkt_mb1, pkt_mb2, pkt_mb3;
 		__m128i staterr, sterr_tmp1, sterr_tmp2;
--

Regards,
Xu, Hailin

> [1]
> In file included from
> /usr/lib/gcc/x86_64-linux-gnu/13/include/xmmintrin.h:1322,
>                  from
> /usr/lib/gcc/x86_64-linux-gnu/13/include/immintrin.h:31,
>                  from
> /usr/lib/gcc/x86_64-linux-gnu/13/include/x86intrin.h:32,
>                  from ../lib/eal/x86/include/rte_vect.h:31,
>                  from ../lib/eal/x86/include/rte_memcpy.h:17,
>                  from ../lib/net/rte_ether.h:21,
>                  from ../lib/ethdev/rte_ethdev.h:172,
>                  from ../lib/ethdev/ethdev_driver.h:22,
>                  from ../drivers/net/iavf/iavf_rxtx_vec_sse.c:6:
> In function \u2018_mm_unpacklo_epi32\u2019,
>     inlined from \u2018flex_desc_to_olflags_v\u2019
> at ../drivers/net/iavf/iavf_rxtx_vec_sse.c:338:4,
>     inlined from \u2018_recv_raw_pkts_vec_flex_rxd\u2019 at
> ../drivers/net/iavf/iavf_rxtx_vec_sse.c:969:3:
> /usr/lib/gcc/x86_64-linux-gnu/13/include/emmintrin.h:1048:19: error:
> \u2018descs_bh[0]\u2019 may be used uninitialized [-Werror=maybe-
> uninitialized]
>  1048 |   return (__m128i)__builtin_ia32_punpckldq128 ((__v4si)__A,
> (__v4si)__B);
>       |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/net/iavf/iavf_rxtx_vec_sse.c: In function
> \u2018_recv_raw_pkts_vec_flex_rxd\u2019:
> ../drivers/net/iavf/iavf_rxtx_vec_sse.c:828:25: note:
> \u2018descs_bh[0]\u2019 was declared here
>   828 |                 __m128i descs_bh[IAVF_VPMD_DESCS_PER_LOOP];
>       |                         ^~~~~~~~
> 
> 
> >> # Basic Intel(R) NIC testing
> >> * Build & CFLAG compile: cover the build test combination with latest
> GCC/Clang version and the popular OS revision such as
> >>   Ubuntu24.10, Ubuntu24.04, Fedora40, RHEL8.10, RHEL9.4,
> FreeBSD14.1,
> >> SUSE15, AzureLinux3.0, OpenAnolis8.9 etc. -> one new issue is found
> >> - All test done. No new dpdk issue is found.
> >> * PF(i40e, ixgbe): test scenarios including
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> >> - All test done. No new dpdk issue is found.
> >> * VF(i40e, ixgbe): test scenarios including VF-
> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
> 
> >> - All test done. No new dpdk issue is found.
> >> * PF/VF(ice): test scenarios including Switch features/Package
> Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible
> Descriptor, etc.
> >> - on going. No new dpdk issue is found.
> >> * Intel NIC single core/NIC performance: test scenarios including PF/VF
> single core performance test, etc.
> >> - on going. No new dpdk issue is found.
> >> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test -
> QAT&SW/FIB library, etc.
> >> - on going. No new dpdk issue is found.
> >>
> >> # Basic cryptodev and virtio testing
> >> * Virtio: both function and performance test are covered. Such as
> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf
> testing/VMAWARE ESXI 8.0, etc.
> >> - All test done. No new dpdk issue is found.
> >> * Cryptodev:
> >>   *Function test: test scenarios including Cryptodev API
> testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
> >>     - on going. No new dpdk issue is found.
> >>   *Performance test: test scenarios including Thoughput
> Performance/Cryptodev Latency, etc.
> >>     - on going. No new dpdk issue is found.
> >>
> >>
> >> Regards,
> >> Xu, Hailin
> >>
> >