From: Luca Boccassi <bluca@debian.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: Pai Sunil <sunil.pai.g@intel.com>,
Ilya Maximets <i.maximets@ovn.org>,
Stokes Ian <ian.stokes@intel.com>,
Govindharajan Hariprasad <hariprasad.govindharajan@intel.com>,
James Page <james.page@canonical.com>
Subject: Re: [dpdk-stable] [PATCH 0/7] Do not change build/link behavior on stable release
Date: Mon, 22 Mar 2021 12:00:40 +0000 [thread overview]
Message-ID: <922644623fd4ccbb652fde1169526b2bf4f752ae.camel@debian.org> (raw)
In-Reply-To: <20210322112135.3420072-1-christian.ehrhardt@canonical.com>
On Mon, 2021-03-22 at 12:21 +0100, Christian Ehrhardt wrote:
> Hi,
> most of you have been on CC on the discussion around this already.
> Background:
> http://mails.dpdk.org/archives/stable/2021-March/029418.html
>
> Summary:
> - changes to DPDK linking were proposed to stable @19.11.4 and
> identified to be bad
> - in the 19.11.6 time-frame the responses were ok so they were
> accepted in there
> - but the old issue still exists and e.g. OVS is non-buildable vs
> DPDK >=19.11.6
> - IMHO an upgrade of 19.11.x should not break how linking is done
> - But, OTOH one can now say "upgrading from 19.11.6 -> 19.11.8 this
> changes"
>
> I'm unsure if this is worth an early 19.11.8 or maybe just
> pushing it to git and an entry in the known-issues for 19.11.7?
> But before we bike-shed over that let us discuss and agree if
> taking those changes out of the 19.11.x release is the right
> approach.
>
>
> Christian Ehrhardt (7):
> Revert "Revert "Revert "build/pkg-config: prevent overlinking"""
> Revert "Revert "Revert "build/pkg-config: improve static linking
> flags"""
> Revert "Revert "Revert "build/pkg-config: output drivers first for
> static build"""
> Revert "Revert "Revert "build/pkg-config: move pkg-config file
> creation"""
> Revert "Revert "Revert "build: always link whole DPDK static
> libraries"""
> Revert "Revert "Revert "devtools: test static linkage with
> pkg-config"""
> Regenerate meson.build changes required due to reverts
>
> MAINTAINERS | 2 -
> app/test/meson.build | 2 +-
> buildtools/pkg-config/meson.build | 59 -------------------
> .../pkg-config/set-static-linker-flags.py | 38 ------------
> devtools/test-meson-builds.sh | 2 +-
> doc/build-sdk-meson.txt | 2 +-
> drivers/meson.build | 2 +-
> examples/bbdev_app/Makefile | 2 +-
> examples/bond/Makefile | 2 +-
> examples/cmdline/Makefile | 2 +-
> examples/distributor/Makefile | 2 +-
> examples/eventdev_pipeline/Makefile | 2 +-
> examples/fips_validation/Makefile | 2 +-
> examples/flow_classify/Makefile | 2 +-
> examples/flow_filtering/Makefile | 2 +-
> examples/helloworld/Makefile | 2 +-
> examples/ioat/Makefile | 2 +-
> examples/ip_fragmentation/Makefile | 2 +-
> examples/ip_pipeline/Makefile | 2 +-
> examples/ip_reassembly/Makefile | 2 +-
> examples/ipsec-secgw/Makefile | 2 +-
> examples/ipv4_multicast/Makefile | 2 +-
> examples/kni/Makefile | 2 +-
> examples/l2fwd-cat/Makefile | 2 +-
> examples/l2fwd-crypto/Makefile | 2 +-
> examples/l2fwd-event/Makefile | 2 +-
> examples/l2fwd-jobstats/Makefile | 2 +-
> examples/l2fwd-keepalive/Makefile | 2 +-
> examples/l2fwd/Makefile | 2 +-
> examples/l3fwd-acl/Makefile | 2 +-
> examples/l3fwd-power/Makefile | 2 +-
> examples/l3fwd/Makefile | 2 +-
> examples/link_status_interrupt/Makefile | 2 +-
> examples/meson.build | 6 +-
> examples/ntb/Makefile | 2 +-
> examples/packet_ordering/Makefile | 2 +-
> examples/ptpclient/Makefile | 2 +-
> examples/qos_meter/Makefile | 2 +-
> examples/qos_sched/Makefile | 2 +-
> examples/rxtx_callbacks/Makefile | 2 +-
> examples/service_cores/Makefile | 2 +-
> examples/skeleton/Makefile | 2 +-
> examples/tep_termination/Makefile | 2 +-
> examples/timer/Makefile | 2 +-
> examples/vdpa/Makefile | 2 +-
> examples/vhost/Makefile | 2 +-
> examples/vhost_blk/Makefile | 2 +-
> examples/vhost_crypto/Makefile | 2 +-
> examples/vmdq/Makefile | 2 +-
> examples/vmdq_dcb/Makefile | 2 +-
> lib/meson.build | 2 +-
> meson.build | 30 +++++++++-
> 52 files changed, 78 insertions(+), 151 deletions(-)
> delete mode 100644 buildtools/pkg-config/meson.build
> delete mode 100644 buildtools/pkg-config/set-static-linker-flags.py
Series-acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2021-03-22 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 11:21 Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 1/7] Revert "Revert "Revert "build/pkg-config: prevent overlinking""" Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 2/7] Revert "Revert "Revert "build/pkg-config: improve static linking flags""" Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 3/7] Revert "Revert "Revert "build/pkg-config: output drivers first for static build""" Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 4/7] Revert "Revert "Revert "build/pkg-config: move pkg-config file creation""" Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 5/7] Revert "Revert "Revert "build: always link whole DPDK static libraries""" Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 6/7] Revert "Revert "Revert "devtools: test static linkage with pkg-config""" Christian Ehrhardt
2021-03-22 11:21 ` [dpdk-stable] [PATCH 7/7] Regenerate meson.build changes required due to reverts Christian Ehrhardt
2021-03-22 12:00 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=922644623fd4ccbb652fde1169526b2bf4f752ae.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=hariprasad.govindharajan@intel.com \
--cc=i.maximets@ovn.org \
--cc=ian.stokes@intel.com \
--cc=james.page@canonical.com \
--cc=stable@dpdk.org \
--cc=sunil.pai.g@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).