From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E606A034F for ; Mon, 22 Mar 2021 13:00:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 404DB4003D; Mon, 22 Mar 2021 13:00:43 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mails.dpdk.org (Postfix) with ESMTP id 41FB64003D for ; Mon, 22 Mar 2021 13:00:42 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id g25so9351747wmh.0 for ; Mon, 22 Mar 2021 05:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=iGkGVaok3BOqZFOuvGkST/UQbD+UNdeo/waDhyd5LUY=; b=HgrZ0H4gHeOm1RFTgBg61/DWnq1alg1ShiR0zQQkiuA+B+Nu5to2g1e+cujd+HKfCJ L/VFGjQBtkBPWm6K96KA6X3u7XfLMT1GRDmtsFku5WlKdLE1E+uVx0YNtjHbjBTfhqc7 rZS8etlBSbqsM6/3qbFiH94uFkBEMxO8oMzheJwVHe0bXNJi6VlnmG5cv/ghQNRa9twn XVT/uYu2tunfscIxIc1h2X2yeQ5EGbSBLxjWgTqrmtZWHmQ0d+G79V1jW7TIBCESrb+i YBulzIKEydxqbIK2h9apbsx0+b+ky6IXoLwEZLch44GpKBDI4XazDjOSLR5VJ3Q1T24S R2jw== X-Gm-Message-State: AOAM530EX0MJ+vF6GXIndZW5T1O/z6Ba96LUdwFTSq36URJmYjSpPA7V BGiejO03xMWBDijNISNug8A= X-Google-Smtp-Source: ABdhPJx+4bBSU4DRW7FgBhvBrlWbAdSkA4EVePuz4en727vsMQAWp/7ifyrPls1ZFoaFKTi6/a9hhg== X-Received: by 2002:a05:600c:4fd0:: with SMTP id o16mr15773864wmq.123.1616414441399; Mon, 22 Mar 2021 05:00:41 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z82sm16596854wmg.19.2021.03.22.05.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 05:00:40 -0700 (PDT) Message-ID: <922644623fd4ccbb652fde1169526b2bf4f752ae.camel@debian.org> From: Luca Boccassi To: Christian Ehrhardt , stable@dpdk.org, Thomas Monjalon , Bruce Richardson Cc: Pai Sunil , Ilya Maximets , Stokes Ian , Govindharajan Hariprasad , James Page Date: Mon, 22 Mar 2021 12:00:40 +0000 In-Reply-To: <20210322112135.3420072-1-christian.ehrhardt@canonical.com> References: <20210322112135.3420072-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 0/7] Do not change build/link behavior on stable release X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, 2021-03-22 at 12:21 +0100, Christian Ehrhardt wrote: > Hi, > most of you have been on CC on the discussion around this already. > Background: > http://mails.dpdk.org/archives/stable/2021-March/029418.html >=20 > Summary: > - changes to DPDK linking were proposed to stable @19.11.4 and > identified to be bad > - in the 19.11.6 time-frame the responses were ok so they were > accepted in there > - but the old issue still exists and e.g. OVS is non-buildable vs > DPDK >=3D19.11.6 > - IMHO an upgrade of 19.11.x should not break how linking is done > - But, OTOH one can now say "upgrading from 19.11.6 -> 19.11.8 this > changes" >=20 > I'm unsure if this is worth an early 19.11.8 or maybe just > pushing it to git and an entry in the known-issues for 19.11.7? > But before we bike-shed over that let us discuss and agree if > taking those changes out of the 19.11.x release is the right > approach. >=20 >=20 > Christian Ehrhardt (7): > Revert "Revert "Revert "build/pkg-config: prevent overlinking""" > Revert "Revert "Revert "build/pkg-config: improve static linking > flags""" > Revert "Revert "Revert "build/pkg-config: output drivers first for > static build""" > Revert "Revert "Revert "build/pkg-config: move pkg-config file > creation""" > Revert "Revert "Revert "build: always link whole DPDK static > libraries""" > Revert "Revert "Revert "devtools: test static linkage with > pkg-config""" > Regenerate meson.build changes required due to reverts >=20 > MAINTAINERS | 2 - > app/test/meson.build | 2 +- > buildtools/pkg-config/meson.build | 59 ------------------- > .../pkg-config/set-static-linker-flags.py | 38 ------------ > devtools/test-meson-builds.sh | 2 +- > doc/build-sdk-meson.txt | 2 +- > drivers/meson.build | 2 +- > examples/bbdev_app/Makefile | 2 +- > examples/bond/Makefile | 2 +- > examples/cmdline/Makefile | 2 +- > examples/distributor/Makefile | 2 +- > examples/eventdev_pipeline/Makefile | 2 +- > examples/fips_validation/Makefile | 2 +- > examples/flow_classify/Makefile | 2 +- > examples/flow_filtering/Makefile | 2 +- > examples/helloworld/Makefile | 2 +- > examples/ioat/Makefile | 2 +- > examples/ip_fragmentation/Makefile | 2 +- > examples/ip_pipeline/Makefile | 2 +- > examples/ip_reassembly/Makefile | 2 +- > examples/ipsec-secgw/Makefile | 2 +- > examples/ipv4_multicast/Makefile | 2 +- > examples/kni/Makefile | 2 +- > examples/l2fwd-cat/Makefile | 2 +- > examples/l2fwd-crypto/Makefile | 2 +- > examples/l2fwd-event/Makefile | 2 +- > examples/l2fwd-jobstats/Makefile | 2 +- > examples/l2fwd-keepalive/Makefile | 2 +- > examples/l2fwd/Makefile | 2 +- > examples/l3fwd-acl/Makefile | 2 +- > examples/l3fwd-power/Makefile | 2 +- > examples/l3fwd/Makefile | 2 +- > examples/link_status_interrupt/Makefile | 2 +- > examples/meson.build | 6 +- > examples/ntb/Makefile | 2 +- > examples/packet_ordering/Makefile | 2 +- > examples/ptpclient/Makefile | 2 +- > examples/qos_meter/Makefile | 2 +- > examples/qos_sched/Makefile | 2 +- > examples/rxtx_callbacks/Makefile | 2 +- > examples/service_cores/Makefile | 2 +- > examples/skeleton/Makefile | 2 +- > examples/tep_termination/Makefile | 2 +- > examples/timer/Makefile | 2 +- > examples/vdpa/Makefile | 2 +- > examples/vhost/Makefile | 2 +- > examples/vhost_blk/Makefile | 2 +- > examples/vhost_crypto/Makefile | 2 +- > examples/vmdq/Makefile | 2 +- > examples/vmdq_dcb/Makefile | 2 +- > lib/meson.build | 2 +- > meson.build | 30 +++++++++- > 52 files changed, 78 insertions(+), 151 deletions(-) > delete mode 100644 buildtools/pkg-config/meson.build > delete mode 100644 buildtools/pkg-config/set-static-linker-flags.py Series-acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi