patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v1] examples/vm_power_manager: fix buffer overrun
@ 2019-04-10 12:49 David Hunt
  2019-04-18 15:14 ` [dpdk-stable] [dpdk-dev] " Pattan, Reshma
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: David Hunt @ 2019-04-10 12:49 UTC (permalink / raw)
  To: dev; +Cc: david.hunt, stable

The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS,
which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to
RTE_MAX_LCORE_FREQS.

Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
     Coverity issue: 337660

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 examples/vm_power_manager/power_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c
index aef832644..35be30d2e 100644
--- a/examples/vm_power_manager/power_manager.c
+++ b/examples/vm_power_manager/power_manager.c
@@ -143,7 +143,7 @@ power_manager_get_current_frequency(unsigned core_num)
 	rte_spinlock_lock(&global_core_freq_info[core_num].power_sl);
 	index = rte_power_get_freq(core_num);
 	rte_spinlock_unlock(&global_core_freq_info[core_num].power_sl);
-	if (index >= POWER_MGR_MAX_CPUS)
+	if (index >= RTE_MAX_LCORE_FREQS)
 		freq = 0;
 	else
 		freq = global_core_freq_info[core_num].freqs[index];
-- 
2.17.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-05-02 23:38 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 12:49 [dpdk-stable] [PATCH v1] examples/vm_power_manager: fix buffer overrun David Hunt
2019-04-18 15:14 ` [dpdk-stable] [dpdk-dev] " Pattan, Reshma
2019-04-23 10:26   ` Kevin Traynor
2019-04-23 10:31     ` Hunt, David
2019-04-23 10:42       ` Kevin Traynor
2019-04-22 21:54 ` Thomas Monjalon
2019-04-23  8:21   ` Hunt, David
2019-04-23  8:33     ` Thomas Monjalon
2019-04-23  8:35       ` Hunt, David
2019-04-23  8:53 ` [dpdk-stable] [PATCH v2] " David Hunt
2019-04-26  8:42   ` [dpdk-stable] [PATCH v3] " David Hunt
2019-05-02 23:38     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).