From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82D1EA0510 for ; Wed, 18 Dec 2019 11:21:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51245330; Wed, 18 Dec 2019 11:21:15 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 3BE0F330 for ; Wed, 18 Dec 2019 11:21:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576664472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JBdetrWwIQYbVmN2qRs7x3Q4tE7SG8TqkZn1c9aZNAk=; b=imbzexC3Ogh7Bs4RqAhU1Uu88I//DbYZ+0dy56aNCdNbudevC0G5GL75dOHwI/txcnII+E CSyiq9xhBENKIEix6f6V3CuJq4Pnf5I1FLWd+BAM37NBgXPR9KOLQ3H2BJQHAZh27u/hBv WTL5ZRTjbYTzBOnuRkB9CeAqZTmASIA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-a3OwDnmLO7OeKeT16Ipb_Q-1; Wed, 18 Dec 2019 05:21:11 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 364C5801E6C; Wed, 18 Dec 2019 10:21:10 +0000 (UTC) Received: from [10.36.118.108] (unknown [10.36.118.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id 693B160C18; Wed, 18 Dec 2019 10:21:09 +0000 (UTC) To: Somnath Kotur , stable@dpdk.org References: <20191218062411.13079-1-somnath.kotur@broadcom.com> <20191218062411.13079-19-somnath.kotur@broadcom.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <93266c18-7a4c-9f3b-33ce-141138294561@redhat.com> Date: Wed, 18 Dec 2019 10:21:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191218062411.13079-19-somnath.kotur@broadcom.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: a3OwDnmLO7OeKeT16Ipb_Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH 18.11 18/19] net/bnxt: fix deferred start of Tx queues X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 18/12/2019 06:24, Somnath Kotur wrote: > From: Kalesh AP >=20 > [ upstream commit aa2c00702bad7b2c742e11a86cb9dbbb8364fd88 ] > [ upstream commit 3955e26870bcc3336c87d1fabe6ebdf18b2a337b ] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I believe this should be 2171e66f938fb86623ad7c16f5dbad3b33938142 and 3955e2687 is patch 19/19 in this series. I will make the change when applying. >=20 > Driver should not change "deferred_start" state of the tx queues. > It should get the state in queue_setup_op() and use that value. >=20 > Since the deferred start state was being used in the packet transmit > functions to determine whether the queue has been stopped already, > introduced a per-txq flag to track queue stopped/started state. >=20 > Fixes: 9b63c6fd70e3 ("net/bnxt: support Rx/Tx queue start/stop") >=20 > Signed-off-by: Kalesh AP > Signed-off-by: Ajit Khaparde > Reviewed-by: Lance Richardson > --- > drivers/net/bnxt/bnxt_txq.c | 6 ++++++ > drivers/net/bnxt/bnxt_txq.h | 1 + > drivers/net/bnxt/bnxt_txr.c | 6 +++--- > 3 files changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c > index b76ad05..cf6ddfb 100644 > --- a/drivers/net/bnxt/bnxt_txq.c > +++ b/drivers/net/bnxt/bnxt_txq.c > @@ -113,6 +113,7 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_de= v, > =09txq->bp =3D bp; > =09txq->nb_tx_desc =3D nb_desc; > =09txq->tx_free_thresh =3D tx_conf->tx_free_thresh; > +=09txq->tx_deferred_start =3D tx_conf->tx_deferred_start; > =20 > =09rc =3D bnxt_init_tx_ring_struct(txq, socket_id); > =09if (rc) > @@ -139,6 +140,11 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_d= ev, > =20 > =09eth_dev->data->tx_queues[queue_idx] =3D txq; > =20 > +=09if (txq->tx_deferred_start) > +=09=09txq->tx_started =3D false; > +=09else > +=09=09txq->tx_started =3D true; > + > out: > =09return rc; > } > diff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h > index 720ca90..29b90bf 100644 > --- a/drivers/net/bnxt/bnxt_txq.h > +++ b/drivers/net/bnxt/bnxt_txq.h > @@ -24,6 +24,7 @@ struct bnxt_tx_queue { > =09uint8_t=09=09=09wthresh; /* Write-back threshold reg */ > =09uint32_t=09=09ctx_curr; /* Hardware context states */ > =09uint8_t=09=09=09tx_deferred_start; /* not in global dev start */ > +=09uint8_t=09=09=09tx_started; /* TX queue is started */ > =20 > =09struct bnxt=09=09*bp; > =09int=09=09=09index; > diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c > index 95272c9..348b111 100644 > --- a/drivers/net/bnxt/bnxt_txr.c > +++ b/drivers/net/bnxt/bnxt_txr.c > @@ -418,7 +418,7 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mb= uf **tx_pkts, > =09bnxt_handle_tx_cp(txq); > =20 > =09/* Tx queue was stopped; wait for it to be restarted */ > -=09if (txq->tx_deferred_start) { > +=09if (unlikely(!txq->tx_started)) { > =09=09PMD_DRV_LOG(DEBUG, "Tx q stopped;return\n"); > =09=09return 0; > =09} > @@ -448,7 +448,7 @@ int bnxt_tx_queue_start(struct rte_eth_dev *dev, uint= 16_t tx_queue_id) > =09struct bnxt_tx_queue *txq =3D bp->tx_queues[tx_queue_id]; > =20 > =09dev->data->tx_queue_state[tx_queue_id] =3D RTE_ETH_QUEUE_STATE_STARTE= D; > -=09txq->tx_deferred_start =3D false; > +=09txq->tx_started =3D true; > =09PMD_DRV_LOG(DEBUG, "Tx queue started\n"); > =20 > =09return 0; > @@ -463,7 +463,7 @@ int bnxt_tx_queue_stop(struct rte_eth_dev *dev, uint1= 6_t tx_queue_id) > =09bnxt_handle_tx_cp(txq); > =20 > =09dev->data->tx_queue_state[tx_queue_id] =3D RTE_ETH_QUEUE_STATE_STOPPE= D; > -=09txq->tx_deferred_start =3D true; > +=09txq->tx_started =3D false; > =09PMD_DRV_LOG(DEBUG, "Tx queue stopped\n"); > =20 > =09return 0; >=20