* Re: [dpdk-stable] [dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug
[not found] ` <1539844035-11524-1-git-send-email-jia.guo@intel.com>
@ 2018-11-21 17:08 ` Kevin Traynor
0 siblings, 0 replies; only message in thread
From: Kevin Traynor @ 2018-11-21 17:08 UTC (permalink / raw)
To: Jeff Guo, stephen, bruce.richardson, ferruh.yigit,
konstantin.ananyev, thomas, shaopeng.he
Cc: helin.zhang, stable
On 10/18/2018 07:27 AM, Jeff Guo wrote:
> When a device is hot-unplugged, pci_remove will be invoked unexpectedly
> before pci_release, it will caused kernel hung issue which will throw the
> error info of "Trying to free already-free IRQ XXX". And on the other hand,
> if pci_remove before pci_release, the interrupt will not got chance to be
> disabled. So this patch aim to fix this issue by adding pci_release call
> in pci_remove, it will gurranty that all pci clean up will be done before
> pci removal.
>
Hi, is this patch for the stable branch?
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> kernel/linux/igb_uio/igb_uio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c
> index fede66c..3cf394b 100644
> --- a/kernel/linux/igb_uio/igb_uio.c
> +++ b/kernel/linux/igb_uio/igb_uio.c
> @@ -570,6 +570,8 @@ igbuio_pci_remove(struct pci_dev *dev)
> {
> struct rte_uio_pci_dev *udev = pci_get_drvdata(dev);
>
> + igbuio_pci_release(&udev->info, NULL);
> +
> sysfs_remove_group(&dev->dev.kobj, &dev_attr_grp);
> uio_unregister_device(&udev->info);
> igbuio_pci_release_iomem(&udev->info);
>
^ permalink raw reply [flat|nested] only message in thread