From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 54C93A00E6 for ; Wed, 12 Jun 2019 03:34:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10EEA1D0E7; Wed, 12 Jun 2019 03:34:47 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EF6E51D0D9; Wed, 12 Jun 2019 03:34:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 18:34:40 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 11 Jun 2019 18:34:40 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 18:34:39 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 11 Jun 2019 18:34:39 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.104]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Wed, 12 Jun 2019 09:34:37 +0800 From: "Xing, Beilei" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics name Thread-Index: AQHVGebVXKCHdnueCUSJmEFWqT4NjKaXShtA Date: Wed, 12 Jun 2019 01:34:37 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CDDD5C7@SHSMSX101.ccr.corp.intel.com> References: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1559550688-9290-1-git-send-email-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics name X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand > Sent: Monday, June 3, 2019 4:31 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix dropped packets statistics > name >=20 > i40e and i40evf currently use two different names for the statistic on > dropped packets on the rx and tx sides. > Let's prefer i40evf so that all statistics are suffixed with _packets. >=20 > This also avoids a statistic name conflict in OVS. >=20 > Fixes: f4a91c38b4ad ("i40e: add extended stats") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 7fa9e1b..2384d4d 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -526,13 +526,13 @@ struct rte_i40e_xstats_name_off { > {"rx_unicast_packets", offsetof(struct i40e_eth_stats, rx_unicast)}, > {"rx_multicast_packets", offsetof(struct i40e_eth_stats, > rx_multicast)}, > {"rx_broadcast_packets", offsetof(struct i40e_eth_stats, > rx_broadcast)}, > - {"rx_dropped", offsetof(struct i40e_eth_stats, rx_discards)}, > + {"rx_dropped_packets", offsetof(struct i40e_eth_stats, rx_discards)}, > {"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats, > rx_unknown_protocol)}, > {"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)}, > {"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)}= , > {"tx_broadcast_packets", offsetof(struct i40e_eth_stats, > tx_broadcast)}, > - {"tx_dropped", offsetof(struct i40e_eth_stats, tx_discards)}, > + {"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)}, > }; >=20 > #define I40E_NB_ETH_XSTATS (sizeof(rte_i40e_stats_strings) / \ > -- > 1.8.3.1 Acked-by: Beilei Xing