From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>
Subject: Re: [dpdk-stable] [PATCH 2/2] net/i40e: fix fdir rule destroy failure
Date: Tue, 23 Jul 2019 07:11:53 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013CE093A6@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190722120639.62468-2-xiaolong.ye@intel.com>
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Monday, July 22, 2019 8:07 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; stable@dpdk.org;
> Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH 2/2] net/i40e: fix fdir rule destroy failure
>
> We should tear down the fdir when the last flow is destroyed, current logic is
> opposite to expected behavior, this patch fixes this issue.
>
> Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
> Cc: stable@dpdk.org
> Cc: xiaoyun.li@intel.com
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 3c0af70c0..c60c9e240 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4771,7 +4771,7 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
>
> /* If the last flow is destroyed, disable fdir. */
> - if (!ret && !TAILQ_EMPTY(&pf->fdir.fdir_list)) {
> + if (!ret && TAILQ_EMPTY(&pf->fdir.fdir_list)) {
> i40e_fdir_teardown(pf);
> dev->data->dev_conf.fdir_conf.mode =
> RTE_FDIR_MODE_NONE;
> --
> 2.17.0
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2019-07-23 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:06 [dpdk-stable] [PATCH 1/2] net/i40e: fix ether pattern rule for fdir Xiaolong Ye
2019-07-22 12:06 ` [dpdk-stable] [PATCH 2/2] net/i40e: fix fdir rule destroy failure Xiaolong Ye
2019-07-23 7:11 ` Xing, Beilei [this message]
2019-07-23 7:16 ` Zhang, Qi Z
2019-07-23 5:28 ` [dpdk-stable] [PATCH 1/2] net/i40e: fix ether pattern rule for fdir Xing, Beilei
2019-07-23 7:08 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013CE093A6@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).