From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73A2CA04C1 for ; Thu, 21 Nov 2019 13:30:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 325772BBD; Thu, 21 Nov 2019 13:30:31 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id AC70F2BA2; Thu, 21 Nov 2019 13:30:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 04:30:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="205057009" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.92]) ([10.237.220.92]) by fmsmga008.fm.intel.com with ESMTP; 21 Nov 2019 04:30:25 -0800 To: David Marchand , "Xueming(Steven) Li" Cc: Asaf Penso , dev , dpdk stable References: <1573570228-15676-1-git-send-email-xuemingl@mellanox.com> <1573570228-15676-2-git-send-email-xuemingl@mellanox.com> From: "Burakov, Anatoly" Message-ID: <9766477f-8efc-9143-6aaa-2dfb595aa622@intel.com> Date: Thu, 21 Nov 2019 12:30:24 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 20-Nov-19 1:25 PM, David Marchand wrote: > On Wed, Nov 20, 2019 at 3:12 AM Xueming(Steven) Li > wrote: >> >>> -----Original Message----- >>> From: David Marchand >>> Sent: Wednesday, November 20, 2019 4:47 AM >>> To: Xueming(Steven) Li ; Anatoly Burakov >>> >>> Cc: Asaf Penso ; dev ; dpdk stable >>> >>> Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element >>> size >>> >>> On Tue, Nov 12, 2019 at 3:50 PM Xueming Li >>> wrote: >>>> >>>> When resize a memory with next element, the original element size grows. >>>> If the orginal element has padding, the real inner element size didn't >>>> grow as well and this causes trailer verification failure when malloc >>>> debug enabled. >>> >>> I did not see this when running the malloc_autotest with debug enabled. >>> What is missing for me to catch it? >>> >> Yes, it happens rarely, depends on memory fragment. I only caught this in middle of a long test. >> >>> >>> Just a bit chilly to apply this series. >>> The first patch seems an optimisation. >>> The second one seems more interesting if we fix the debug mode, but I >>> suppose we can live without them in 19.11. >> Few people enable memory debug option, they are there for years. > > Had a discussion offlist with Anatoly. > Those two issues are hard to catch but the fixes are relevant and > Anatoly is confident. > I will take this in rc3. > > Series applied, thanks. > To test them, i had to modify malloc to always create padded elements :) -- Thanks, Anatoly