From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Jie Wang <jie1x.wang@intel.com>, dev@dpdk.org
Cc: xiaoyun.li@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix testpmd doesn't show RSS hash offload
Date: Fri, 9 Jul 2021 12:27:08 +0300 [thread overview]
Message-ID: <987e1c1b-a695-a8ce-1ee3-da87c9612415@oktetlabs.ru> (raw)
In-Reply-To: <20210709155717.103425-1-jie1x.wang@intel.com>
On 7/9/21 6:57 PM, Jie Wang wrote:
> This patch reapply Rx/Tx offloads configuration for all ports
> after the program configuring the device port. When the program
> configures the ports, the default Rx/Tx offloads are modified.
>
> So it is need to reapply Rx/Tx offloads configuration before
> testpmd showing offloads.
>
> Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> ---
> app/test-pmd/testpmd.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 1cdd3cdd12..7089ae216d 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2475,6 +2475,9 @@ start_port(portid_t pid)
> }
>
> if (port->need_reconfig > 0) {
> + const struct rte_eth_dev *dev = &rte_eth_devices[pi];
> + int k;
> +
> port->need_reconfig = 0;
>
> if (flow_isolate_all) {
> @@ -2508,6 +2511,18 @@ start_port(portid_t pid)
> port->need_reconfig = 1;
> return -1;
> }
> +
> + /* Apply TxRx configuration for all ports */
> + port->dev_conf.txmode = dev->data->dev_conf.txmode;
> + port->dev_conf.rxmode = dev->data->dev_conf.rxmode;
> + /* Apply Rx offloads configuration */
> + for (k = 0; k < port->dev_info.max_rx_queues; k++)
> + port->rx_conf[k].offloads =
> + port->dev_conf.rxmode.offloads;
> + /* Apply Tx offloads configuration */
> + for (k = 0; k < port->dev_info.max_tx_queues; k++)
> + port->tx_conf[k].offloads =
> + port->dev_conf.txmode.offloads;
Does testpmd really require these copies? May be the right fix is to get
rid of these copies at all and show actual
information from data->dev_conf ?
next prev parent reply other threads:[~2021-07-09 9:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 15:57 [dpdk-stable] " Jie Wang
2021-07-09 9:27 ` Andrew Rybchenko [this message]
2021-07-12 3:12 ` [dpdk-stable] [dpdk-dev] " Li, Xiaoyun
[not found] ` <DM8PR11MB5639B19DACFB1B4F4E70ACA4D1149@DM8PR11MB5639.namprd11.prod.outlook.com>
2021-07-13 3:30 ` Li, Xiaoyun
2021-07-16 9:09 ` Ferruh Yigit
2021-07-13 17:04 ` [dpdk-stable] [PATCH v2] " Jie Wang
2021-07-15 2:29 ` Li, Xiaoyun
2021-07-15 2:40 ` Li, Xiaoyun
2021-07-15 11:33 ` [dpdk-stable] [PATCH v3] " Jie Wang
2021-07-15 11:57 ` [dpdk-stable] [PATCH v4] " Jie Wang
2021-07-15 4:53 ` Li, Xiaoyun
2021-07-16 8:30 ` Li, Xiaoyun
2021-07-16 8:52 ` Ferruh Yigit
[not found] ` <DM8PR11MB5639C757A790F65CBFB647C2D1E19@DM8PR11MB5639.namprd11.prod.outlook.com>
2021-07-19 16:18 ` Ferruh Yigit
2021-07-22 11:03 ` Andrew Rybchenko
2021-08-09 8:53 ` Ferruh Yigit
2021-08-17 17:38 ` [dpdk-stable] [PATCH v5] " Jie Wang
[not found] ` <20210824171049.138208-1-jie1x.wang@intel.com>
2021-08-24 17:10 ` [dpdk-stable] [PATCH v6 2/2] " Jie Wang
[not found] ` <20210824181929.142691-1-jie1x.wang@intel.com>
2021-08-24 18:19 ` Jie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987e1c1b-a695-a8ce-1ee3-da87c9612415@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jie1x.wang@intel.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).