From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B043A04C5 for ; Fri, 15 Nov 2019 15:05:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8125F2C18; Fri, 15 Nov 2019 15:05:07 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id C6C892C18 for ; Fri, 15 Nov 2019 15:05:06 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id a15so11097067wrf.9 for ; Fri, 15 Nov 2019 06:05:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=6hqj/kydDswtW5wFInXWR8NZZ5/mU77xhCTUbwPBbcA=; b=KP3y145xTiUaY4ORUoF6FLKnLk+mqweinkP0R1e36oKZktEVAKZMs07JCYb7H/O38T LJFMsozPAHaOoXrPRgussts4/Ib19MXq3f9zjSlEDA24+NWJV17LE8ETjCd/S3hYhlDv t2tRMt+9km3t8ObgP6hJnnAFTIIofFK7dzwhVqF5zWUSh1yVVxaA4Li/Gr84L+7nOjlk VgY/DdvoFqHclty/WKgFzFWBKz8FOe7G3VhCISoSKGgaPh99yLRoY83srJaNvrSBh/d9 6VIifTtfu/hINNF0IBeqhhwMIM3r/wh1axrJpvJP1W6M9Qv/7C1yfAh2N86MWxEolK0K NWiw== X-Gm-Message-State: APjAAAUgBRmELiDspT2qlEcSwawjC9cGQ59OrYUMud6ovIgYPjim21bR Xy39DG+OqEC9HcWwe3YTdW+4hqXD X-Google-Smtp-Source: APXvYqzOJ1SxsTsS/t71INHOBRWoUtg/uMYzBMfeJu2QaD+00lVylxEOqgW7sT2k2ymdKQRmgzP7nA== X-Received: by 2002:adf:b608:: with SMTP id f8mr14581709wre.99.1573826706431; Fri, 15 Nov 2019 06:05:06 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w4sm9308717wmk.29.2019.11.15.06.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 06:05:05 -0800 (PST) Message-ID: <989973a09a5a7a88ed6b9529635099339146edaf.camel@debian.org> From: Luca Boccassi To: Tiwei Bie , Maxime Coquelin Cc: stable@dpdk.org, Zhike Wang Date: Fri, 15 Nov 2019 14:05:05 +0000 In-Reply-To: <20191115122405.GA1210@___> References: <20191115103630.17906-1-maxime.coquelin@redhat.com> <20191115122405.GA1210@___> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [17.11 LTS PATCH v2] vhost: fix vring requests validation broken if no FD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 2019-11-15 at 20:24 +0800, Tiwei Bie wrote: > On Fri, Nov 15, 2019 at 11:36:30AM +0100, Maxime Coquelin wrote: > > From: Zhike Wang < > > wangzk320@163.com > > > > >=20 > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > > so validate_msg_fds() will return error. In this case, > > the negotiation of vring message between vhost user front end and > > back end would fail, and as a result, vhost user link could NOT be > > up. > >=20 > > How to reproduce: > > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk. > > 2.Notice that inside ovs there are endless logs regarding failure > > to > > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up. > >=20 > > Fixes: 1f6147d9a01f ("vhost: fix possible denial of service by > > leaking FDs") > > Cc:=20 > > stable@dpdk.org > >=20 > >=20 > > Signed-off-by: Zhike Wang < > > wangzk320@163.com > > > > > Reviewed-by: Maxime Coquelin < > > maxime.coquelin@redhat.com > > > > > --- > > lib/librte_vhost/vhost_user.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > Reviewed-by: Tiwei Bie < > tiwei.bie@intel.com > > >=20 > Thanks! > Tiwei Thanks, applied --=20 Kind regards, Luca Boccassi