patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Natanael Copa" <ncopa@alpinelinux.org>
Cc: <stable@dpdk.org>, <dev@dpdk.org>,
	"Rahul Lakkireddy" <rahul.lakkireddy@chelsio.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 2/8] net/cxgbe: fix uint build error with musllibc
Date: Fri, 6 Nov 2020 10:24:09 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35C613FD@smartserver.smartshare.dk> (raw)
In-Reply-To: <20201105211716.25181-3-ncopa@alpinelinux.org>

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Natanael Copa
> Sent: Thursday, November 5, 2020 10:17 PM
> 
> Improve portability by replacing non-standard 'uint' with 'unsigned
> int'
> 
> This solves the build error with musl libc:
> 
> In file included from ../drivers/net/cxgbe/cxgbe.h:9,
>                  from ../drivers/net/cxgbe/cxgbe_ethdev.c:37:
> ../drivers/net/cxgbe/base/common.h:201:4: error: unknown type name
> 'uint'
>   201 |    uint synmapen:1; /* SYN Map Enable */
>       |    ^~~~
> 
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
>  drivers/net/cxgbe/base/common.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/cxgbe/base/common.h
> b/drivers/net/cxgbe/base/common.h
> index 8fe8e2a36..c1d09dfad 100644
> --- a/drivers/net/cxgbe/base/common.h
> +++ b/drivers/net/cxgbe/base/common.h
> @@ -201,15 +201,15 @@ struct rss_params {
>  	unsigned int mode;			/* RSS mode */
>  	union {
>  		struct {
> -			uint synmapen:1;	/* SYN Map Enable */
> -			uint syn4tupenipv6:1;	/* en 4-tuple IPv6 SYNs hash
> */
> -			uint syn2tupenipv6:1;	/* en 2-tuple IPv6 SYNs hash
> */
> -			uint syn4tupenipv4:1;	/* en 4-tuple IPv4 SYNs hash
> */
> -			uint syn2tupenipv4:1;	/* en 2-tuple IPv4 SYNs hash
> */
> -			uint ofdmapen:1;	/* Offload Map Enable */
> -			uint tnlmapen:1;	/* Tunnel Map Enable */
> -			uint tnlalllookup:1;	/* Tunnel All Lookup */
> -			uint hashtoeplitz:1;	/* use Toeplitz hash */
> +			unsigned int synmapen:1;	/* SYN Map Enable */
> +			unsigned int syn4tupenipv6:1;	/* en 4-tuple IPv6 SYNs
> hash */
> +			unsigned int syn2tupenipv6:1;	/* en 2-tuple IPv6 SYNs
> hash */
> +			unsigned int syn4tupenipv4:1;	/* en 4-tuple IPv4 SYNs
> hash */
> +			unsigned int syn2tupenipv4:1;	/* en 2-tuple IPv4 SYNs
> hash */
> +			unsigned int ofdmapen:1;	/* Offload Map Enable
> */
> +			unsigned int tnlmapen:1;	/* Tunnel Map Enable */
> +			unsigned int tnlalllookup:1;	/* Tunnel All Lookup */
> +			unsigned int hashtoeplitz:1;	/* use Toeplitz hash */
>  		} basicvirtual;
>  	} u;
>  };
> --
> 2.29.2
> 

Reviewed-by: Morten Brørup <mb@smartsharesystems.com>


  reply	other threads:[~2020-11-06  9:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <18966392.1bK43UoomU@xps>
     [not found] ` <20201105211716.25181-1-ncopa@alpinelinux.org>
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 1/8] app/testpmd: fix uint build error with musl libc Natanael Copa
2020-11-06  9:22     ` [dpdk-stable] [dpdk-dev] [PATCH v4 1/8] app/testpmd: fix uint build error withmusl libc Morten Brørup
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 2/8] net/cxgbe: fix uint build error with musl libc Natanael Copa
2020-11-06  9:24     ` Morten Brørup [this message]
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 3/8] bus/pci: add fallback for out* for non GNU libc Natanael Copa
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 4/8] bus/dpaa: use warn instead of error to improve portability Natanael Copa
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 5/8] bus/dpaa: fix detection of 64 bit arch Natanael Copa
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 6/8] common/dpaax: build fix for musl libc Natanael Copa
2020-11-05 21:17   ` [dpdk-stable] [PATCH v4 8/8] eal: add missing include to fix build with " Natanael Copa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35C613FD@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=dev@dpdk.org \
    --cc=ncopa@alpinelinux.org \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).