patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Luca Boccassi" <luca.boccassi@gmail.com>
Cc: <stable@dpdk.org>, <dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>
Subject: RE: 20.11.7 patches review and test
Date: Mon, 28 Nov 2022 13:07:40 +0100	[thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D8751B@smartserver.smartshare.dk> (raw)
In-Reply-To: <CAMw=ZnTH6DOxvobXzpe02OGgTU9kQJxGqpdYftu6U64WkMPw_A@mail.gmail.com>

> From: Luca Boccassi [mailto:luca.boccassi@gmail.com]
> Sent: Monday, 28 November 2022 12.55
> 
> On Mon, 28 Nov 2022 at 11:35, Morten Brørup <mb@smartsharesystems.com>
> wrote:
> >
> > +CC Andrew Rybchenko as co-signer on the mempool patch in mainline.
> >
> > > From: luca.boccassi@gmail.com [mailto:luca.boccassi@gmail.com]
> > > Sent: Monday, 28 November 2022 11.53

[...]

> > >       mempool: fix get objects from mempool with cache
> >
> > Reviewed stable release patch [1], comparing it to the accepted
> mainline patch [2].
> >
> > [1]: https://git.dpdk.org/dpdk-
> stable/commit/?h=20.11&id=26cb4c81b552594292f7c744afb904f01700dfe8
> > [2]:
> https://patchwork.dpdk.org/project/dpdk/patch/20221007104450.2567961-1-
> andrew.rybchenko@oktetlabs.ru/
> >
> > This is not correct:
> > +               __MEMPOOL_STAT_ADD(mp, get_success_bulk, 1);
> > +               __MEMPOOL_STAT_ADD(mp, get_success_objs, n);
> >
> > The old macro did more, so it should be:
> > +               __MEMPOOL_STAT_ADD(mp, get_success, n);
> >
> > This is only visible if built with RTE_LIBRTE_MEMPOOL_DEBUG.
> >
> > Besides that, it looks perfectly good to me.
> 
> Can you test a patch and send it?

Extremely busy these days... Not sure I can make it within the deadline.

Alternatively, consider omitting the patch. It only fixes some performance issues for certain use cases.

-Morten


  reply	other threads:[~2022-11-28 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 10:52 luca.boccassi
2022-11-28 11:35 ` Morten Brørup
2022-11-28 11:55   ` Luca Boccassi
2022-11-28 12:07     ` Morten Brørup [this message]
2023-04-11  7:22       ` Morten Brørup
2023-04-11  9:58         ` Luca Boccassi
2022-12-11 16:15 ` Ali Alnubani
2022-12-12 20:00   ` Luca Boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D8751B@smartserver.smartshare.dk \
    --to=mb@smartsharesystems.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=luca.boccassi@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).