patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Harold Huang <baymaxhuang@gmail.com>, <dev@dpdk.org>,
	<jiayu.hu@intel.com>, Ophir Munk <ophirmu@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>
Cc: <stable@dpdk.org>, Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH] net/tap: do not include l2 header in gso size when compared with mtu
Date: Fri, 20 May 2022 23:08:11 +0100	[thread overview]
Message-ID: <99e9b817-d87a-df99-4334-1a0cc482d627@amd.com> (raw)
In-Reply-To: <CAHJXk3bzAFgNd9VktYtaST4VLOM0ypkR8ASS=i0o8VBjD809MA@mail.gmail.com>

On 3/8/2022 2:35 PM, Harold Huang wrote:
> On Mon, Feb 28, 2022 at 4:27 PM Harold Huang <baymaxhuang@gmail.com> wrote:
>>
>> The gso size is calculated with all of the headers and payload. As a
>> result, the l2 header should not be included when comparing gso size
>> with mtu.
>>
>> Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
>> Cc: stable@dpdk.org
>> Signed-off-by: Harold Huang <baymaxhuang@gmail.com>
>> ---
>>   drivers/net/tap/rte_eth_tap.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
>> index f1b48cae82..2b561d232c 100644
>> --- a/drivers/net/tap/rte_eth_tap.c
>> +++ b/drivers/net/tap/rte_eth_tap.c
>> @@ -731,7 +731,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
>>                                          mbuf_in->l4_len;
>>                          tso_segsz = mbuf_in->tso_segsz + hdrs_len;
>>                          if (unlikely(tso_segsz == hdrs_len) ||
>> -                               tso_segsz > *txq->mtu) {
>> +                               tso_segsz > *txq->mtu + mbuf_in->l2_len) {
>>                                  txq->stats.errs++;
>>                                  break;
>>                          }
>> --
>> 2.27.0
>>
> 
> Hi, Jiayu,
> 
> This is the only example in the driver to use GSO. I think it is
> important for us to calculate a correct GSO size. I see you are the
> GSO lib maintainer, could you please help review this patch?


Hi Jiayu, Ophir,

Can you please review this patch?

For reference, patchwork link:
https://patches.dpdk.org/project/dpdk/patch/20220228082724.1646930-1-baymaxhuang@gmail.com/

Thanks,
ferruh

  parent reply	other threads:[~2022-05-20 22:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  8:27 Harold Huang
2022-03-04 16:30 ` Ferruh Yigit
2022-03-08 14:35 ` Harold Huang
2022-03-18  9:22   ` Ophir Munk
2022-03-21  2:52     ` Harold Huang
2022-05-20 22:08   ` Ferruh Yigit [this message]
2022-05-24 14:01     ` Ophir Munk
2023-10-17 16:47   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99e9b817-d87a-df99-4334-1a0cc482d627@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=baymaxhuang@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=ophirmu@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).