* [dpdk-stable] [PATCH] net/ice: correct VSI context
@ 2019-12-14 6:14 Beilei Xing
2019-12-30 3:38 ` Wu, Jingjing
0 siblings, 1 reply; 4+ messages in thread
From: Beilei Xing @ 2019-12-14 6:14 UTC (permalink / raw)
To: jingjing.wu, dev, qi.z.zhang; +Cc: stable
There'll always be a MDD event triggered when adding
a FDIR rule. The root cause is 'LAN enable' is not
configured during control VSI setup.
Besides, correct FDIR fields for both main VSI and
control VSI.
Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine")
Cc: stable@dpdk.org
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/ice/ice_ethdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index de189da..8b34ed9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1573,7 +1573,7 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
cfg = ICE_AQ_VSI_PROP_SECURITY_VALID |
ICE_AQ_VSI_PROP_FLOW_DIR_VALID;
vsi_ctx.info.valid_sections |= rte_cpu_to_le_16(cfg);
- cfg = ICE_AQ_VSI_FD_ENABLE | ICE_AQ_VSI_FD_PROG_ENABLE;
+ cfg = ICE_AQ_VSI_FD_ENABLE;
vsi_ctx.info.fd_options = rte_cpu_to_le_16(cfg);
vsi_ctx.info.max_fd_fltr_dedicated =
rte_cpu_to_le_16(hw->func_caps.fd_fltr_guar);
@@ -1601,9 +1601,10 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
cfg = ICE_AQ_VSI_PROP_FLOW_DIR_VALID;
vsi_ctx.info.valid_sections |= rte_cpu_to_le_16(cfg);
- cfg = ICE_AQ_VSI_FD_ENABLE | ICE_AQ_VSI_FD_PROG_ENABLE;
+ cfg = ICE_AQ_VSI_FD_PROG_ENABLE;
vsi_ctx.info.fd_options = rte_cpu_to_le_16(cfg);
vsi_ctx.info.sw_id = hw->port_info->sw_id;
+ vsi_ctx.info.sw_flags2 = ICE_AQ_VSI_SW_FLAG_LAN_ENA;
ret = ice_vsi_config_tc_queue_mapping(vsi,
&vsi_ctx.info,
ICE_DEFAULT_TCMAP);
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] net/ice: correct VSI context
2019-12-14 6:14 [dpdk-stable] [PATCH] net/ice: correct VSI context Beilei Xing
@ 2019-12-30 3:38 ` Wu, Jingjing
2020-01-03 7:41 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
0 siblings, 1 reply; 4+ messages in thread
From: Wu, Jingjing @ 2019-12-30 3:38 UTC (permalink / raw)
To: Xing, Beilei, dev, Zhang, Qi Z; +Cc: stable
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Saturday, December 14, 2019 2:14 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org
> Subject: [PATCH] net/ice: correct VSI context
>
> There'll always be a MDD event triggered when adding
> a FDIR rule. The root cause is 'LAN enable' is not
> configured during control VSI setup.
> Besides, correct FDIR fields for both main VSI and
> control VSI.
>
> Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine")
> Cc: stable@dpdk.org
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice: correct VSI context
2019-12-30 3:38 ` Wu, Jingjing
@ 2020-01-03 7:41 ` Ye Xiaolong
0 siblings, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2020-01-03 7:41 UTC (permalink / raw)
To: Wu, Jingjing; +Cc: Xing, Beilei, dev, Zhang, Qi Z, stable
On 12/30, Wu, Jingjing wrote:
>
>
>> -----Original Message-----
>> From: Xing, Beilei <beilei.xing@intel.com>
>> Sent: Saturday, December 14, 2019 2:14 PM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: stable@dpdk.org
>> Subject: [PATCH] net/ice: correct VSI context
>>
>> There'll always be a MDD event triggered when adding
>> a FDIR rule. The root cause is 'LAN enable' is not
>> configured during control VSI setup.
>> Besides, correct FDIR fields for both main VSI and
>> control VSI.
>>
>> Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH] net/ice: correct VSI context
@ 2019-12-14 6:11 Beilei Xing
0 siblings, 0 replies; 4+ messages in thread
From: Beilei Xing @ 2019-12-14 6:11 UTC (permalink / raw)
To: beilei.xing; +Cc: stable
There'll always be a MDD event triggered when adding
a FDIR rule. The root cause is 'LAN enable' is not
configured during control VSI setup.
Besides, correct FDIR fields for both main VSI and
control VSI.
Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine")
Cc: stable@dpdk.org
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/ice/ice_ethdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index de189da..8b34ed9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1573,7 +1573,7 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
cfg = ICE_AQ_VSI_PROP_SECURITY_VALID |
ICE_AQ_VSI_PROP_FLOW_DIR_VALID;
vsi_ctx.info.valid_sections |= rte_cpu_to_le_16(cfg);
- cfg = ICE_AQ_VSI_FD_ENABLE | ICE_AQ_VSI_FD_PROG_ENABLE;
+ cfg = ICE_AQ_VSI_FD_ENABLE;
vsi_ctx.info.fd_options = rte_cpu_to_le_16(cfg);
vsi_ctx.info.max_fd_fltr_dedicated =
rte_cpu_to_le_16(hw->func_caps.fd_fltr_guar);
@@ -1601,9 +1601,10 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
cfg = ICE_AQ_VSI_PROP_FLOW_DIR_VALID;
vsi_ctx.info.valid_sections |= rte_cpu_to_le_16(cfg);
- cfg = ICE_AQ_VSI_FD_ENABLE | ICE_AQ_VSI_FD_PROG_ENABLE;
+ cfg = ICE_AQ_VSI_FD_PROG_ENABLE;
vsi_ctx.info.fd_options = rte_cpu_to_le_16(cfg);
vsi_ctx.info.sw_id = hw->port_info->sw_id;
+ vsi_ctx.info.sw_flags2 = ICE_AQ_VSI_SW_FLAG_LAN_ENA;
ret = ice_vsi_config_tc_queue_mapping(vsi,
&vsi_ctx.info,
ICE_DEFAULT_TCMAP);
--
2.5.5
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-03 7:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-14 6:14 [dpdk-stable] [PATCH] net/ice: correct VSI context Beilei Xing
2019-12-30 3:38 ` Wu, Jingjing
2020-01-03 7:41 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
-- strict thread matches above, loose matches on Subject: below --
2019-12-14 6:11 [dpdk-stable] " Beilei Xing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).