From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20056.outbound.protection.outlook.com [40.107.2.56]) by dpdk.org (Postfix) with ESMTP id A1CA62B9A for ; Thu, 17 Jan 2019 07:57:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=guoWlRivNAg9LCup3Y6Lkw7V/OvZijOTRyMzefiY20k=; b=LBGdutKnpF9e7ZOGorT5c3laqY1UafxiA31AF3B6EbFc3xNoR9luGybaVVIg8T7QU5INcd96J4DgDDhlPyBOpRgZwieIUErZKNtHSpHOWmqe60wRiOrzr8bfKzZffVbSOXz1KD2lC/4kepp5j8xwvUZ82puvGltNck07MyPmE9k= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4091.eurprd05.prod.outlook.com (52.134.68.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Thu, 17 Jan 2019 06:57:53 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1da8:cd09:4e78:111c%2]) with mapi id 15.20.1537.018; Thu, 17 Jan 2019 06:57:53 +0000 From: Yongseok Koh To: Nikhil Rao CC: dpdk stable Thread-Topic: [PATCH 17.11] eventdev: fix eth Rx adapter hotplug incompatibility Thread-Index: AQHUriN4v+u4RhO7N0SUBKMeM7EVa6WzB6YA Date: Thu, 17 Jan 2019 06:57:53 +0000 Message-ID: <9C35488E-A31C-4953-B49C-B1DF37605D43@mellanox.com> References: <1547701973-146997-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1547701973-146997-1-git-send-email-nikhil.rao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4091; 6:19yeeIFh4gj0C+g9jgWmYNdiPr20yx4JUQJCG5CwYGkc2LQ85j5uyUsuBJJHcRkMbsPdD8gEdCij1boujveqe85FFfq8MYZroTXyz45/ysTbwY2x+JIuVbAPO90J6LNbOXG1xytNyRI0vf74auUHuzHBRK2B06w1M1O8H/BdqC7ltTrmTGBY0ptgT6DtIDjovx6m2JrGDYZ8Zl0vcKl23jmyVq8dCMcIIfp4oURhVRXINpf2uuAbVWh/u48ylKqUbf3POw5KRzTvI9vnlWYEMrPvjehIqLyEQVmLYUo30RwXhYzUfTjSboVEJwfoVuPP0DV7/wM0vTwWf7frsC4gGXZqBDrys0uMt0Njdl9HsYqKDW5kE1yz5v63jp830IAy4+JCkCp7TTp1gUjskTR+FYR1mMeJoMs7xguamS023qm6AMbVEXsBxJ6uOYmKFh+opwtAJowD5GYQiTtJI0/2tw==; 5:/yYOK3jHX0Ii1M/C3EZ9BemdDgEpCzWaA+l3v/jNgKTsNuiv00f3yQ3hDhgtgabFU4hsAcEsKqwiVpD48Aj3V5EPZZ5W0fMQHu/P8yyJ+Muj6/confbRGkwYymAFSyDKwKqpZntqMYg+ENBm9JBeh85UYPTSjAgyg7JMqHgE/7xbYZnwlM/HYi6HNKNYl3jW5LUW8q28rp5LqrfOwEt1/Q==; 7:G5AlmHZtur+KIGk8r8bP0e3+RDtso9hZDbEZ1ry6b2XBK7ngHUSLgf/1JisurR0/S2GsyimgQl2MthYrtacWchp/gKyoL0dqAko+bRMFswy5xmIcFbcHCyBzslAbaE2AUIP1r6m7brK2b/97ZqQxkw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 53ccc943-29f6-4892-d886-08d67c491a17 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4091; x-ms-traffictypediagnostic: DB3PR0502MB4091: x-microsoft-antispam-prvs: x-forefront-prvs: 0920602B08 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(136003)(396003)(376002)(346002)(199004)(189003)(53936002)(105586002)(106356001)(6512007)(36756003)(3846002)(6116002)(4326008)(86362001)(66066001)(6436002)(6246003)(6486002)(2906002)(229853002)(97736004)(53546011)(6506007)(25786009)(76176011)(102836004)(6916009)(5660300001)(99286004)(486006)(316002)(186003)(256004)(14444005)(81166006)(8676002)(81156014)(26005)(7736002)(8936002)(305945005)(476003)(2616005)(446003)(11346002)(478600001)(33656002)(14454004)(68736007)(83716004)(71200400001)(71190400001)(82746002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4091; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: G6gRwclM3gnL/4sMU1hL4dJSVQvk7rvJ7VeBpoblzZEqIJsCJBagxGH1o1AYFF0OROoi1SFnhulV/nDNv96DzHXcEjojQ7FPQFQlfBA68Nj8lwvAHdbH/w9/lV7clTL2wiIcVxqz4D/GdRKaUM6AM+bV3mSFAk/HnyzGaTVvJ/7dURdVdPpJ8QTShm5cRZHpE9b3Nx0ZKJx4VWtAVrKmYeejsIrQXN+9AOdZJKxxKCS4ji8bWHsx+/P1gcLLhQeJzq9gZsnUKagABQd0Lk8SQdHgTa60WQMRig/aEwXmQKcobwS6bC193xeoSAYV4wy/kAvuIjFf3hRf8wvo3sXx4vGc7Un7EkklsqHiiN4kHzeLb6bhZTRRLKRVh1l+KvEs8hCEtSHQBEoO6hxxg/AZcIlvu+wl2Wvujs1HBWj8N2w= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <0872771DB78A924F9B43FCB154898BE3@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53ccc943-29f6-4892-d886-08d67c491a17 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 06:57:53.1020 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4091 Subject: Re: [dpdk-stable] [PATCH 17.11] eventdev: fix eth Rx adapter hotplug incompatibility X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 06:57:54 -0000 > On Jan 16, 2019, at 9:12 PM, Nikhil Rao wrote: >=20 > [ backported from upstream commit d7b5f102c4781bd2e9a952243eb59cffe135b01= c ] >=20 > Use RTE_MAX_ETHPORTS instead of rte_eth_dev_count_total() > when allocating eth Rx adapter's per-eth device data structure > to account for hotplugged devices. >=20 > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Nikhil Rao > Acked-by: Jerin Jacob > --- Applied to stable/17.11 Thanks, Yongseok > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_= eventdev/rte_event_eth_rx_adapter.c > index de4cf73..3688b8e 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -900,7 +900,7 @@ static int add_rx_queue(struct rte_event_eth_rx_adapt= er *rx_adapter, > rx_adapter->conf_arg =3D conf_arg; > strcpy(rx_adapter->mem_name, mem_name); > rx_adapter->eth_devices =3D rte_zmalloc_socket(rx_adapter->mem_name, > - rte_eth_dev_count() * > + RTE_MAX_ETHPORTS * > sizeof(struct eth_device_info), 0, > socket_id); > rte_convert_rss_key((const uint32_t *)default_rss_key, > @@ -913,7 +913,7 @@ static int add_rx_queue(struct rte_event_eth_rx_adapt= er *rx_adapter, > return -ENOMEM; > } > rte_spinlock_init(&rx_adapter->rx_lock); > - for (i =3D 0; i < rte_eth_dev_count(); i++) > + for (i =3D 0; i < RTE_MAX_ETHPORTS; i++) > rx_adapter->eth_devices[i].dev =3D &rte_eth_devices[i]; >=20 > event_eth_rx_adapter[id] =3D rx_adapter; > --=20 > 1.8.3.1 >=20