From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yskoh@mellanox.com>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
(mail-eopbgr130051.outbound.protection.outlook.com [40.107.13.51])
by dpdk.org (Postfix) with ESMTP id A3E1B1B58B
for <stable@dpdk.org>; Fri, 30 Nov 2018 19:01:29 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=SiKWenqMhSBiHxVJRUFdlpunXW8p5lrtGCPCGlCEzzY=;
b=vVWrygYpVceDqhmAB+Rzg00wsFQw/6PwOkujhbn5rraniJ4xfLN05YppWAhCFJxMbpxndoY/tlb3W7KZuUump7DyH/mpT5Ix6UeRFQef5Pb8kXnVlcg1c3PoAe7GRzPzBH3RoAT8v3Y9JGZTpX8+FWi96bknGHEqR829kbgnoJc=
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by
DB3PR0502MB3978.eurprd05.prod.outlook.com (52.134.65.140) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1361.19; Fri, 30 Nov 2018 18:01:28 +0000
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com
([fe80::dcbc:4578:3018:50f3]) by DB3PR0502MB3980.eurprd05.prod.outlook.com
([fe80::dcbc:4578:3018:50f3%4]) with mapi id 15.20.1361.022; Fri, 30 Nov 2018
18:01:27 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: Tiwei Bie <tiwei.bie@intel.com>
CC: Maxime Coquelin <maxime.coquelin@redhat.com>, dpdk stable <stable@dpdk.org>
Thread-Topic: patch 'net/virtio: fix unchecked return value' has been queued
to LTS release 17.11.5
Thread-Index: AQHUiMD4bHHksdHiSk6iP/0Tx7kE06Vom+oA
Date: Fri, 30 Nov 2018 18:01:27 +0000
Message-ID: <9EAA6F89-2A57-404B-AFD1-E89E2D92E66F@mellanox.com>
References: <20181129231202.30436-1-yskoh@mellanox.com>
<20181129231202.30436-106-yskoh@mellanox.com> <20181130152345.GA13586@debian>
In-Reply-To: <20181130152345.GA13586@debian>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is )
smtp.mailfrom=yskoh@mellanox.com;
x-originating-ip: [209.17.37.123]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3978;
6:Q8aG7Y1057m3EPduLZfbWncF5gpx+5LpqTyHZDbCM70zakXXoMC+0woKjHzwsO+o1sx/NJwPCz3A75c4EMUyoV1AATRGv9TIrSfOgnV41wezFJ3G79akfVtHYSAkmXJcx/kG4xCphdOZ9PkAyQidVkUCTiTGI1scW//jKdKYdI5x+bzBb/AhcpH7bzGcLG7eBh+0bKY7M+aocipq1A+IySD42jwvdSonAFa88j9GSimuEoeHSZ0tmg5sVckMemQlErfMadd6vFNuB0w23Cu8UR05n+4j6w9BbBca28bLqN1ArgzFypFUUNaVynjCIEhXYDonpsq5hzGMUS//WyE+5y52yl8M3F8A244+5CZ15xkBYrgwFBUz+3cxvBh3wkPaPL1Iqicp1ENI1WStNIHVnCKEkkdbr7OS9qOfSmUyNlQi6WUvYqxtvx/SkMxwCYfIyBO2BzCoFFTO9pz7YI9mEA==;
5:Z60lYuj9zSj0dojE0CKUg39UowZ7dTQXlCOOBiDM2jaCINxAmLip3sIpCjvcX1/6M/BYFHawKt39jp2LNECVrvm4E9dsR7XhUSkribKHDWneeH+PaCLv3AdIQNbGEPwRPzhNI9t1l1a7pfuHsIdTf6geZYwFl+WUPNW4Ij9vKvk=;
7:GPqB3MqXizC7F2Xil8Efuy4i2cJIipkIPI4ZtFi8XFTB9HNWum3TcnoPvGB/CWQSjfNXD5iZvZEf6wevwm4kJRvXuYRtJlN8GjpK5586gLJznZJ7ag3VR41XhIGydmIzzrUPdRMySo6JUZQPmO8sTA==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 3f84570f-3572-4adf-1952-08d656edd9ba
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);
SRVR:DB3PR0502MB3978;
x-ms-traffictypediagnostic: DB3PR0502MB3978:
x-microsoft-antispam-prvs: <DB3PR0502MB3978FCE3C14A05341C564C04C3D30@DB3PR0502MB3978.eurprd05.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231453)(999002)(944501410)(4982022)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095);
SRVR:DB3PR0502MB3978; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3978;
x-forefront-prvs: 087223B4DA
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(366004)(39860400002)(136003)(376002)(346002)(396003)(69234005)(28163001)(199004)(189003)(68736007)(966005)(186003)(229853002)(478600001)(76176011)(6512007)(6306002)(25786009)(99286004)(54906003)(97736004)(53936002)(316002)(8676002)(45080400002)(81156014)(81166006)(4001150100001)(33656002)(6916009)(36756003)(102836004)(8936002)(53546011)(2906002)(3846002)(6116002)(106356001)(476003)(14454004)(66066001)(82746002)(71200400001)(83716004)(26005)(71190400001)(6506007)(305945005)(486006)(5660300001)(446003)(7736002)(105586002)(11346002)(2616005)(6486002)(6436002)(4326008)(6246003)(575784001)(86362001)(256004);
DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3978;
H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
x-microsoft-antispam-message-info: DF0RZ3dW8ceb3RA3S3FktE3bDn3/A32cI5xtbydb9Mg4P3igc9I96SDEWMRWd3u62KaWaA2Av0D32Z5CaWXHIMntN5wb6oin7tX+YyrlZvzZysSEYu9RHNI3w0GBBWh4hnnfTyuHTjQHvCNR9D9nfH6xpEf3Oqeft68lsb5oJ9BIZ4wrty9yRRydoCNgIsOJt38zUACYLh4t8V0hjaWeDJEFc883HtPNHvJUKVppOsmkWhye79vGk3IIAQjld8Nn2UpYGQ1iIwfY/C4yw2RrWPeF06VThHy7+xmEfhfn8VH4Vj6kCPBjbazrsxZDOexB+11S+GJTyQ0U1K6eknMVUM3voxFMcEEvdPLLsW5BB1A=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <892F343778292948A69E2CD816D79DFE@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f84570f-3572-4adf-1952-08d656edd9ba
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2018 18:01:27.8031 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3978
Subject: Re: [dpdk-stable] patch 'net/virtio: fix unchecked return value'
has been queued to LTS release 17.11.5
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Nov 2018 18:01:30 -0000
> On Nov 30, 2018, at 7:23 AM, Tiwei Bie <tiwei.bie@intel.com> wrote:
>=20
> On Thu, Nov 29, 2018 at 03:11:40PM -0800, Yongseok Koh wrote:
>> Hi,
>>=20
>> FYI, your patch has been queued to LTS release 17.11.5
>>=20
>> Note it hasn't been pushed to https://emea01.safelinks.protection.outloo=
k.com/?url=3Dhttp%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable&data=3D02%7C0=
1%7Cyskoh%40mellanox.com%7C801f0fcce7f94e96370c08d656d814a0%7Ca652971c7d2e4=
d9ba6a4d149256f461b%7C0%7C0%7C636791883479064321&sdata=3D3yB8cI3v5wGyFI=
HIi%2FnPc0PpoLmIi%2F3o63dcgAd9EzY%3D&reserved=3D0 yet.
>> It will be pushed if I get no objections before 12/01/18. So please
>> shout if anyone has objections.
>=20
> Hi,
>=20
> This patch can't be backported, as it depends on some API
> change in newer release.
This patch could be applied cleanly but I'll remove it.
Thanks for confirming,
Yongseok
>>=20
>> Also note that after the patch there's a diff of the upstream commit vs =
the patch applied
>> to the branch. If the code is different (ie: not only metadata diffs), d=
ue for example to
>> a change in context or macro names, please double check it.
>>=20
>> Thanks.
>>=20
>> Yongseok
>>=20
>> ---
>> From 85fa65d2e2a0b9e0ac4baa0ff2c5f99bed5427ec Mon Sep 17 00:00:00 2001
>> From: Tiwei Bie <tiwei.bie@intel.com>
>> Date: Wed, 7 Nov 2018 17:01:01 +0800
>> Subject: [PATCH] net/virtio: fix unchecked return value
>>=20
>> [ upstream commit ecfae1510edc1391285aa566a2d31e7eae8fc6d2 ]
>>=20
>> Coverity issue: 302861
>> Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
>>=20
>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> drivers/net/virtio/virtio_pci.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio=
_pci.c
>> index 89986c335..249ec6d3a 100644
>> --- a/drivers/net/virtio/virtio_pci.c
>> +++ b/drivers/net/virtio/virtio_pci.c
>> @@ -658,9 +658,15 @@ virtio_read_caps(struct rte_pci_device *dev, struct=
virtio_hw *hw)
>> hw->common_cfg =3D get_cfg_addr(dev, &cap);
>> break;
>> case VIRTIO_PCI_CAP_NOTIFY_CFG:
>> - rte_pci_read_config(dev, &hw->notify_off_multiplier,
>> + ret =3D rte_pci_read_config(dev,
>> + &hw->notify_off_multiplier,
>> 4, pos + sizeof(cap));
>> - hw->notify_base =3D get_cfg_addr(dev, &cap);
>> + if (ret !=3D 4)
>> + PMD_INIT_LOG(DEBUG,
>> + "failed to read notify_off_multiplier, ret %d",
>> + ret);
>> + else
>> + hw->notify_base =3D get_cfg_addr(dev, &cap);
>> break;
>> case VIRTIO_PCI_CAP_DEVICE_CFG:
>> hw->dev_cfg =3D get_cfg_addr(dev, &cap);
>> --=20
>> 2.11.0
>>=20
>> ---
>> Diff of the applied patch vs upstream commit (please double-check if no=
n-empty:
>> ---
>> --- - 2018-11-29 15:01:49.832061811 -0800
>> +++ 0106-net-virtio-fix-unchecked-return-value.patch 2018-11-29 15:01:45=
.278957000 -0800
>> @@ -1,11 +1,12 @@
>> -From ecfae1510edc1391285aa566a2d31e7eae8fc6d2 Mon Sep 17 00:00:00 2001
>> +From 85fa65d2e2a0b9e0ac4baa0ff2c5f99bed5427ec Mon Sep 17 00:00:00 2001
>> From: Tiwei Bie <tiwei.bie@intel.com>
>> Date: Wed, 7 Nov 2018 17:01:01 +0800
>> Subject: [PATCH] net/virtio: fix unchecked return value
>>=20
>> +[ upstream commit ecfae1510edc1391285aa566a2d31e7eae8fc6d2 ]
>> +
>> Coverity issue: 302861
>> Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
>> -Cc: stable@dpdk.org
>>=20
>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> @@ -14,10 +15,10 @@
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>=20
>> diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio=
_pci.c
>> -index 21110cd69..c8883c32e 100644
>> +index 89986c335..249ec6d3a 100644
>> --- a/drivers/net/virtio/virtio_pci.c
>> +++ b/drivers/net/virtio/virtio_pci.c
>> -@@ -614,9 +614,15 @@ virtio_read_caps(struct rte_pci_device *dev, struc=
t virtio_hw *hw)
>> +@@ -658,9 +658,15 @@ virtio_read_caps(struct rte_pci_device *dev, struc=
t virtio_hw *hw)
>> hw->common_cfg =3D get_cfg_addr(dev, &cap);
>> break;
>> case VIRTIO_PCI_CAP_NOTIFY_CFG: