From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A2394597A for ; Fri, 13 Sep 2024 11:05:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 100E7402BA; Fri, 13 Sep 2024 11:05:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EFEEC4025E for ; Fri, 13 Sep 2024 11:05:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726218343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PdXuev74Pd1olfgKz61gpaAiNbBkmr/G3yeqtDkh8Go=; b=aPBLDr/jBK9rqsYT/4gMEcmfZLyVyqNEWM+mhoxpRfOd2TIL951F/5OBzxQfCz/dLaAwpN AG2Q3dHiiWCzEgP+suLcbnUhQSXQqBar7biwAbihRSQxW0QMUTDWKm7EAitGzWkRUpBapb RkWA7p7dzXHOcklfhfWNE3UAluziFOk= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-RqgBwwmMOjuv7DwiatjyAQ-1; Fri, 13 Sep 2024 05:05:42 -0400 X-MC-Unique: RqgBwwmMOjuv7DwiatjyAQ-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a8a7f3f191dso142732366b.3 for ; Fri, 13 Sep 2024 02:05:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726218341; x=1726823141; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PdXuev74Pd1olfgKz61gpaAiNbBkmr/G3yeqtDkh8Go=; b=UhJ1/Vulubqz8jVShkgNPA20JzZNKxv/6hy7hEwK8XZl7iAzNGsXo0rH2djVVIibgG pgoXjhjHjXFi1A/mDvF1jKaye5l47GOdBoE9Y3uwC5h2mj89bgIUZBLY9B7Yhwrff/HZ 0TJsKjFJBtW4WNxtqhV2Uj4ODHmQKEpWkyXQ+xspCw9m1fO5AjIBZq1I/QKtvkJ9Mhoc lyeQ/ZIhzr+hBJVUiR+BLRGFp1sZevSv1exTnLNDteh2uhPm9OpApcvBhz8PrWsjGANz a+Y0+k1xJkTUjdQteZU8YtsXyOtpp78t+7EF6xOgXAuT82Hl9SIMZB02nWTUBCRnYuQ5 n9pw== X-Gm-Message-State: AOJu0YxUjE/mEmnSstqsM+IkA1xwfu5HSMsHX+xIyD6m0bzG+MA4sKLG zS/t7RXpjJGDt/dPIKDQbMFP6eaIOvvILG+49yxKOmHQDy8HAcH14tMue0QuOBjDzJV4SRaOWOo YVijhpQt7vo3gqgUoXm0Ba6yhtmknIDuSFAxT5YEUC5faVCfJXbyZaI6BSUajsqmLs7Uk5lHhiT lO5W2Zx8IGMdA/65FLxN/x4jjGHRRA X-Received: by 2002:a17:907:e668:b0:a8a:822e:44c6 with SMTP id a640c23a62f3a-a90293dab80mr620675266b.4.1726218340745; Fri, 13 Sep 2024 02:05:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG15LeIy3IBaPUWZdnqL2MfRlCPuJy1uYg04UJClra80v3+Jxox0yYFVZnxWr9piVz8+ZSMPA== X-Received: by 2002:a17:907:e668:b0:a8a:822e:44c6 with SMTP id a640c23a62f3a-a90293dab80mr620671566b.4.1726218340130; Fri, 13 Sep 2024 02:05:40 -0700 (PDT) Received: from [192.168.0.36] ([78.17.251.183]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25833887sm847765766b.28.2024.09.13.02.05.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Sep 2024 02:05:39 -0700 (PDT) Message-ID: <9aaa3c82-fc68-4f98-a15e-5e991a3d5621@redhat.com> Date: Fri, 13 Sep 2024 10:05:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21.11] net/softnic: fix maybe-uninitialized warning To: stable@dpdk.org Cc: alialnu@nvidia.com References: <20240911141259.55514-1-ktraynor@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20240911141259.55514-1-ktraynor@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/09/2024 15:12, Kevin Traynor wrote: > In pmd_mtr_stats_read() 'struct rte_mtr_stats s' is initialized > during the call to mtr_stats_convert() but on some systems it > is triggering a compiler warning. e.g. > > drivers/net/softnic/rte_eth_softnic_meter.c:916:25: error: 's' > may be used uninitialized [-Werror=maybe-uninitialized] > > Initialize the struct in pmd_mtr_stats_read() to avoid warnings. > > Reported-by: Ali Alnubani > Signed-off-by: Kevin Traynor > --- > drivers/net/softnic/rte_eth_softnic_meter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c b/drivers/net/softnic/rte_eth_softnic_meter.c > index 6b02f43e31..fea26f9c14 100644 > --- a/drivers/net/softnic/rte_eth_softnic_meter.c > +++ b/drivers/net/softnic/rte_eth_softnic_meter.c > @@ -904,5 +904,5 @@ pmd_mtr_stats_read(struct rte_eth_dev *dev, > /* Stats format conversion. */ > if (stats || stats_mask) { > - struct rte_mtr_stats s; > + struct rte_mtr_stats s = {0}; Even though I checked in godbolt, this failed CI for rhel7 gcc 4.8.5 because of the added -Wall, so I will, change to "= {};", re-run CI and apply with that change if all good. > uint64_t s_mask = 0; >