From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE0E1A00C5 for ; Wed, 7 Dec 2022 13:28:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AE2C42B8E; Wed, 7 Dec 2022 13:28:17 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2083.outbound.protection.outlook.com [40.107.243.83]) by mails.dpdk.org (Postfix) with ESMTP id 80D8440156; Wed, 7 Dec 2022 13:28:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rr4ZiaPtKsYglvHyzSEZEUn7YB8EGM7kmCf7FaUj2rVqjl3Cyb6cPIbzB11n/lAXFctpzO8/9t+v4noVxAt0SZdi+iF0imLJ/sRzEu/e5fuv7dIz9KlRf9fnaS3tqO35R76B9DTGVSl3/eXpbVFtSGQxdyS3cViNXDGwzfvWGL9LopAA5+EOMFFg+rnEhth7gj4fXuzETcY/s7LI8sSV/48HLsR/I52c4nSYZb5U4DHpDlZ/DbebgKV2xsUkBoEokUbeVP5csSynX0YztP01wVTwG1TSsqCuNAhVB/kCU0g1lPh8wvGNixUzVCcQ65XT2VxjsPiTHs+UV+SvTa+9xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TMiAT+34IH09+sUVItd8CDBC3iS1IqxFZ0jKvpsvqMI=; b=nrEpJWUgZ8rBAgVfhVoy0kDSK7RdfVvDzs3Z87ozGE68ZLtL6mq1ZYdWvFU5Z1uJGoMIhS/8eDNcaCYu+QGygVd/B7tHhxkDmvm99LqmnvsiT+KzA77pLP1ie3Gv5PQ6cR/MAaJhXGoUrT7oE/spxHtdeMendtJxOpFYge0mIR0s6lchqXDYBYFcaXRZy4ib1LW6RbpyZzKEpCBuJUxOQSwpE8ViOUiL8CEe53TUN+U8015r5Ka1lm/x0xVVJQY/BpzyY1chQeTIUnusFmFe+YcJ9ZzkJ1tectE2SXTONdrgo/UG3/pPzR3Lg/1lwWAYy1BzVQ1Cef5UgrrYxoB1Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMiAT+34IH09+sUVItd8CDBC3iS1IqxFZ0jKvpsvqMI=; b=uMobi2qKC/Sq6CLFx+X5ABLjj57EIlfPLf9vKwSy6sqasEaP0wfcpABgXMJspFbmnBJPDGhtGc2jOOivRCTm53Q5UxbX7/DFNdy2i5pa+rpfTxzfXKKieUCNwcCS3Z9aV3W9AnizYammjzH2vnO6JKHzbY7CUGzCBcOXwWMisKQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7270.namprd12.prod.outlook.com (2603:10b6:806:2b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 12:28:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 12:28:11 +0000 Message-ID: <9b41c93f-579c-34e0-3611-abe77576e9c5@amd.com> Date: Wed, 7 Dec 2022 12:28:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , jin.liu@corigine.com, stable@dpdk.org References: <20221117083320.21815-1-chaoyong.he@corigine.com> <20221129012122.24394-1-chaoyong.he@corigine.com> From: Ferruh Yigit Subject: Re: [PATCH v2] net/nfp: fix issue of data len exceeds descriptor limitation In-Reply-To: <20221129012122.24394-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0024.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7270:EE_ X-MS-Office365-Filtering-Correlation-Id: bfba598d-24b8-48df-3047-08dad84e806f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QSu/W8Uz3FQR6LGkQgcqzuTKXaH7HZ5+2NpYtrA0nRYAL33WntLZxmVoCYdF+3RzsHLxEZGjM+m6Ku3u+yKtxMrFM9xkS8QdwI66pBrlDt/CrmFEzP3l8EfEUZpUOfj0Wciq57f2u1G/RvlBwk35XfXZ1bLgg3IkCliEpxkN5F03j/1Hp3n1IKvUSPAlwOHCnHbHdhkwvopBSpZjj9CdVYSIe/yT6gpJuZKi1qRSDvgGJmrnoazTwExhkGS+Ko8wmYnsdNZ9qbhvbFYghb+1QyDxcyW8tgztwNXh6rVfSxHQoWqHXCe7AZ4RJYJEY1xhnUqlevXKFjrPWLs6nVHC/C4K3loXAYdolLAUkpQ3Y1NP53BJ7hefBQDXeUHt4ZxA0GFbBSv6WHpbnH6zRqq/gEEZ8SXM8vAiaNTaqNx4GzF8N3fy4oG5C2A45QQVbAClAItsCaiSwfxeyn1ETFaE21dnC1aUJSwz42N/6dEPXccVwkYfOfdZK4/Yio0mhlOG5agKEeXqvZAKN2zkdDnIZSoZdkBfTejHn2CUWj0foJaLzwEOi1AVks9skX5gDZ81Io+r96f5WB058m3M6+YX318MhWslliBi89rPQDbr9PzV3brNpItocULlHKCNLldXD/f+63ByaiNzhXlKu5epIJ+tYyzF1+yu8ZMYYVxBTeOMoOmwFlSKVrjY/uWPABJyf0uh3Pny7OBWw0AaXvvvDNnqMR59Dz+uAxRlAX9TwTY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199015)(38100700002)(83380400001)(316002)(4326008)(31696002)(86362001)(8936002)(44832011)(8676002)(66946007)(66476007)(66556008)(2906002)(6666004)(5660300002)(26005)(6506007)(53546011)(6512007)(186003)(2616005)(478600001)(6486002)(41300700001)(31686004)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WngvK296ZG56MVppLzFweHlGVkFSQXBqRmJ3Y3hETnpWUndia1VHVHFlOEFH?= =?utf-8?B?dFBNd1NZYThsUjQzdWt3TUpUTzZ0NWhLUFQrUFZFQmNoZHNKckd1Y3BpV2hD?= =?utf-8?B?WHhGZGx6MmQ5UU5Qb3BMNUNUakVndkFobmQybmRSREg5Q0dmQ0pqR3l1VEhy?= =?utf-8?B?YVAzdkEzdGpUMExJY05UeHdRNWFnNVlYQTU1eERyWVB6TTh1eVRNUWN3bG9H?= =?utf-8?B?Sk1BN1QvdjZsTjRydDE0aE9Wdm9GcVdwODRUWk4zSDliZDQyeVFqeEdHREZK?= =?utf-8?B?YndPTDJucFc5NjV4NjRDemNyNlZkWWJ4cGU5YmtRY2MxMEVTWHJxcDV1VWpH?= =?utf-8?B?c2dSSVRkc0lZWlVYMmJIY1pUZm9KL0ZZY3cvcGhUanBubG42Ris0c1B3b1BH?= =?utf-8?B?SWg0NUNxaURCT2gyREcxcjdCaW5GYzRtWm5aUnBtVGZ2S2tOam55NGEvaXZ0?= =?utf-8?B?Q211U2dGcEVGVkVHT25aeGVQempVNUJHdkVFWklLY042MmZOcjF5czROdTR2?= =?utf-8?B?NjJ1Z1VSeS9QZ3JhbFA3Vi9YTUFmUFhPZm1PaHJ2U0hBbG1kUHZ2RlRTYXZC?= =?utf-8?B?OEJpakRLV05oWGI5TEFtTEFaZjNTT3NOamZFRzlHWEE0OTBKY0pSYlk5Uit0?= =?utf-8?B?NDVabURNR0M4WFhGNEtrSDFlaUU4cFZWMWZhcm9nMEJOVzBsM2MzbFdtaFdL?= =?utf-8?B?dURqQ1krUnhlQUJLVXBJWlVhWGN0L2ovVEpTWnhvWU5hZWt4SUN3a1hGNlQv?= =?utf-8?B?ZXIzaFVJdzlhZVVIb0F2czE3d2w2T293Z2hxNk9MSmNaM0xUMG9pTmJyUlEw?= =?utf-8?B?NlBLU3JrU3RTaGJ2VGVMVmZGVTZCWk5TVVNSTHc5MXZ0T0N0M3ZTTU9MOWZH?= =?utf-8?B?cXcxTkt1eDJZMUdtYjRjdCtvK3NlKzlJM1Y3bXBFRDNMMWJxWndYR2dvT1Z1?= =?utf-8?B?QVZ5T2hyamhYVlhhNFI2SGQ3Vzd2anRYbEJveEhDMFJBOEVVaU0vMmU0OFBa?= =?utf-8?B?dEpFaVRyNll4ekgwOUpQQ05BNG5TY3BoSkdKeWQzU2Fxd3phdVduZEEwMlgy?= =?utf-8?B?QlJOTUVWSVd4V3FFUWZ4MnhKSGs4YzRKRzN3U2JJOXJkN210a3NNZldjT21j?= =?utf-8?B?RS9UYWIyZWFpNExUZXNoVkVwT2V1NlZtc0NhZFk0bjVwR1VoMWFhaCtxMHZK?= =?utf-8?B?L0kvYm1YUlFoVm1Qb2NlRkp0bGhJSHZ2cTVDTThoZExhU2NZTGdoZXdtd01s?= =?utf-8?B?bk5nemVEMllVQzg5dTEyR2pQeXM1dDR6Qkl2YU1kMERWa2c2ZjN0ZExBeHhC?= =?utf-8?B?cHd2dk1DMGt5Yys5VVE5ODNLeTZudEYwaWVxZFNhQzRZWVluemlyRFRqUE8y?= =?utf-8?B?YWxxQXA5ZS9SbW9zM2gyTmJWd3JhaG4ybHZNcTlzcE9jOVFUeXBwSVk5N21F?= =?utf-8?B?NzlQUzFkTk9hemZlbHFGNEtEenA0RytVMVlSTzgvMm9Eb3Q5Ry9sdSs3bTc1?= =?utf-8?B?cGEzU0hHVzA5VHc2LzdRR3Z3S2JsY1V5Y1F3TElqTzl4WEVjYW1uM2FEcldr?= =?utf-8?B?Qkwyb0w5MVN2ZUI1bytWSHVQK2lwN2JPWUc1bXBpNDMwdVVrOEpyWGJvRmVU?= =?utf-8?B?RnNaYVJzZzlYWGJwWE0za0M5a1hGekYvZ2MwUVE2cXhnNU9USGFlK1JxSXR4?= =?utf-8?B?UkRhbWxlblJUcW9COUxSWitNQmIweE5KRVhpZmtDRUhjVTJiNDBRNXk3YTM5?= =?utf-8?B?SThrcGlNQ1lEU3hkUjJmQW9vRmgwell1bGJYNEE5bktEYjgxekJEUW1tSFVk?= =?utf-8?B?NDNuV3pTRlU2MS9ZWGtnVUpyanFrMUdKTDVuV0ZtWE9oVEROWFBWNkJVVkQr?= =?utf-8?B?RE5ua3ZaRlN3MWtFSXY0NE53WHJFenZxcUtVS3JMcEVCSkpPT0JpYkFLNUlQ?= =?utf-8?B?VmowSjlySXl1eXc4dzN5YUtUdjlJNEhhOWZDYUVBU3E2a3pwenN2dUw2a05V?= =?utf-8?B?c0JrU1RVOTRLdEQ4SVZRV2hpczVyakZiOEpMdGs0Yi9CNDJQSHBYQ0JMMEJN?= =?utf-8?B?OUs1WEE4WitrYW4rZ24wYVVnMlMxdVdyQXFnUHcrVmtPQ0NJZDBFd2hNMGhM?= =?utf-8?Q?IFy2Q3qhbAssaLdi19uveyYG2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfba598d-24b8-48df-3047-08dad84e806f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 12:28:11.3301 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0VxdZFa+5uk2ZunSW+UaAUxJCK7ETS/yEbVSPWkSwK+KNFj0Ht4CuqSb8lCnnQCj X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7270 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/29/2022 1:21 AM, Chaoyong He wrote: > From: Long Wu > > If dma_len is larger than NFDK_DESC_TX_DMA_LEN_HEAD, the value of > dma_len bitwise and NFDK_DESC_TX_DMA_LEN_HEAD maybe less than packet > head length and the packet will be dropped. Fill maximum dma_len in > first tx descriptor to make sure the whole head is included in the > first descriptor. In addition, add comments to better explain the > code flow. > updated patch title as: net/nfp: fix Tx packet drop for large data length > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > Cc: jin.liu@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Long Wu > Reviewed-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks. Below changes done while merging. > + /* > + * We will do our best to pass as much data as we can in descriptor > + * and we need to make sure the first descriptor includes whole > + * head since there is limitation in firmware side. Sometimes the > + * value of dma_len bitwise & NFDK_DESC_TX_DMA_LEN_HEAD will less > + * than packet head len. > + */ Updated last line as: " * value of 'dma_len & NFDK_DESC_TX_DMA_LEN_HEAD' will be less " <...> > > + /* > + * The rest of the data (if any) will be in larger dma descritors s/descritors/descriptors/ s/dma/DMA/