From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Ling, WeiX" <weix.ling@intel.com>,
"Jiang, YuX" <yux.jiang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: fix name of bitrate library in meson build
Date: Tue, 15 Sep 2020 13:04:30 +0100 [thread overview]
Message-ID: <9b4f4bae-789d-86da-c4e8-4be51bb64654@intel.com> (raw)
In-Reply-To: <30714b80c3d34c79b91727cdc2403895@intel.com>
On 9/8/2020 7:21 AM, Ling, WeiX wrote:
<...>
>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Thursday, September 3, 2020 12:24 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix name of bitrate library in meson build
>
> The bitrate library in DPDK is actually in a "bitratestats" directory, so that is used by meson for the macro and library name. Therefore, we need to update references to RTE_LIBRTE_BITRATE to RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than supporting both defines, since make is being removed, we can just replace all instances of the former define with the latter.
>
> To ensure testpmd links ok when this is done, we also need to add bitratestats to the list of library dependencies.
>
> Fixes: 5b9656b157d3 ("lib: build with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Tested-by: Ling Wei<weix.ling@intel.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-09-15 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:56 [dpdk-stable] [PATCH] " Bruce Richardson
2020-09-02 16:24 ` [dpdk-stable] [PATCH v2] " Bruce Richardson
2020-09-08 5:35 ` [dpdk-stable] [dpdk-dev] " Jiang, YuX
2020-09-08 6:21 ` Ling, WeiX
2020-09-15 12:04 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b4f4bae-789d-86da-c4e8-4be51bb64654@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=weix.ling@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).