From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFFF442B47 for ; Fri, 19 May 2023 10:47:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5BA642BFE; Fri, 19 May 2023 10:47:50 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by mails.dpdk.org (Postfix) with ESMTP id 6CCCF40F16; Fri, 19 May 2023 10:47:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b+V6i7hhg8c/kfdoRiCoJW3i6DWBoXkm5LgGrEJmv5sRrJYpeoDTQ3js1FUgJYT5CV9UoJCChiibHb677ookRwJ5GelP9AvAygc2qg4yypJMdpuVmE6WwX4P3LLTkNG6nxm5TfgJbNKsJd3rir3vhzOedisTipvaPNirKMu6od2X3jSAo+ocDOjBcxLLTa8mP1jZqDh+TznthOwplLKHHYlBM3EQj1Ecgj2W6nFKXmwKH8V62M+TOmBRmKgS3+ZB1+lbaLPHtM68AfcpvLWw7I4/EACV0LtLAGnN/9/qf2PsYVt+hlCn+I779F1RAoxQfqlPnA4oP1nNfPiPMbyZXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwg7rUc4TWglkWLvoEm7oVEv9v875c1b+ZLFO1Xytrw=; b=nAFSak3G6RnUSx4iLweoRfBJ+hiTpGSebbF5guzhz36LtXZ2LxUCcauvfnl6c5f1Ey/I2LFfqLUM9vWC8qHhjEvMbqPwSFMfG5/8muEqBTtxZNnE157qiOwuU5Kn8cLRWAYApcElkojQ+aJwYtfw0J9AdcP/lPRsTFUvbkwVEqMnW/IGPuJrvYW4xdghv6GYgaUIQ4b+MTv/TV0ldzMYqsInSwvCReD8NikLGOYaPrs58b2Ii8kuMKMx2XCqSfyEyh5EOX0RA/RKyUhKvSDXIFTDtsp+Tkq5MiYOVBmh16LsFNKj11jJorLV5VMz3ml1iOG8bHYPbYjbX9FN+bGCnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwg7rUc4TWglkWLvoEm7oVEv9v875c1b+ZLFO1Xytrw=; b=0faSakRYaP0nZi//f8JOv6adjUUsQM1I8tUB8pMXaFSkm6l5ol93hqoFDsuLKsyJz+1ssxPbffdjKf3oyEPQsseWn1j/1oLicOSL6rNumM/bO4MvNjggvF6gQkUCMyzRENu6mAO/ylIrfy8fHsyetYQwSh+SNcbkOPB7N2EN8wc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV2PR12MB5797.namprd12.prod.outlook.com (2603:10b6:408:17b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Fri, 19 May 2023 08:47:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Fri, 19 May 2023 08:47:45 +0000 Message-ID: <9b77c98f-222f-566e-ec5a-8cf256d98d62@amd.com> Date: Fri, 19 May 2023 09:47:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Ivan Malov Cc: dev@dpdk.org, Andrew Rybchenko , stable@dpdk.org, Andy Moreton , Denis Pryazhennikov References: <20230424143046.6487-1-ivan.malov@arknetworks.am> <18f3e3aa-1fc1-24a8-50c5-90e45e9cd688@amd.com> Content-Language: en-US From: Ferruh Yigit Subject: Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0227.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV2PR12MB5797:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bdeb6a7-f688-4420-90de-08db5845b725 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yfNk/iZyJTvqHviT5He74p2x2xnuT/fgtPoj3cOYxQ1nDOmkXJTxusVd3Llep/fiLP/R3W6ev3lNRAr3CcvKoZctzlstjExrZKWBq/+mb6DF35+xYQlEVKmzfEyy8bsOmO1s9qFHHkAQ5cajk2rL4TC7QlzNoVV3RCNQwovIqpaIekzq5E6TuKplKxcTixZZcZsf0rNHW5Ixj0fyirxuxHAYvodd+7qmbKXgUP0p8+5yLDcI7UdGIpbtbNJoUeO0n/cMNtT6eUV2efOeAY1+YiQ4sNio/PnpHYTo44Nx8PsPb+eYaV3Eu6h+ChoFUzHMdcL81UUoxU9fFkBWwJGkZnHnK6tFxMb2FUsK/n/4IBwOQcHXqBVTF7uN7tMNay9GD4ImTf9uhxu55tEfaLUH8nhsJzKXuNwaaGbyc5c3STb/xEQA6T4lagUiaaivldGcuk/3mIw+Cclug4fA9+008Ij2ABk1+uY6j8akch+4Husz5UdM3MQVjhEQ4q92Fxu0vlEK+/c810P4vI1rdkEttnpW9QROpOPxY9uZIsIjOtbvNGhXwmqDAPqGxBcnGxRtjmcj5LKjUL5u7AnxjooPZzhtGBK+oibMm4x7Q8U/HsHF+A2NZDIg5RF6o/qL3r9TwYQK+kkXtVX2Ttu5kt2aLw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(451199021)(6512007)(6506007)(31696002)(2906002)(186003)(53546011)(26005)(86362001)(83380400001)(2616005)(36756003)(38100700002)(316002)(41300700001)(6666004)(6486002)(6916009)(4326008)(66556008)(66946007)(66476007)(54906003)(31686004)(478600001)(5660300002)(44832011)(8676002)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yms3bkRwa0JraFlwSG1vYnplUk95VnZhODNORy9SQUR5YlYrV3F2K0tuQ3hY?= =?utf-8?B?bUJHditEcUxZYmdXK01TaklRbjV5VVlhWEFMZ1ZpWklZV3dUdjd4TjNLRUcr?= =?utf-8?B?UFEzYmRrMU9CWjNXUUhQU1BGb1Z5TmVVczQvbEtQbXpxQmZpcW05QWx3eERt?= =?utf-8?B?dFpFeEgrdDZkUkFoY1VJWERYT05teTdMdGpxUmxHeXdNTlRaTW1Qc0FLcWFx?= =?utf-8?B?b1dHSDN3MG94Y3U4RG5MSlVZdWk3OFEybGMxOE4yWk9hc1NNMmdERXJjSGVS?= =?utf-8?B?ekNNV0NLQ2hOL096ZnRwckV6T012UFdxZ2xGa1lCblZZQVdnQk5kQTZSMks5?= =?utf-8?B?RlllYmVRNWRnR3owV25vVWwrOW8wQnBYbGtqNGJ4UGdNM2c3NzRpTjhtZVJI?= =?utf-8?B?QVJSRk56aVhWNU5HYnpmenNjZnRBeWRoTWhsUnp5TkdHYitxeDVQQmc4M0My?= =?utf-8?B?bGo2M1NidkRkR0MrK3JySVV1MEVlZ3oyNjJKWEVjQzNlSXNDaE5zNnVyc1BK?= =?utf-8?B?RVl4VEY2TXN2LzgxeWhlMVZmRUlYYVFxZEgyOTN2a1NjWkJtMHBFYkN5dVBm?= =?utf-8?B?cmpnWWl5VUZnR2VnS0ZQekpCL0ZjSlVoZVR5eDY4Z3lTU0txVlpnMmJKWFFy?= =?utf-8?B?TnlQR3drNzRuL293cktrd0x0enl6WTZzbGl3ZGpQcEFNT1U2bEoySXlCZE96?= =?utf-8?B?ZkhuL0hGSkVYSUtCSFFVdGpRdm1Ra2pZeDNNTlVLcXVuV0RDMTN3K3R6cnM1?= =?utf-8?B?TmdMRkY0L2RkNTJ6QWJwcHF0WlA4cWhDT2RWWkNiTnR1MHdkRE55TDM2ZGpT?= =?utf-8?B?NnRmWEhneXNYOXhvWGpBMHRIVGtMZ0R2bHpFem5CcUhMazVnclNkelVFSGNa?= =?utf-8?B?RVp3K2kxY3VVRTdReGh3QVFQazZJdHNYeXhBZDU3VlVLV0NWV2w4NzZKeVZi?= =?utf-8?B?OVU4bDFSenp4SWI4TklUSmNCRE53NEZNeU9Fa2U1dnc3RTdkWnRYV09QREJh?= =?utf-8?B?bXRVK0FTOXlzSVBMSm5qOG5McTUvNnF2R0tHQ3lGQTFrQ005S2tlcUlvcWxK?= =?utf-8?B?RFREZjRYTXljT1RWS1d2VFRJMVRJVnNXUEk2amNpRUx4VnMvWnRXajRoQStW?= =?utf-8?B?M0wxNitpYmdTSkRuQWhjaEgzR0xTUTdaNHZNdjYzUys2cUpxMmdXRS9UMXB5?= =?utf-8?B?azFCMmhrUG1hcHh2VTIzSXJhM2xHWFZpUmhSNjdjSmZZVlM3U2YvWFo0Skww?= =?utf-8?B?bUhVWFJvQnMxd1JPT29Vc2JtOFg0RzFDSG1lRE11S01ieVNsNFJFYVFMaUlw?= =?utf-8?B?d1Q3MHVZVDZ0ek9lUDhWb2hQNnR2dTY4dzVFT0RqcUtPVGd6ZnZXejRTc3Iy?= =?utf-8?B?VE9qZDlWUWpzRDF5VDVIRFQxN3FUc3haUWErNURNVkZia0RZcERhWS9LTTJ1?= =?utf-8?B?aGZxNExOTEtDYkFVNWFQaHNUT0psbUJZZW1GU3ptZmZJR2VuYmpyLy9KWHRw?= =?utf-8?B?ZUJOL1RHWVlSMzQ2cytaN1FNQU5nLzIzUDM2c3o0RkJyaW9hR2cwbnJqM3px?= =?utf-8?B?NHJhOC9MNko0R0hQR09VT2s2bXhKdWs4dEZrYkFTZ3VxeExnQVZyMWJGMU9J?= =?utf-8?B?bTNySjVsY2VvT3FBOFNzQ0czVzNzT2VYd0EzUzFlemNPUTVMY1F1YnVGS2pw?= =?utf-8?B?UzljQ2QzNzZVZCtBa21EcUw1cEJhMXRQcWN5OU9kS0lkQVJsaEtNd1VScksv?= =?utf-8?B?Zk1YM0xpalJCYW0zb095VTNscVdlTEwxemNINXlINUVQT05vVWRuMVRXaFBO?= =?utf-8?B?TVplYTQwT2FQMFZIMUhQTGRqM2d4ZXBEMVIxaEx5b08rQ3hkYlUyd2c2OEFD?= =?utf-8?B?RmFjMnNDZjdHQnBXc1ZPVjRIR0docUFzNVdYLzlzYW1OcE1QUXIyM0xVd1du?= =?utf-8?B?MUxRZWp6WkFxOXFLMDVWbDQyekh0QTQvRlZzVHFJSGdPMHVtYngvWmUyL2pq?= =?utf-8?B?Z3ZlNjhLMUJsZkV6eTJydWJ6bThHZmV2akNSdEpjRWFLR2NYMGwzNk9qYnNS?= =?utf-8?B?Q1V5QXlMUmtSTHhIaGc3MVl4SXA5MyttaDZSV0tVUEZHQWp2WDN6dndxdFpx?= =?utf-8?Q?6VUAuxcX+2rnEgj2hQ6dH7+09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bdeb6a7-f688-4420-90de-08db5845b725 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 08:47:45.4572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I6qW6dNWZ7yB9lmI/O3uMMmC3fPiIy9Lo+H2ybv4c2I2ndAFmI7qc1MS/SIPT8jE X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5797 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/18/2023 6:21 PM, Ivan Malov wrote: > Hi Ferruh, > > Thanks for reviewing this. PSB. > > On Thu, 18 May 2023, Ferruh Yigit wrote: > >> On 4/24/2023 3:30 PM, Ivan Malov wrote: >>> When the client driver (the DPDK one, for instance) parses user flow >>> actions, it ends up with an action set specification. Next, in case >>> there are any FW resource-backed actions, like COUNT or SET_DST_MAC, >>> the driver allocates these resources and indicates their IDs in the >>> action set specification. The API used to set these IDs checks that >>> the current value of the target ID is INVALID, prior to the call. >>> >>> The latter check, however, prevents the driver from updating the >>> IDs on port restart. When the port goes down, the driver frees >>> the resources. When the port goes up, the driver reallocates >>> them, tries to set the IDs in the specification and fails. >>> >>> In order to address the problem, add an API to drop the >>> current resource IDs in the actions set specification. >>> >>> Fixes: 3907defa5bf0 ("common/sfc_efx/base: support adding encap >>> action to a set") >>> Cc: stable@dpdk.org> >> >> Hi Ivan, >> >> As far as I understand this patch extracts some code into a function, so >> I expect no functional change in this patch. So not clear what this >> patch is fixing? >> >> And I can see this new API is used in next patch and it fixes an issue. >> But while backporting this fix to LTS we want both patch to backport >> because there is a dependency. >> >> If there is no functional change in this patch, what about merging these >> two patches, and explain what is fixed? This also helps backporting. >> > > As far as I know, changes to different trees (common/sfc_efx/base on the > one hand and drivers/net/sfc on the other) belong in separate patches. > Please correct me in case I've got that wrong. > > Anyway, if it's not that hard to backport the two patches in their > current state, I vote for keeping them like that. I don't insist. > I think changes are simple and can go into single patch to help dependency between two.