From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEC09A0573 for ; Tue, 22 Nov 2022 03:02:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C32A042D3D; Tue, 22 Nov 2022 03:02:17 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2052.outbound.protection.outlook.com [40.107.100.52]) by mails.dpdk.org (Postfix) with ESMTP id 41D6440A80; Tue, 22 Nov 2022 03:02:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N75+ZRNgoVabDbDjpukESlVP4/GXyWcweLruY1L2eIVlck5fOxGcNAlf6IViL8pNjrKB0Y99es5pOqZ3D0B6KHMZPyEztXcps3K7fgS5UHPG8wmV94QqGcGnHdW6X5Q3QUyeT1CdzvXO60VkQFzCqG3QUnMfxqf6LzngT61wKiVCWig/N0Dalc3o3SDO8qenaRYBBkXzzDEVUhH3NfqyN9XCL2zQ18MKNamKtBD91ZrJSw3u7rjN4vP1URtDaUfet3FKSZr1aRp8zJf2/u/7lPpMXXRVSj87ncYlsAX97JxKJKwVVrP8mzgZoQjkIOWBffY/vhWrIfI+jazEnED2RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l9j46VSxCTVrvp//oxMLKJZU3NV8MrNxCDPsOfxe1TQ=; b=DT8d6D0sPMi2i3Q7qjxzU72rS4fX09/VvQUcTK8t3NiUH6sQgJgcqEy5tcvxkLPW/p3JPHREtMZrFtIXVy323C8CAM9Odfi79nsX0/ZvUNEtrPCQIDmCCVAstX/1gf7DMz5SDMC+iCp/tF/y8rtacRJvdweZjohumFqSkIqY29f8i82PUWQMZqdRcFaob2YSRh9nZwySGruEPYsA1OVMUsRsxHIegFRQr9j8XoGh8bT6P0WgbIbCnjJflr8wDKAg+hvbCVuUg6DVm23KNGhmUFFiYb++9rf4iWadHvOaSODczU4aMupTwq2UCfDC0Rw7ZlWqbouhQ5E2V0IJRI5vCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l9j46VSxCTVrvp//oxMLKJZU3NV8MrNxCDPsOfxe1TQ=; b=jN36mWiuyD7Xae5zlBPH7qQUPF2QMK4Le4LwefvnAnHlZqh+dQN9JJ+BtFYEgnqaNgV3BO7XlwyOM4mPSywKbONC6q5DQzLtZL/R4uh1S1bzxrXP3fJqy6cfwGLAWHhmmDYQ6bUg98HduBxdlcDCBzDlTWuX3tqXAbyyeApT1/A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM8PR12MB5445.namprd12.prod.outlook.com (2603:10b6:8:24::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 02:02:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5834.015; Tue, 22 Nov 2022 02:02:13 +0000 Message-ID: <9cc141c5-275e-4c5c-af6c-d4fdcc7720b4@amd.com> Date: Tue, 22 Nov 2022 02:02:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] net/nfp: fix return path in TSO processing function Content-Language: en-US To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , dev@dpdk.org Cc: oss-drivers@corigine.com, Fei Qin , stable@dpdk.org, Chaoyong He References: <20221118162306.975425-1-niklas.soderlund@corigine.com> From: Ferruh Yigit In-Reply-To: <20221118162306.975425-1-niklas.soderlund@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0106.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::21) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM8PR12MB5445:EE_ X-MS-Office365-Filtering-Correlation-Id: 3941c875-279f-4ca4-0e39-08dacc2d92e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cxcblJ2XwAMGlIr+J0AKvYZmYAVSAxhXpf1F6gt27nKfoZRRURmP7fhrhscclwpS2vzubG5M3coF80xejaLkNzohvbiHEkFoWw3J4HPLP89KLLC+3Y3ga4NUQTaaBv3B2w23mKxkRk8nO+rsLPllG+7O5v7uxyORZqE8ahDWhSS2tastsyZ5NyjNSEgjld+DYAERxG8sHTnJOkGGWZViKnXNf+42k1zfsUsbHsWKVImRQ9UJWBzs3DxaFj//mxj5IowXWe/WKkJT+xCnKdKe4gcBujrPYG9Vu4Bhvxd0kTAL1quo5t7G+jmHVXm8NXT5dzYnWA5q06NiqdEaNKfI+4f8KYO68L0xpekSZdoEf2GmokbG6sE12U9ZK9kgK881ET2LTr3eHRW81jmoTyxIXAGfhdxBpX1hGQaDXwA2aOqrw7rs/pFTUTHohhlskx9XBuZWJVilGFyFh9ikXo7t/nmLl8VYk7T/UkScWJkzKil8/oMdYX1nFUtGc9oCh8LZjBD8/hiNAQRWL5nF537JckO5okguTiUMRMxdC2Iif0Sk0m1tEzdK1twN455Lsmhkh4qfDh3cYIbBSQ3EmoW8cDu5OhooaPh5dgxwAZs9lC64QJ71sdhESS8mkc35U74ijgDQPIUMQ+B5fAYbBK88kyqajJeYvPvP1WaGGNJFp1JyOU9XxkBT8DoOh81/6EZhCk4Srcdy+9AbVas/qnX81D3RYbZVbFAOIfmJvR0bgNc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(396003)(39860400002)(376002)(136003)(451199015)(41300700001)(31686004)(8936002)(4744005)(5660300002)(4326008)(54906003)(316002)(66556008)(66476007)(66946007)(8676002)(44832011)(478600001)(2616005)(36756003)(2906002)(53546011)(6486002)(6512007)(6506007)(6666004)(186003)(26005)(38100700002)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzNXRTR2bWd6TU54QWNXcUpnTmhPWnhSbWhMVlhabE1KV1VoTk1JWGJscUMw?= =?utf-8?B?QVhtZ0FSTWo1L2Q0djNKVzFXUmkvN1hua1hYN1JJWE02THdFbDFDeDFIZG9W?= =?utf-8?B?WGllK2ZzWGlENFNYL2wreTIyT2hPQmVWNHl5WXVPaUVtRzRRdEJaaDh4dGMz?= =?utf-8?B?R1JXYzBraEVZTUhaN2VIZHdzbXM0UFlENzNtaFJ0clJoUUdyZVlVMHVobEFq?= =?utf-8?B?UXFRck4wQ0tGRno0amYrUUhUU0VqaGxqSmdteWZnbnY3VThLWktma3lqdGZK?= =?utf-8?B?NzZnTXFPdVQ3VkxUaGlzblVteFBBS2xYZVRCd0xCMTlLR242a3hNcGgyaU5o?= =?utf-8?B?QWhhZ3ZyT3Q3ZTB5N0MzREREbDhBcDFGb2MrUGVwODUrUkpndUFnQlI1TWhV?= =?utf-8?B?cG54VmY1SVJMYzRFUGxUYmo2NmliYkFVVU5HSzRERit5blI5aU1qSmw1MDNx?= =?utf-8?B?a05XdmdSbk1oa3UvamUyTDF6c0dyQjgrK3RYcXpaYzBWRDc4czIzbDNEajZq?= =?utf-8?B?M1c5TVRUdUxBbzN3em9lY25za1VDaG04em9YMStkeHNSdEFqL2Fyb0hacTFL?= =?utf-8?B?Q01nVFpCSndkWExpVG55c3BseGFWMjZkbldaN1Nnd0JFK3ZhRnNyNFZYTTlF?= =?utf-8?B?Sm1Eck9UQjBvWjVUL2E4WHM5dnVEZzYxT3dXRTBjeGpvNm5DcEgxR2R4anFZ?= =?utf-8?B?QUdzZ1FTY0J3cmJGWk5KWjhTOHlkeXFoNHNyaFZ1S3RMOEdYMHVTSFB0Yy9p?= =?utf-8?B?N1BEeDZtRFNlWVhiVUg3QVFaVFFmcTVGN3k0QUdNcUptMTZadmZLMDV1cE9C?= =?utf-8?B?aFE0ZlphNk5SczltNm5MeFlVUE9WS05TS09FeTk4ekRMVW05aUdqQXExaHNw?= =?utf-8?B?WStwbUc3VUUzRG5aQUYyYTFZa1IzOUJiQkQzWTZpY1hJTlB2M2IwRndQQmFv?= =?utf-8?B?OUF2S21yZkVMdTl6ZjkxSnJJaDNhUjB0R09JR0tjMHNNUDk0dnZKWEM5VTEw?= =?utf-8?B?MTZUNGZaWE5CMGVnNTc1bkpZQUVuUlpsUFk1SGJEbk1qZnRqaTVLdDdhTVdu?= =?utf-8?B?NVdXdVZBM0lMM3owcUhoOFhsSWUyOWxQVE1aS0VtZHAvQkhFN1V3R0JiTW9l?= =?utf-8?B?SEhFNDlmWFJyTmo4STlSRERxQk0zTi9Ia0d1eDd2OFlMMmczcnlmV1NpTU1J?= =?utf-8?B?RUtUOTQ3YlFPRnd5dzV4ZDVwQmw4UHpJN21PZi9IelBXVEpLTm0yc05TK05q?= =?utf-8?B?SGRTSzBKQ3YrUStqWEE4WmxiYXo2ZWl6amhQVTZHam01ZUZBZnlTcnBqT1BG?= =?utf-8?B?QVFRSVdNTXhtV1VZcTRJR3g4VEZGWi9MS0U2U3hIUnBRa1k4amRlRWxlWGZV?= =?utf-8?B?bGZSeWNkQXdYejdBMCtTQkdCOGE5THlJM0RxeGZIZ0FlZWhRM0lCazYxYncw?= =?utf-8?B?RGkrRW5JYTVWbnNzUElxOTRESTJDbjNvWFY0cHdiQ0F3Q1FyN0pzOFo2Z09a?= =?utf-8?B?dkgyYjBPbmpBdThpc1FoSUJxSnlrNWpuaXZwbDVPTlFBR3BtbDl1aTlPYlN5?= =?utf-8?B?aEZiMkcyZm13Qy9rU0U5L0RNckpFV3BxeVUyajhmRXIwZVBlbCt1R0NlbFZ0?= =?utf-8?B?T3orZzFjSE5vc3R2ZHFobm1oVjBjUjdJdlU1T0Z5UzRWcUFRNTFZSS80NEtN?= =?utf-8?B?ZWtGVTNDeHpHSDFYSDk5cmw5WERGenNvaVl2bGxNb1VZbkpFUi9TbTZRMmRX?= =?utf-8?B?VW9WVkFiMjJSMEJJazJLZVBVdTUzb1FIVFdVVlA0TDZjUFRZNkxpQlFoYk5h?= =?utf-8?B?eHI1TDdUbDNJUFdYK2ZEOUZUMEkxL0lRWVNQWVYxRFoySmc0VTBOYzVZQVhI?= =?utf-8?B?WVlRV3dQbFFPb2trSFB5M3hFSVhXcVJUVnVZVS90dlZRa3I5SjYrb0NxVlVy?= =?utf-8?B?RFVwOG4vT2hUR1I2OUdrNkgrSkpjWkd3WVRaWThoL0N5azZZQlhrUkRPNVR0?= =?utf-8?B?M2ZpUTJzSzVoUUcrQ2hLMFlGMGE2OW5SUldkR2ZOOHJ6ajVtdmRlZE95enla?= =?utf-8?B?SGFJd2dRVzdSbVI1cDQ4VTRINkpLK25PZldpdmRuaGR5RUQyM3g2ZUhwVEpQ?= =?utf-8?Q?JrPR+Otslu6m9S2EQx/YLqcOd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3941c875-279f-4ca4-0e39-08dacc2d92e5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 02:02:13.8769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BTxLGrXJJuP+t1zj+Jy3Dnd17Y6xRRHoGtd59DUMi4lFjx90kUOZmiPMKlXCejI2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5445 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/18/2022 4:23 PM, Niklas Söderlund wrote: > From: Fei Qin > > When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx > descriptor. However, the return path for TSO is lost and the LSO related > fields of Tx descriptor is filled with zeros which prevents packets from > being sent. > > This patch fixes the return path in TSO processing function to make sure > TSO works fine. > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > Cc: stable@dpdk.org > > Signed-off-by: Fei Qin > Reviewed-by: Niklas Söderlund > Reviewed-by: Chaoyong He > Signed-off-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.